Request for new upstream version 1.3 upgrade

Debdiff attached

The attachment "wakeup_1.3.debdiff" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

this looks like a bugfix release which can also go in after the feature freeze.

concerning the diff:
subprocess.checkoutput does not exist
you probably want
subprocess.check_output

I also made a couple of crash reports public, it might be worth fixing them, if they aren't yet.

Thanks for responding, Julian. Great to hear this can go in after feature freeze. Thanks for pointing out the check_output mistake, and for making public the other crashes. Some of the other crashes I believe I have fixed already, but is there any way I can get access to those crash reports automatically in the future?

I will get to these fixes tonight. Since this can go in after feature freeze, I suppose that shouldn't be an issue....

Also, please don't use bare "except:" stanzas. This will also hide syntax errors and unknown identifiers like "subprocess.checkoutput". Only intercept the exceptions that you actually expect, such as subprocess.CalledProcessError.

Thanks!

Hi dsglass, thanks for your contribution! Since it sounds like there's still some odds and ends left to square away I'm unsubscribing ubuntu-sponsors for the time being. Please do re-subscribe us when the branch is ready to go.

if you still want the update in quantal it needs to be soon.
please also take note that there was an update of the package due to python-evolution being broken.

Thanks for the heads up Julian, the code should be ready now unless there are some last minute fixes to do that I've missed. Attached is the debdiff. If this can hold off for a day just to check on bug 1050273, that would be great, but it's not essential.

the new tarball contains a ~ backup file, can it still be removed, it makes the diff hard to review?

lintian4python also reports following:
e: wakeup: pyflakes-undefined-name usr/bin/wakeup-settings:529: pluginPref
e: wakeup: pyflakes-undefined-name usr/bin/wakeup-settings:535: pluginPref
e: wakeup: pyflakes-undefined-name usr/share/wakeup/alarm.py:36: prop
e: wakeup: pyflakes-import-shadowed-by-loop-var usr/share/wakeup/setnextalarm.py:37: alarm line 13

the first three look like real bugs, the last is probably just a potential future bug.

Hi Julian, sorry about the backup files, here's a new debdiff without them attached. Those warnings I think are fine. The first three are picking up that I have defined variables using an exec call, which is maybe not the best practice but work perfectly fine and have not ever been the cause of any bugs. The last one I think is also not a problem for now - it thinks there's a recursive import or something, because the code says "from alarm import alarm", the second alarm being the only function. Again, maybe not the practice, but probably not something to hold up the build. If you do think these are critical I can work on them, but I'd prefer to at this point leave them for now.

why do you wipe the crontab if the check_output fails for some reason?
this occurs several times
+ try:
+ subprocess.check_output(['crontab', '-l'])
+ except subprocess.CalledProcessError:
+ newcron = subprocess.Popen(['crontab', '-'], stdin = subprocess.PIPE)
+ newcron.communicate("")

I'm guessing this is a typo and it should be -l in the second call too.
I don't really see why you use the try, except at all
just stick with the second version or copy paste the check_output code into your program if you want python 2.6 compatibility

The call to crontab -l fails if there is no crontab. Without this check, wakeup fails to set any alarms when no crontab yet exists. The second call is NOT meant to be "-l", it is good as is. This just creates a new crontab when none exists.

That is, if `crontab -l` fails, there is no cron set up, and so we call `echo "" | crontab -`, which creates a new empty cron file.

(I should also mention that there is a bug associated with this which these lines fix: LP: #998927)

a yes makes sense
uploaded

This bug was fixed in the package wakeup - 1.3-0ubuntu1

---------------
wakeup (1.3-0ubuntu1) quantal; urgency=low

  [ David Glass ]
  * New upstream release (LP: #1040213)
   - Create new crontab if none exists (LP: #998927)
   - Fix setalarm treatment of asterisks (LP: #990946)
   - Fix syntax error in reading gmail (LP: #1002871)
   - Replace google weather with yahoo (LP: #1049329)
   - remove dependency on python-evolution (LP: #935883)
  * Updated packaging
   - removed Depends:weather-util, replaced by pywapi in v1.2

  [ Julian Taylor ]
  * fix debian/watch
 -- David Glass <email address hidden> Sun, 23 Sep 2012 19:30:09 -0700

Hi Julian, I see the build log removes the Evolution plugin (see below), which was a change put in to avoid python-evolution dependence due to me being slow on fixing that, but version 1.3 actually has a working Evolution plugin without that dependency

I'm not sure how to fix this, since I was not the one to add it, but the wakeup_1.2-0ubuntu2 has this in the debdiff:
+install/wakeup::
+ # Removing EvolutionData plugin which won't work anymore...
+ rm -rf $(CURDIR)/debian/wakeup/usr/share/wakeup/plugin_settings/EvolutionData.plugin
+ rm -rf $(CURDIR)/debian/wakeup/usr/share/wakeup/plugin_scripts/EvolutionData
+ rm -rf $(CURDIR)/debian/wakeup/usr/share/wakeup/default_plugin_confs/EvolutionData

The build log shows:
# Removing EvolutionData plugin which won't work anymore...
rm -rf /build/buildd/wakeup-1.3/debian/wakeup/usr/share/wakeup/plugin_settings/EvolutionData.plugin
rm -rf /build/buildd/wakeup-1.3/debian/wakeup/usr/share/wakeup/plugin_scripts/EvolutionData
rm -rf /build/buildd/wakeup-1.3/debian/wakeup/usr/share/wakeup/default_plugin_confs/EvolutionData

I ah see, my debdiff was between wakeup_1.2-0ubuntu1 and wakeup_1.3.
Here's a debdiff between wakeup_1.2-0ubuntu2 and wakeup_1.3

Could you please reupload?

please provide a debdiff based on 1.3-0ubuntu1

Okay, great. I believe this should do it.

uploaded

Looks great, thanks for all the help!