Apport should ignore desktop files with NoDisplay=true when checking for desktop applications

Bug #1048524 reported by Matthew Paul Thomas
24
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Apport
Fix Released
High
Martin Pitt
Compiz
Invalid
Undecided
Unassigned
apport (Ubuntu)
Fix Released
Undecided
Martin Pitt

Bug Description

apport 2.5.1-0ubuntu7, compiz 1:0.9.8.0-0ubuntu1, Ubuntu Q

1. Trigger a crash in Compiz, and wait for it to restart.

What happens: An alert appears saying "The application Compiz has closed unexpectedly" -- including an option to "Relaunch" Compiz, when it's already running.

What should happen: An alert appears saying that Ubuntu had an internal error.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :
tags: added: classification
Evan (ev)
tags: added: whoopsie-daisy
Revision history for this message
Evan (ev) wrote :

Compiz has a desktop file, inexplicably: /usr/share/applications/compiz.desktop. I'm not sure why anyone would ever want to launch a window manager from a menu. We should probably patch this out.

Changed in apport:
importance: Undecided → Low
status: New → Confirmed
Changed in compiz:
status: New → Invalid
Revision history for this message
Evan (ev) wrote :

Ah, I missed that NoDisplay=true line.

summary: - Compiz crash inappropriately presented as an application
+ Apport should ignore desktop files with NoDisplay=true when checking for
+ desktop applications
Changed in apport:
importance: Low → High
status: Confirmed → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in apport (Ubuntu):
status: New → Confirmed
Revision history for this message
Martin Pitt (pitti) wrote :

Quick reproducer: python3 -c 'from apport.fileutils import *; print(find_package_desktopfile("compiz-core"))'

Changed in apport:
assignee: nobody → Martin Pitt (pitti)
status: Triaged → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :
Changed in apport:
status: In Progress → Fix Released
Changed in apport (Ubuntu):
status: Confirmed → Fix Committed
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.6.3-0ubuntu1

---------------
apport (2.6.3-0ubuntu1) raring; urgency=low

  * New upstream release. Changes since our previous snapshot:
    - debian.py: Only reject reports with useless stack traces if the report
      actually has a stack trace at all.
    - debian.py: Fix UTF-8 string handling. Thanks Ritesh Raj Sarraf.
    - debian.py: Fix crash on broken "Package" fields, as generated by current
      Debian/Ubuntu dkms package.
    - data/apport: Call fsync when writing upstart crash reports.
    - report.py, add_gdb_info(): Handle libnih's assertion messages.
      (LP: #997359)
    - apport-gtk, apport-kde: Don't provide an option to restart a crashed
      application when the crash occurred in a thread (LP: #1033902).
    - apport-retrace: Disallow option -C without option -S. Thanks Kyle
      Nitzsche.
    - fileutils.py, mark_report_upload(): Refresh the .upload stamps if a
      previous version of the report was already uploaded, but another
      instance of the problem happened since then. Thanks Brian Murray. (LP:
      #1084296)
    - Ignore implausibly low addresses when computing
      StacktraceAddressSignature. These are usually artifacts from gdb when
      not having debug symbols, and having too many of them prevents proper
      client-side duplicate detection and proper bucketing in daisy.
      (LP: #1084996)
    - fileutils.py: Ignore .desktop files with NoDisplay=true. (LP: #1048524)
  * debian/tests/control: Run tests as root, just like before switching our
    autopkgtests to run as user "ubuntu" by default. This enables a couple of
    extra tests, and avoids some confusion because the distro and the user
    name are identical.
  * data/package-hooks/source_linux-nexus7.py: Fix PEP-8 error.
 -- Martin Pitt <email address hidden> Fri, 30 Nov 2012 18:00:01 +0100

Changed in apport (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.