winff did not fully transition to libav in Ubuntu

Hi,

Thanks for taking the time to report this issue. As I now find out, the way I handled the migration from ffmpeg to libav in Ubuntu was incomplete.

Winff depends on libav-tools or ffmpeg. Apparently, as can be expected in Ubuntu 12.10, you have libav-tools installed. The problem is the detection of avconv/ffmpeg executable. I could fix that easily for new installs (I was even convinced that I had done that), but it is a lot more difficult to fix it correctly for people already having run Winff before, as the path to "ffmpeg" is stored in user settings.

As Ubuntu 12.10 is following the libav instead of the ffmpeg version of the library and tools, he proper way to fix this for people running into this bug is NOT by installing the ffmpeg package but by changing the path in the Edit -> Preferences -> Linux -> "Path to FFmpeg Executable" to /usr/bin/avconv

I now notice that the warning that you get when the wrong path is configured is wrong: "Could not find FFPlay" instead of "Could not find FFMpeg."

I now notice that I forgot to update the description of the winff package as it should mention libav too.

So summarizing:
- description of the package should change (either not mention ffmpeg or ALSO mention avconv
- detection upon first run of winff should find avconv if installed
- error message upon conversion when converter can not be found is mentioning the player instead of the converter
- error messages should be updated to not only mention ffmpeg
- preferences window should not mention only ffmpeg
* I don't consider really depending on ffmpeg the solution for this bug

Paul

I created a debdiff for most of the changes mentioned in my previous comment.

I consider the strings in the winff source too much impact to change, so I left that for the next winff release.

Fixed in this debdiff:
+ description of the package should change -> ALSO mention avconv
+ detection upon first run of winff should find avconv if installed
+ error message upon conversion when converter can not be found is mentioning the player instead of the converter
- error messages should be updated to not only mention ffmpeg
- preferences window should not mention only ffmpeg

Hi,

Thanks for your patch: upstream seems to have also changed the error message and the window, to be less confusing, so I'll amend your patch to add that part (5 more lines).

Test building right now and testing then. I'll upload it after.

I assume this is not worth sending the patch to Debian as you are the Debian maintainer, right?

Thanks,

Fabrice

> Thanks for your patch: upstream seems to have also changed the error
> message and the window, to be less confusing, so I'll amend your patch
> to add that part (5 more lines).

Sure, fine. The issue that I wanted to prevent in Ubuntu is that the
translations will be out of sync, that is why I did not put them in the
Ubuntu patch.

I commit this kind of bug fixes upstream, so it was me who did that.

> I assume this is not worth sending the patch to Debian as you are the
> Debian maintainer, right?

Right, I will upload a new version to Debian experimental somewhere this
week. I am still thinking if I want to release a new 1.4.x version of
Winff for this.

Paul

P.S. @Fabrice, would you mind commenting on my application for per
package upload rights:
https://wiki.ubuntu.com/Elbrus/PerPackageUploaderApplication

This bug was fixed in the package winff - 1.4.2-3ubuntu1

---------------
winff (1.4.2-3ubuntu1) quantal; urgency=low

  * Fixed failure to find avconv instead of ffmpeg after the conversion
    of Ubuntu to libav (LP: #1058380)
 -- Paul Gevers <email address hidden> Sat, 29 Sep 2012 13:15:54 +0200