PositionChanged signal arguments are in the wrong order

Bug #1067037 reported by Stefan Schmidt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu GeoIP
Fix Released
Low
Unassigned
ubuntu-geoip (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

[I tried to generate a patch with commit message and such form my local bzr commit but I failed. Thus I'm putting this here. Should be easy enough to pick it up and commit it on your side.]

--- Commit message ---
  Fix the argument ordering of the position signal.

  Signals are supposed to be emitted with the same argument ordering as the reply
  of the method call. Fields comes before the timestamp here. This is the way the
  geoclue dbus spec describes it and the other provider implementing it.

  Be aware that it my break applications that have been developed for the Ubuntu
  provider only and are listening for position signals.

  Signed-off-by: Stefan Schmidt <email address hidden>
------

Without this patch the timestamp gets used for the fields and surprising results are the outcome. The attched patch fixes this issue for me.

Tags: patch

Related branches

Revision history for this message
Stefan Schmidt (stefan-datenfreihafen) wrote :
Revision history for this message
Stefan Schmidt (stefan-datenfreihafen) wrote :

Any comments on the patch?

Revision history for this message
Stefan Schmidt (stefan-datenfreihafen) wrote :

Is anyone actually looking at this reports?

Its two months since I reported this problem and also supplied a patch to fix it.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-geoip at revision 33, scheduled for release in ubuntu-geoip, milestone 1.0.0

Changed in ubuntu-geoip:
status: New → Fix Committed
Revision history for this message
Ted Gould (ted) wrote :

Thanks for the patch! I had tried to debug the location stuff before and not figured out what the issue was, it only worked at certain times :-)

Changed in ubuntu-geoip (Ubuntu):
importance: Undecided → Low
Changed in ubuntu-geoip:
importance: Undecided → Low
Changed in ubuntu-geoip (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-geoip - 1.0.1-0ubuntu4

---------------
ubuntu-geoip (1.0.1-0ubuntu4) raring; urgency=low

  * Backport upstream commits:
    - Fix ordering of parameters (lp: #1067037)
    - support for proxies (lp: #1130097)
  * debian/control:
    - Build-depends on libsoup-gnome2.4-dev
 -- Sebastien Bacher <email address hidden> Fri, 15 Mar 2013 11:53:53 +0100

Changed in ubuntu-geoip (Ubuntu):
status: Fix Committed → Fix Released
Ted Gould (ted)
Changed in ubuntu-geoip:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.