[REGRESSION] release upgrader tool became untranslated

Bug #1072828 reported by Gabor Kelemen
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Ubuntu Translations
Fix Released
High
Gabor Kelemen
ubuntu-release-upgrader (Ubuntu)
Fix Released
High
Brian Murray
Quantal
Won't Fix
High
Unassigned

Bug Description

The release upgrader tool shows a lot of strings untranslated since it was split out from update-manager.

[Test Case]
1) If you do not use a language other than English install French
2) In a terminal run: sudo LANG=fr_FR.utf-8 python3 /usr/lib/python3/dist-packages/DistUpgrade/dist-upgrade.py --partial --frontend=DistUpgradeViewGtk3 --datadir=/usr/share/ubuntu-release-upgrader/
3) Observe that "Reading cache" is untranslated
4) In the terminal press Ctrl-C to stop the partial upgrade

With the version of the package from quantal-proposed "Reading cache" will be translated.

Tags: i18n

Related branches

Revision history for this message
Gabor Kelemen (kelemeng) wrote :
Revision history for this message
Gabor Kelemen (kelemeng) wrote :
Revision history for this message
Brian Murray (brian-murray) wrote :

To which release were you upgrading when you discovered this? Could you find the file DistUpgradeVersion.py in /tmp/ on the system you were updating and confirm the version number in it? It should look like 'VERSION='0.190.3'. Thanks in advance.

Changed in ubuntu-release-upgrader (Ubuntu):
status: New → Incomplete
importance: Undecided → High
Revision history for this message
Gabor Kelemen (kelemeng) wrote :

This was a Quantal, last updated two or three weeks ago and it had to run a dist-upgrade.

Revision history for this message
Brian Murray (brian-murray) wrote :

Well there was this change that should have fixed this, without knowing the specific version you were running it is hard to know whether or not it was fixed.

ubuntu-release-upgrader (1:0.188) quantal; urgency=low

  * ensure that translations are loaded (LP: #1058102)
  * update translations from Launchpad

 -- Brian Murray <email address hidden> Tue, 09 Oct 2012 09:07:12 -0700

I'll try and test this after UDS though.

Revision history for this message
Gabor Kelemen (kelemeng) wrote :

I have this version:

$ LANG=C dpkg -l ubuntu-release-upgrader-gtk
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==============-============-============-=================================
ii ubuntu-release 1:0.190.1 all manage release upgrades

Since:
$ ls -l /var/cache/apt/archives/ubuntu-release-upgrader-*
-rw-r--r-- 1 root root 24672 okt 4 04:33 /var/cache/apt/archives/ubuntu-release-upgrader-core_1%3a0.187_all.deb
-rw-r--r-- 1 root root 27812 okt 16 19:33 /var/cache/apt/archives/ubuntu-release-upgrader-core_1%3a0.190.1_all.deb
-rw-r--r-- 1 root root 10680 okt 4 04:33 /var/cache/apt/archives/ubuntu-release-upgrader-gtk_1%3a0.187_all.deb
-rw-r--r-- 1 root root 11022 okt 16 19:33 /var/cache/apt/archives/ubuntu-release-upgrader-gtk_1%3a0.190.1_all.deb

Revision history for this message
Brian Murray (brian-murray) wrote :

Oh, actually /var/log/dist-upgrade/main.log will include this line in it:

2012-06-20 08:57:48,795 INFO release-upgrader version '0.163' started

and that will tell us which version of the release-upgrader you used to upgrade to quantal.

Revision history for this message
Gabor Kelemen (kelemeng) wrote :

Hi Brian

This was not an upgrade to quantal, but a dist-upgrade of quantal, because of a package had to be removed. Sorry if this was not obvious.
The file you mention was last touched in august:

-rw-r--r-- 1 root root 71017 aug 16 22:01 /var/log/dist-upgrade/main.log

so this won't help us. I have found in /var/log/dist-upgrade/apt.log the following:

Log time: 2012-10-29 15:04:40.963227
Starting
Starting 2
Investigating (0) gir1.2-epiphany-3.4 [ i386 ] < 3.5.4-0ubuntu2 > ( introspection )
Broken gir1.2-epiphany-3.4:i386 Függ ettől on epiphany-browser [ i386 ] < 3.5.4-0ubuntu2 -> 3.6.0-0ubuntu1 > ( universe/gnome ) (= 3.5.4-0ubuntu2)
  Considering epiphany-browser:i386 8 as a solution to gir1.2-epiphany-3.4:i386 -1
  Removing gir1.2-epiphany-3.4:i386 rather than change epiphany-browser:i386

I think this is why update-manager could not run a normal system update and asked me to run a dist-upgrade, which showed me the above screens.
Unfortunately I have no idea how to find a package that would break dependencies in a way that would result in a reproducible dist-upgrade.

Revision history for this message
Gabor Kelemen (kelemeng) wrote :

It took a little time to figure out how to bring up the window manually, but here it is, to reproduce, run:

sudo python3 /usr/lib/python3/dist-packages/DistUpgrade/dist-upgrade.py --partial --frontend=DistUpgradeViewGtk3 --datadir=/usr/share/ubuntu-release-upgrader/

on Quantal. The attached screen, or something similar should show up, if there are packages to upgrade.

Revision history for this message
Gabor Kelemen (kelemeng) wrote :

This happens because of the fix of the above mentioned bug was not perfect:
http://bazaar.launchpad.net/~ubuntu-core-dev/ubuntu-release-upgrader/trunk/revision/2574#DistUpgrade/DistUpgradeMain.py

Here we can see that the gettext.bindtextdomain and gettext.textdomain calls are inside of the 'if' branch.
This is wrong, these should be called anyways, and only the localedir should depend on the datadir option (I have a gut feeling that the current working directory + mo isn't good either - ./setup.py build_i18n puts the mo files into build/mo. But this is offtopic here, and didn't tested it much.).

I'll propose a branch, which results in this nicely localized screen. Also bug 1059641 is solved by it too, as those strings are coming from the same file as these - but they disappeared too quickly and I couldn't make a screenshot. So I'll just mark that bug as a duplicate.

Changed in ubuntu-release-upgrader (Ubuntu):
status: Incomplete → New
Changed in ubuntu-translations:
assignee: nobody → Gabor Kelemen (kelemeng)
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu-release-upgrader (Ubuntu):
status: New → Confirmed
Revision history for this message
Brian Murray (brian-murray) wrote :

Using the current working directory + mo is necessary for release upgrades as ubuntu-release-upgrader is downloaded as dist-upgrader to your /tmp/ folder and includes translations for the new version of it.

description: updated
description: updated
Changed in ubuntu-release-upgrader (Ubuntu Quantal):
status: New → Triaged
importance: Undecided → High
Changed in ubuntu-release-upgrader (Ubuntu):
status: Confirmed → Triaged
Changed in ubuntu-release-upgrader (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Brian Murray (brian-murray)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:0.192.4

---------------
ubuntu-release-upgrader (1:0.192.4) raring; urgency=low

  * Ensure that partial upgrades are fully translated (LP: #1072828) thanks to
    Gabor Kelemen for the initial patch.
  * Remove code enabling apport since it is always running (LP: #1068874)
  * check-new-release-gtk: set the correct translation domain thanks to Gabor
    Kelemen for patch (LP: #1093697)
  * DistUpgradeController.py: call apport-bug with the binary package name not
    the source package name (LP: #1098001)
  * source_ubuntu-release-upgrader.py: set the crash database to Ubuntu to
    allow reporting of bugs even if the package does not seem to be official
    (LP: #1067542)
 -- Brian Murray <email address hidden> Fri, 11 Jan 2013 16:19:26 -0800

Changed in ubuntu-release-upgrader (Ubuntu):
status: In Progress → Fix Released
Gabor Kelemen (kelemeng)
Changed in ubuntu-translations:
status: Triaged → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

quantal has seen the end of its life and is no longer receiving any updates. Marking the quantal task for this ticket as "Won't Fix".

Changed in ubuntu-release-upgrader (Ubuntu Quantal):
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.