Ubuntu
dee package

Dee.SharedModel doesn't get invalidated when the leader changes

Bug #1076027 reported by Ken VanDine
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dee
Fix Released
Medium
Michal Hruby
dee 1.0.16
dee (Ubuntu)
Fix Released
Medium
Ken VanDine
Quantal
Fix Released
Low
Timo Jyrinki

Bug Description

[Impact]

A bug found when working on "friends" feature for 13.04 may be causing bugs in a stable release as well, thus worth updating. A SharedModel should get invalidated if a transaction from leader would be ignored.

[Test case]

Not easily testable in 12.10, other than no regressions in dee functionality and automated tests continue to pass.

[Regression potential]

Low, self-invalidation is only done when sender_name is NULL or not the leader.

See original description

Related branches

lp:ubuntu/raring-proposed/dee
lp:~timo-jyrinki/dee/dee-quantal
lp:~mhr3/dee/fix-1076027
Paweł Stołowski (community): Approve
PS Jenkins bot: Pending (continuous-integration) requested
Diff: 302 lines (+206/-5)
5 files modified
src/dee-shared-model.c (+11/-0)
tests/Makefile.am (+4/-0)
tests/model-helper-resync3rows.c (+108/-0)
tests/peer-helper-1peer.c (+6/-2)
tests/test-model-interactions.c (+77/-3)
lp:ubuntu/quantal-proposed/dee
Ken VanDine (ken-vandine)
Changed in dee (Ubuntu Quantal):
importance: Undecided → Low
Changed in dee (Ubuntu):
importance: Undecided → Medium
assignee: nobody → Ken VanDine (ken-vandine)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dee - 1.0.14-0ubuntu2

---------------
dee (1.0.14-0ubuntu2) raring; urgency=low

  * src/dee-shared-model.c
    - invalidate model when a transaction from the leader would be
      ignored (LP: #1076027)
 -- Ken VanDine <email address hidden> Wed, 07 Nov 2012 11:22:38 -0500

Changed in dee (Ubuntu):
status: New → Fix Released
Timo Jyrinki (timo-jyrinki)
Changed in dee (Ubuntu Quantal):
assignee: nobody → Timo Jyrinki (timo-jyrinki)
status: New → In Progress
Timo Jyrinki (timo-jyrinki)
description: updated
description: updated
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Steps to verify: There is nothing in quantal that we know to be affected by this bug, but there is a chance the lenses or scopes might be affected. It wouldn't be all that noticeable.

There shouldn't be any potential for regression, the fix is to invalidate the model if it will no longer get updates from the leader, which makes it re-sync.

Michal Hruby (mhr3)
Changed in dee:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Michal Hruby (mhr3)
milestone: none → 1.0.16
PS Jenkins bot (ps-jenkins)
Changed in dee:
status: In Progress → Fix Committed
Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Hello Ken, or anyone else affected,

Accepted dee into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/dee/1.0.14-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in dee (Ubuntu Quantal):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

No issues noticed.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dee - 1.0.14-0ubuntu1.1

---------------
dee (1.0.14-0ubuntu1.1) quantal-proposed; urgency=low

  [ Ken VanDine ]
  * src/dee-shared-model.c
    - invalidate model when a transaction from the leader would be
      ignored (LP: #1076027)
 -- Timo Jyrinki <email address hidden> Thu, 08 Nov 2012 08:12:08 +0200

Changed in dee (Ubuntu Quantal):
status: Fix Committed → Fix Released
Michal Hruby (mhr3)
Changed in dee:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.