lxsession segfault if desktop environment not specified

Bug #1091819 reported by Paul Donohue
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
lxsession (Ubuntu)
Fix Released
Undecided
Julien Lavergne

Bug Description

lxsession in Quantal and Raring crashes if it is run without the '-e' option to specify the desktop environment:

lxsession[24319]: segfault at 0 ip 00007fac984db6d6 sp 00007fffe89a3f38 error 4 in libc-2.15.so[7fac9839e000+1b5000]

(gdb) where
#0 __strcmp_ssse3 () at ../sysdeps/x86_64/multiarch/../strcmp.S:213
#1 0x000000000041cba9 in launch_autostart_file (kf=0x26c8ca0, desktop_id=<optimized out>,
desktop_file=<optimized out>) at ../xdg-autostart/xdg-autostart.c:198
#2 launch_autostart_file (desktop_id=<optimized out>, desktop_file=<optimized out>, kf=0x26c8ca0)
at ../xdg-autostart/xdg-autostart.c:178
#3 0x00007f2396a50090 in g_hash_table_foreach () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4 0x000000000041cd68 in xdg_autostart (de_name_arg=0x0) at ../xdg-autostart/xdg-autostart.c:309
#5 0x00000000004074ed in lxsession_main_main (args=0x7fffb3173ca8, args_length1=1) at main.c:991
#6 0x00007f239645d76d in __libc_start_main (main=0x406a00 <main>, argc=3, ubp_av=0x7fffb3173ca8,
init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>,
stack_end=0x7fffb3173c98) at libc-start.c:226
#7 0x0000000000406a49 in _start ()

This happens because main.vala only prints a warning if desktop_environnement is null - it does not actually fall back to "LXDE" like the warning message says it will. The attached patch fixes the problem.

Tags: patch

Related branches

Revision history for this message
Paul Donohue (s-launchpad-paulsd-com) wrote :
Revision history for this message
Paul Donohue (s-launchpad-paulsd-com) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Julien Lavergne (gilir)
Changed in lxsession (Ubuntu):
status: New → In Progress
assignee: nobody → Julien Lavergne (gilir)
Revision history for this message
Julien Lavergne (gilir) wrote :

Applied upstream, will be part of the next upload of lxsession

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxsession - 0.4.9.2~git20121227-0ubuntu1

---------------
lxsession (0.4.9.2~git20121227-0ubuntu1) raring; urgency=low

  * New upstream snapshot.
   - Use lighdm dbus method to switch user. (LP: #953554)
   - lxsession segfault if desktop environment not specified (LP: #1091819)
   - Add a lock screen option for Lubuntu (LP: #612332)
 -- Julien Lavergne <email address hidden> Thu, 07 Mar 2013 16:42:43 +0100

Changed in lxsession (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.