the dock doesn't hide when a Downloading windows overlaps

Bug #1094825 reported by londumas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cairo-Dock Core
Fix Released
Medium
Matthieu Baerts
cairo-dock (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Hello, great app.
Here the bugs I have.

-> When I download something from the web or from something else, a window appers asking for the path. My dock is set to autohide when a window overlaps and it does. But with downloading windows it doesn't. It is getting annoying.
-> When I dismount a usb stick, the dock diseapered for few secounds. It is annoying also.

Cairo-dock version : 3.1.99.alpha0 with openGL
Ubuntu version : Quantal, 64 bits
I am not using the Cairo-dock session

Thank for your work

Related branches

Revision history for this message
londumas (helion331990) wrote :
Revision history for this message
Matthieu Baerts (matttbe) wrote :

Hello and thank you for this bug report!

> -> When I download something from the web or from something else, a window appers asking for the path. My dock is set to autohide when a window overlaps and it does. But with downloading windows it doesn't. It is getting annoying.

I confirm this bug. And it should be fixed now on BZR ;)
https://bazaar.launchpad.net/~cairo-dock-team/cairo-dock-core/cairo-dock/revision/1313

Feel free to confirm if this bug is fixed (or not)! Our 'weekly' ppa will be updated in a few hours.

> -> When I dismount a usb stick, the dock diseapered for few secounds. It is annoying also.
This should be fixed too but I didn't check. Feel free to open a new bug report if you still have the bug with the new version ;)

description: updated
Changed in cairo-dock-core:
status: New → Fix Committed
assignee: nobody → Matthieu Baerts (matttbe)
milestone: none → 3.1.99.alpha
importance: Undecided → Medium
Revision history for this message
Fabounet (fabounet03) wrote : Re: [Cairo-dock-team] [Bug 1094825] Re: the dock doesn't hide when a Downloading windows overlaps
Download full text (5.9 KiB)

about the other problem, it may be a bug in Shortcuts.
I've fixed a bug on it recently, can you confirm you have/haven't it with
the latest revision ?
Thanks !

2012/12/31 Matthieu Baerts <email address hidden>

> Hello and thank you for this bug report!
>
> > -> When I download something from the web or from something else, a
> window appers asking for the path. My dock is set to autohide when a
> window overlaps and it does. But with downloading windows it doesn't. It
> is getting annoying.
>
> I confirm this bug. And it should be fixed now on BZR ;)
>
> https://bazaar.launchpad.net/~cairo-dock-team/cairo-dock-core/cairo-dock/revision/1313
>
> Feel free to confirm if this bug is fixed (or not)! Our 'weekly' ppa
> will be updated in a few hours.
>
>
> > -> When I dismount a usb stick, the dock diseapered for few secounds. It
> is annoying also.
> This should be fixed too but I didn't check. Feel free to open a new bug
> report if you still have the bug with the new version ;)
>
> ** Attachment added: "cairo-dock_messages.out"
>
> https://bugs.launchpad.net/cairo-dock-core/+bug/1094825/+attachment/3471357/+files/cairo-dock_messages.out
>
> ** Description changed:
>
> Hello, great app.
> Here the bugs I have.
>
> -> When I download something from the web or from something else, a
> window appers asking for the path. My dock is set to autohide when a window
> overlaps and it does. But with downloading windows it doesn't. It is
> getting annoying.
> -> When I dismount a usb stick, the dock diseapered for few secounds. It
> is annoying also.
>
> Cairo-dock version : 3.1.99.alpha0 with openGL
> Ubuntu version : Quantal, 64 bits
> I am not using the Cairo-dock session
>
> - return of "cairo-dock":
> -
> (/build/buildd/cairo-dock-3.1.99.alpha0.1~20121230~bzr1312/src/gldit/cairo-dock-opengl.c:cairo_dock_initialize_opengl_backend:208)
> - couldn't find an appropriate visual, trying to get one without Stencil
> buffer
> - (it may cause some little deterioration in the rendering) ...
> -
> -
> ============================================================================
> - Cairo-Dock version : 3.1.99.alpha0
> - Compiled date : Dec 30 2012 11:57:30
> - Built with GTK : 3.6
> - Running with OpenGL: 1
> -
> ============================================================================
> -
> - Cairo-Dock - Launcher API Daemon is already running (2169)
> - IndicatorObject class does not have an accessible description.
> - CairoKeyBinding '<Control><Alt>m' failed!
> - warning :
> (/build/buildd/cairo-dock-3.1.99.alpha0.1~20121230~bzr1312/src/gldit/cairo-dock-keybinder.c:cd_keybinder_bind:282)
> - Couldn't bind '<Control><Alt>m' (Notification de messages:
> Afficher/cacher le menu des messages)
> - This shortkey is probably already used by another applet or another
> application
> - CairoKeyBinding '<Super>L' failed!
> - warning :
> (/build/buildd/cairo-dock-3.1.99.alpha0.1~20121230~bzr1312/src/gldit/cairo-dock-keybinder.c:cd_keybinder_bind:282)
> - Couldn't bind '<Super>L' (Se déconnecter: Verrouiller l'écran)
> - This shortkey is probably already used by another applet or another
> application
> - CairoK...

Read more...

Revision history for this message
Matthieu Baerts (matttbe) wrote :

@fabounet: you're faster than me for the commit 1314 :þ
(I just fixed another bug introduced with my previous commit, should be ok now ;) )

Revision history for this message
Fabounet (fabounet03) wrote :

yep I'm quite happy with this one :D

2012/12/31 Matthieu Baerts <email address hidden>

> @fabounet: you're faster than me for the commit 1314 :þ
> (I just fixed another bug introduced with my previous commit, should be ok
> now ;) )
>
> --
> You received this bug notification because you are a member of Cairo-
> Dock Devs, which is subscribed to Cairo-Dock Core.
> https://bugs.launchpad.net/bugs/1094825
>
> Title:
> the dock doesn't hide when a Downloading windows overlaps
>
> Status in Cairo-Dock : Core:
> Fix Committed
>
> Bug description:
> Hello, great app.
> Here the bugs I have.
>
> -> When I download something from the web or from something else, a
> window appers asking for the path. My dock is set to autohide when a window
> overlaps and it does. But with downloading windows it doesn't. It is
> getting annoying.
> -> When I dismount a usb stick, the dock diseapered for few secounds. It
> is annoying also.
>
> Cairo-dock version : 3.1.99.alpha0 with openGL
> Ubuntu version : Quantal, 64 bits
> I am not using the Cairo-dock session
>
> Thank for your work
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/cairo-dock-core/+bug/1094825/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~cairo-dock-team
> More help : https://help.launchpad.net/ListHelp
>

Revision history for this message
londumas (helion331990) wrote :

So I just update to the last compiled cairo-dock package and the bug about overlaping downloading windows is still there.
I tried on the cairo-dock session and it is the same.
However, the usb bug is fixed.

Any confirmation of the bug ?

here is my version.

 ============================================================================
 Cairo-Dock version : 3.1.99.alpha0
 Compiled date : Dec 31 2012 15:45:08
 Built with GTK : 3.6
 Running with OpenGL: 1
 ============================================================================

Thank you guys for your work

Revision history for this message
Matthieu Baerts (matttbe) wrote :

> So I just update to the last compiled cairo-dock package and the bug about overlaping downloading windows is still there.

Ok, I think this bug is only fixed for when you choose to hide the dock when the *active* window overlaps.
So it's not fully fixed yet :)

Changed in cairo-dock-core:
status: Fix Committed → In Progress
Revision history for this message
londumas (helion331990) wrote :

Yes I just ckecked and this is true.
So I agree it is a bug since the option says "hide when a window overlaps" (translation from French).

Thank for your answer.

Revision history for this message
Matthieu Baerts (matttbe) wrote :

@fabounet: the problem is that this kind of windows are not tracked by the dock except if this window is active.
What can we do? We can hide it if this window is active:

========
=== modified file 'src/gldit/cairo-dock-applications-manager.c'
--- src/gldit/cairo-dock-applications-manager.c 2013-01-01 14:01:06 +0000
+++ src/gldit/cairo-dock-applications-manager.c 2013-01-01 14:43:06 +0000
@@ -210,8 +210,10 @@

 static void _hide_show_if_on_our_way (CairoDock *pDock, Icon *icon)
 {
- if (pDock->iVisibility != CAIRO_DOCK_VISI_AUTO_HIDE_ON_OVERLAP && ! myDocksParam.bAutoHideOnFullScreen)
- return ;
+ if (pDock->iVisibility != CAIRO_DOCK_VISI_AUTO_HIDE_ON_OVERLAP
+ && pDock->iVisibility != CAIRO_DOCK_VISI_AUTO_HIDE_ON_OVERLAP_ANY
+ && ! myDocksParam.bAutoHideOnFullScreen)
+ return;

  // maybe we have a window without icon in the dock...
  GtkAllocation *pWindowGeometry;
@@ -226,6 +228,9 @@
  else
   pWindowGeometry = NULL;

+ if (pDock->iVisibility == CAIRO_DOCK_VISI_AUTO_HIDE_ON_OVERLAP_ANY && pWindowGeometry == NULL)
+ return; // windows without icons in the dock are not tracked except if it's active.
+
  /* hide the dock if the active window or its parent if this window doesn't
   * have any dedicated icon in the dock -> If my window's text editor is
   * maximised and then I open a 'Search' box, the dock should not appear
===========

but we need to check if this window has been closed:

Revision history for this message
Fabounet (fabounet03) wrote :

If the dock is set to hide when a window overlaps it, I think we can ignore
these dialog windows.
After all, they are dialogs of a parent window, and this one is probably
maximized, so it hides the dock.

It's the other case that causes trouble (dock hides on active window),
because popping the dialog window will make the parent window lose the
focus, so the dock will re-appear.

If this case is fixed, I think we're ok (and by the way, as another
solution, when a dialog window appears, we could also get the parent
window, and consider it didn't loose the focus).

2013/1/1 Matthieu Baerts <email address hidden>

> @fabounet: the problem is that this kind of windows are not tracked by the
> dock except if this window is active.
> What can we do? We can hide it if this window is active:
>

Changed in cairo-dock-core:
status: In Progress → Fix Committed
Revision history for this message
londumas (helion331990) wrote :

So I explaine again my problem,
When the parent window is maximized and the downloading window appears, the dock doesn't appear.
When the parent window is not maximized and doesn't overlap the dock and the downloading window appears and overlaps the dock, the dock doesn't hide.

I desagree to say that this is not a bug, since I work sometime with two maximized windows on the same screen. Also the option in the configuration dock says : "hide when a window overlaps", not "hide when a window overlaps except for downloading windows"

So I think it is a bug.

Thank you

Revision history for this message
Fabounet (fabounet03) wrote :

do you mean two non-maximized windows on the same screen ?

I can't disagree with you, there is a problem here (the dock doesn't track
such dialog windows because it doesn't represent them).
Now, we need to see the cost of fixing it compared to its annoyance.

2013/1/2 du Mas des Bourboux <email address hidden>

> maximized windows

Revision history for this message
londumas (helion331990) wrote :

Yes sorry. Two non-maximized windows.

Your right it is not a very important bug. It is just annoying. We can forget it if it is too hard or too expensive in memory to track downloading windows.

Thanks you

affects: ubuntu → cairo-dock (Ubuntu)
Changed in cairo-dock (Ubuntu):
status: New → Fix Committed
Changed in cairo-dock-core:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cairo-dock - 3.3.0-0ubuntu1

---------------
cairo-dock (3.3.0-0ubuntu1) saucy; urgency=low

  * New upstream release.
  * Detailed Upstream ChangeLog (beta 2 -> release)
    - Desklets: when something is dropped onto a desklet, get the data and
      not only the text
    - Dialogs: fixed a bug that made the background of the widgets inside
      the dialog visible
    - Menus: split menus functions into separated files to prepare future
      menus and imported gtkimagemenuitem.c but only used with GTK 3.10
      Note: no changes for Saucy (with GTK 3.8)
    - src: remove some g_print's
    - po: imported translations from Launchpad
  * A few bugs have been fixed:
    - Invalid fastbin entry LP: #1212981
    - Cairo-Dock Session is broken with Gnome-Session 3.8 LP: #1193598
    - Dock doesn't hide when a Downloading windows overlaps LP: #1094825
    - Thumbnails of windows not showing when minimized LP: #1051174
    - Icon label persists after hover away LP: #1108611
    - Insecure RPATH in libgldi.so LP: #1170229
    - Dock becames visible although it should be hidden LP: #1218360
  * debian/control: bumped plug-ins versions
 -- Matthieu Baerts (matttbe) <email address hidden> Fri, 04 Oct 2013 14:58:22 +0200

Changed in cairo-dock (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.