container startup must not fail if setup_kmsg fails

Bug #1097312 reported by Serge Hallyn
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lxc (Ubuntu)
Fix Released
Undecided
Unassigned
Quantal
Fix Released
Medium
Unassigned

Bug Description

setup_kmsg is a convenience to have container syslog messages (generated by userspace) directed at the console. However it fails the container must not fail to start.

========================
SRU Justification
Impact: certain containers will fail to start
Development fix: if /dev/kmsg could not be set up, don't fail container startup
Stable fix: same as development fix
Test case:
 sudo lxc-create -t sshd -n ssh1
 sudo lxc-start -n ssh1
Regression potential: containers can run fine without setup_kmsg() having run, so allowing container startup to proceed when setup_kmsg() fails should introduce no regression.
========================

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

(medium priority because this does not affect most regular lxc usage)

Changed in lxc (Ubuntu):
status: New → Fix Released
Changed in lxc (Ubuntu Quantal):
status: New → Triaged
importance: Undecided → Medium
description: updated
Changed in lxc (Ubuntu Quantal):
status: Triaged → In Progress
Revision history for this message
Brian Murray (brian-murray) wrote :

To be clear this was fixed in raring with:

lxc (0.8.0~rc1-4ubuntu45) raring; urgency=low

  [ Stéphane Graber ]
  * Allow the container to mount efivars on /sys/firmware/efi/efivars.
    efivars is automatically mounted by mountall on UEFI systems, failure to
    do so leads to a complete boot failured.
  * Allow mounts and pivot_roots under /usr/lib/lxc/root/ for compatibility
    with nested precise lxc hosts (quantal -> precise -> containers).

  [ Serge Hallyn ]
  * update 0227-ubuntu-cloud-parsing to catch a doc typo stgraber had found
    in the upstream review.
  * 0228-ignore-kmsg-setup-failure: ignore failure to set up kmsg, since that
    is not critical.

  [ Christian Kampka ]
  * Have upstart run lxc instances (LP: #1049908)

 -- Serge Hallyn <email address hidden> Tue, 27 Nov 2012 22:52:10 -0600

Changed in lxc (Ubuntu Quantal):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Serge, or anyone else affected,

Accepted lxc into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lxc/0.8.0~rc1-4ubuntu39.12.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

verified on quantal.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxc - 0.8.0~rc1-4ubuntu39.12.10.1

---------------
lxc (0.8.0~rc1-4ubuntu39.12.10.1) quantal-proposed; urgency=low

  * 0228-ignore-kmsg-setup-failure: ignore failure to set up kmsg, since that
    is not critical. (LP: #1097312)
 -- Serge Hallyn <email address hidden> Tue, 08 Jan 2013 10:25:43 -0600

Changed in lxc (Ubuntu Quantal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.