Ubuntu
iscsitarget package

iscsitarget-dkms FTBFS with 12.04.2 3.5 kernel

Bug #1117093 reported by James Page
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
iscsitarget (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Critical
Unassigned
Ubuntu ubuntu-12.04.2

Bug Description

[Impact]
iscsitarget dkms module fails to build with 3.5 kernel as proposed for 12.04.2.

[Test Case]
Install Ubuntu 12.04.2
sudo apt-get install iscsitarget-dkms
Fails to build

[Regression Potential]
DKMS module has to support 3.5 and 3.2 kernels; this is done using DKMS patches which are applied when building for 3.2.

This has been tested but is probably when problems may occur.

[Original Bug Report]

The iscsitarget dkms package fails to build with the new 3.5 kernel for 12.04.2:

DKMS make.log for iscsitarget-1.4.20.2 for kernel 3.5.0-23-generic (x86_64)
Tue Feb 5 17:39:10 GMT 2013
make: Entering directory `/usr/src/linux-headers-3.5.0-23-generic'
  LD /var/lib/dkms/iscsitarget/1.4.20.2/build/built-in.o
  LD /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/built-in.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/tio.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/iscsi.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/nthread.o
/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/nthread.c: In function ‘do_recv’:
/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/nthread.c:145:1: warning: the frame size of 1104 bytes is larger than 1024 bytes [-Wframe-larger-than=]
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/wthread.o
/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/wthread.c: In function ‘worker_thread’:
/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/wthread.c:76:3: error: implicit declaration of function ‘get_io_context’ [-Werror=implicit-function-declaration]
/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/wthread.c:76:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
make[2]: *** [/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/wthread.o] Error 1
make[1]: *** [/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel] Error 2
make: *** [_module_/var/lib/dkms/iscsitarget/1.4.20.2/build] Error 2
make: Leaving directory `/usr/src/linux-headers-3.5.0-23-generic'

Quantal package includes relevant fixes:

  * Fix DKMS compatibility with Linux 3.5 kernel (LP: #1045706):
    - d/p/iscsitarget-svn{444,471}.patch: Cherry picked patches from
      upstream VCS trunk, resolving dkms build failures with > linux 3.5.
    - d/p/fix-linux3.5.patch: Rework usage of ioc_task_link, resolving
      dkms build failures with > linux 3.5.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: iscsitarget-dkms 1.4.20.2-5ubuntu3.1
ProcVersionSignature: Ubuntu 3.5.0-23.35~precise1-generic 3.5.7.2
Uname: Linux 3.5.0-23-generic x86_64
ApportVersion: 2.0.1-0ubuntu17.1
Architecture: amd64
Date: Wed Feb 6 08:26:50 2013
InstallationMedia: Ubuntu-Server 12.04.2 LTS "Precise Pangolin" - Release amd64 (20130205)
MarkForUpload: True
PackageArchitecture: all
SourcePackage: iscsitarget
UpgradeStatus: No upgrade log present (probably fresh install)

See original description
Revision history for this message
James Page (james-page) wrote :
Changed in iscsitarget (Ubuntu):
status: New → Fix Released
Changed in iscsitarget (Ubuntu Precise):
status: New → Triaged
importance: Undecided → Critical
milestone: none → ubuntu-12.04.2
James Page (james-page)
description: updated
Revision history for this message
Colin Watson (cjwatson) wrote : Please test proposed package

Hello James, or anyone else affected,

Accepted iscsitarget into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/iscsitarget/1.4.20.2-5ubuntu3.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in iscsitarget (Ubuntu Precise):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
James Page (james-page) wrote :

DKMS module from proposed builds fine on 12.03.2 with 3.5 kernel

tags: added: verification-done
removed: verification-needed
Revision history for this message
Colin Watson (cjwatson) wrote :

This was a bit late to be on .2 images, but should be in -updates immediately after .2 releases and will be in .3.

Changed in iscsitarget (Ubuntu Precise):
milestone: ubuntu-12.04.2 → ubuntu-12.04.3
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Changed in iscsitarget (Ubuntu Precise):
milestone: ubuntu-12.04.3 → ubuntu-12.04.2
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package iscsitarget - 1.4.20.2-5ubuntu3.2

---------------
iscsitarget (1.4.20.2-5ubuntu3.2) precise-proposed; urgency=low

   * Fix DKMS compatibility with Linux 3.5 kernel (LP: #1117093):
    - d/p/iscsitarget-svn{444,471,485}.patch: Cherry picked patches from
      upstream VCS trunk, resolving dkms build failures with > Linux 3.5.
    - d/p/fix-dkms.patch: Fixup DKMS patching for the above fixes to ensure
      that dkms build is backwards compatible with Linux 3.2.
 -- James Page <email address hidden> Wed, 06 Feb 2013 11:32:56 +0000

Changed in iscsitarget (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.