Ubuntu
iscsitarget package

iscsitarget-dkms FTBFS with raring 3.8 kernel

Bug #1117288 reported by James Page on 2013-02-06

This bug affects 1 person

	Status	Importance	Assigned to
iscsitarget (Ubuntu)	Fix Released	High	James Page
Precise	Fix Released	High	James Page
Raring	Fix Released	High	James Page

Bug Description

SRU Information
===============

[Impact]

Users of the Raring LTS kernels (3.8) on Ubuntu 12.04 will not be able to use iscsitarget as the DKMS module fails to build against linux 3.8.

[Test Case]
sudo apt-get install linux-image-generic-lts-raring linux-headers-generic-lts-raring
sudo apt-get install iscsitarget-dkms
DKMS module build will fail.

[Regression Potential]
Limited; the proposed fix is a backport of the patches that where applied to this package during the 13.04 cycle. However the updates dkms package should be tested with 3.2 and 3.5 kernels as well.

Original bug report
===================

DKMS make.log for iscsitarget-1.4.20.2 for kernel 3.8.0-2-generic (x86_64)
Wed Feb 6 12:33:28 GMT 2013
make: Entering directory `/usr/src/linux-headers-3.8.0-2-generic'
  LD /var/lib/dkms/iscsitarget/1.4.20.2/build/built-in.o
  LD /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/built-in.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/tio.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/iscsi.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/nthread.o
/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/nthread.c: In function ‘do_recv’:
/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/nthread.c:145:1: warning: the frame size of 1096 bytes is larger than 1024 bytes [-Wframe-larger-than=]
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/wthread.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/config.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/digest.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/conn.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/session.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/target.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/volume.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/iotype.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/file-io.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/null-io.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/target_disk.o
  CC [M] /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/event.o
/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/event.c: In function ‘event_recv_skb’:
/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/event.c:30:29: error: ‘struct netlink_skb_parms’ has no member named ‘pid’
/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/event.c: In function ‘event_init’:
/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/event.c:73:8: warning: passing argument 3 of ‘netlink_kernel_create’ makes pointer from integer without a cast [enabled by default]
In file included from /usr/src/linux-headers-3.8.0-2-generic/include/uapi/linux/neighbour.h:5:0,
                 from include/linux/netdevice.h:51,
                 from include/net/sock.h:51,
                 from include/linux/tcp.h:23,
                 from include/net/tcp.h:24,
                 from /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/event.c:9:
include/linux/netlink.h:48:1: note: expected ‘struct netlink_kernel_cfg *’ but argument is of type ‘int’
/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/event.c:73:8: error: too many arguments to function ‘netlink_kernel_create’
In file included from /usr/src/linux-headers-3.8.0-2-generic/include/uapi/linux/neighbour.h:5:0,
                 from include/linux/netdevice.h:51,
                 from include/net/sock.h:51,
                 from include/linux/tcp.h:23,
                 from include/net/tcp.h:24,
                 from /var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/event.c:9:
include/linux/netlink.h:48:1: note: declared here
make[2]: *** [/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel/event.o] Error 1
make[1]: *** [/var/lib/dkms/iscsitarget/1.4.20.2/build/kernel] Error 2
make: *** [_module_/var/lib/dkms/iscsitarget/1.4.20.2/build] Error 2
make: Leaving directory `/usr/src/linux-headers-3.8.0-2-generic'

ProblemType: Bug
DistroRelease: Ubuntu 13.04
Package: iscsitarget-dkms 1.4.20.2-10ubuntu1
ProcVersionSignature: Ubuntu 3.8.0-2.6-generic 3.8.0-rc4
Uname: Linux 3.8.0-2-generic x86_64
ApportVersion: 2.8-0ubuntu4
Architecture: amd64
Date: Wed Feb 6 12:27:05 2013
MarkForUpload: True
PackageArchitecture: all
SourcePackage: iscsitarget
UpgradeStatus: Upgraded to raring on 2013-01-07 (29 days ago)

See original description

Tags:

Revision history for this message

James Page (james-page) wrote on 2013-02-06:

Dependencies.txt Edit (1.3 KiB, text/plain; charset="utf-8")
ProcEnviron.txt Edit (313 bytes, text/plain; charset="utf-8")

Changed in iscsitarget (Ubuntu Raring):
importance:	Undecided → High
status:	New → Triaged

Revision history for this message

themylogin (themylogin) wrote on 2013-03-12:

compat-3.8.patch Edit (698 bytes, text/plain)

Fixes this problem for me

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2013-03-12:

The attachment "compat-3.8.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags:

added: patch

James Page (james-page) on 2013-03-12

Changed in iscsitarget (Ubuntu Raring):
assignee:	nobody → James Page (james-page)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-03-12:

This bug was fixed in the package iscsitarget - 1.4.20.2-10ubuntu2

---------------
iscsitarget (1.4.20.2-10ubuntu2) raring; urgency=low

  * Fix compatibility with Linux 3.8 kernel (LP: #1117288):
    - d/p/iscsitarget-svn486.patch: Cherry picked patch from upstream VCS
      which adds support for 3.6 kernel.
    - d/p/fix-dkms.conf: Refreshed for backward compat < 3.6,3.8 kernel.
    - d/p/kernel-3.8-compat.patch: Fix compatibility Linux 3.8 kernel.
-- James Page <email address hidden> Tue, 12 Mar 2013 10:13:09 +0000

Changed in iscsitarget (Ubuntu Raring):
status:	Triaged → Fix Released

James Page (james-page) on 2013-08-16

Changed in iscsitarget (Ubuntu Precise):
importance:	Undecided → High
assignee:	nobody → James Page (james-page)
status:	New → In Progress

James Page (james-page) on 2013-08-16

description:

updated

Revision history for this message

James Page (james-page) wrote on 2013-08-16:

Fix uploaded to precise-proposed for SRU team review.

James Page (james-page) on 2013-08-16

description:

updated

Revision history for this message

Dave Walker (davewalker) wrote on 2013-08-16: Please test proposed package

Hello James, or anyone else affected,

Accepted iscsitarget into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/iscsitarget/1.4.20.2-5ubuntu3.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in iscsitarget (Ubuntu Precise):
status:	In Progress → Fix Committed
tags:	added: verification-needed

Revision history for this message

Pim (pimlie) wrote on 2013-08-25:

Proposed package works for me:

# uname -a
Linux serv 3.8.0-29-generic #42~precise1-Ubuntu SMP Wed Aug 14 16:19:23 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux

# dpkg -s iscsitarget-dkms
Package: iscsitarget-dkms
Status: install ok installed
Priority: optional
Section: net
Installed-Size: 309
Maintainer: Ubuntu Developers <email address hidden>
Architecture: all
Source: iscsitarget
Version: 1.4.20.2-5ubuntu3.3

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-08-27:

This bug was fixed in the package iscsitarget - 1.4.20.2-5ubuntu3.3

---------------
iscsitarget (1.4.20.2-5ubuntu3.3) precise-proposed; urgency=low

Changed in iscsitarget (Ubuntu Precise):
status:	Fix Committed → Fix Released

Revision history for this message

Colin Watson (cjwatson) wrote on 2013-08-27: Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.