Remove reliance over global private browsing (being deprecated in FF)
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| WebApps: unity-firefox-extension |
Fix Committed
|
High
|
Alexandre Abreu | ||
| unity-firefox-extension (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Quantal |
Won't Fix
|
Undecided
|
Robert Bruce Park | ||
Bug Description
[Impact]
"nsIPrivateBrow
https:/
We should get rid of it ASAP. Reference FF bug for the IF removal: https:/
[Test Case]
Both tests should be performed:
* Test 1:
- Open Firefox 21 (or earlier but the bug should start manifesting itself more vividly w/ FF21),
- From within a simple normal tab, browse to an integrating website e.g. http://
- Accept any integration popup dialog request,
- A launcher icon should appear with some desktop notifications,
* Test 2:
- Open Firefox 21 (or earlier but the bug should start manifesting itself more vividly w/ FF21),
- Create a private browsing window (From the menu, File>Create Private Window), browse to an integrating website e.g. http://
- There should be no integration at all (launcher or notifications),
[Regression Potential]
None. The test covers the main use cases and the fix is pretty confined.
Related branches
- Maxim Ermilov (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 74 lines (+36/-3)3 files modifieddebian/changelog (+6/-0)
unity-firefox-extension/content/observer.js (+29/-2)
unity-firefox-extension/install.rdf (+1/-1)
- Alexandre Abreu (community): Approve
-
Diff: 82 lines (+35/-5)3 files modifieddebian/changelog (+5/-2)
unity-firefox-extension/content/observer.js (+29/-2)
unity-firefox-extension/install.rdf (+1/-1)
| description: | updated |
| description: | updated |
| Changed in unity-firefox-extension (Ubuntu Quantal): | |
| milestone: | none → quantal-updates |
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in unity-firefox-extension: | |
| status: | New → Fix Committed |
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in unity-firefox-extension (Ubuntu): | |
| status: | New → Fix Released |
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in unity-firefox-extension (Ubuntu Quantal): | |
| status: | New → Confirmed |
| Changed in unity-firefox-extension (Ubuntu Quantal): | |
| assignee: | nobody → Robert Bruce Park (robru) |
| Rolf Leggewie (r0lf) wrote | #4 |
| Changed in unity-firefox-extension (Ubuntu Quantal): | |
| status: | Confirmed → Won't Fix |
Fix committed into lp:unity-firefox-extension at revision 393, scheduled for release in unity-firefox-