fwts uefidump segfaults

Hi John, I think I have a fix for this in: ppa:colin-king/green ( https://launchpad.net/~colin-king/+archive/green ) - do you mind giving this a try to see if it fixes the bug?

Thanks.

I will give it a try tomorrow. Thanks

__
Sent from my smartphone

-------- Original message --------
From: Colin King <email address hidden>
Date: 05/01/2013 18:40 (GMT-05:00)
To: <email address hidden>
Subject: [Bug 1174947] Re: fwts uefidump segfaults

Hi John,  I think I have a fix for this in: ppa:colin-king/green  (
https://launchpad.net/~colin-king/+archive/green ) - do you mind giving
this a try to see if it fixes the bug?

Thanks.

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1174947

Title:
  fwts uefidump segfaults

Status in Firmware Test Suite:
  In Progress

Bug description:
  I can reliably reproduce a segfault with fwts from git when running
  'uefidump'. All other uefirt* tests run fine

  # fwts uefidump
  Running 1 tests, results appended to results.log
  Test: Dump UEFI variables.
  Segmentation fault (core dumped)                                                                                                                                                                                                   :   0.0% -
  # dmesg | grep segfault
  fwts[3137]: segfault at 7fff97006e18 ip 000000000042b895 sp 00007fff97006e20 error 6 in fwts[400000+5c000]
  fwts[31089]: segfault at 7fffd16e9e98 ip 00000038c16442ea sp 00007fffd16e9ea0 error 6 in libc-2.12.so[38c1600000+18a000]
  fwts[13304]: segfault at 7fff253e5ff8 ip 00000038c16748d9 sp 00007fff253e6000 error 6 in libc-2.12.so[38c1600000+18a000]
  fwts[13640]: segfault at 7fff9877bfe0 ip 00000038c166f930 sp 00007fff9877c008 error 6 in libc-2.12.so[38c1600000+18a000]
  fwts[13657]: segfault at 7fff1d89d948 ip 000000000042bc35 sp 00007fff1d89d950 error 6 in fwts[400000+5f000]
  fwts[13789]: segfault at 7fff2ef80fe8 ip 00000038c16442ea sp 00007fff2ef80ff0 error 6 in libc-2.12.so[38c1600000+18a000]
  fwts[14235]: segfault at 7fffaeca3838 ip 000000000042bc35 sp 00007fffaeca3840 error 6 in fwts[400000+5f000]
  fwts[26600]: segfault at 7fff0ca14f98 ip 00000038c16442ea sp 00007fff0ca14fa0 error 6 in libc-2.12.so[38c1600000+18a000]
  fwts[10660]: segfault at 7fff7ce9efdc ip 00000038c1644283 sp 00007fff7ce9ee40 error 6 in libc-2.12.so[38c1600000+18a000]

  I am attaching results.log (though i removed the hostname of the
  machine in question for security). In it you can see it always
  segfaults after reporting

  Name: ConInModify.
    GUID: B14FD152-F5E5-478F-BC43-1EED79B60FAB
    Attr: 0x7 (NonVolatile,BootServ,RunTime).

  Not sure if that is related. I have seen this on two versions of ftws:

  I pulled down from git today though this is what is reported in results.log:
  V0.26.08 (04/09/2013 13:30:06).

  Originally I was using a tarball I made from git on 2013-02-21 around the time of a commit that began with df83ea3. It had this version in results.log:
   Version V0.26.05 (四 2月 7 09:14:47 CST 2013).

  I am also attaching gdb bt output from the core generated. I'm not
  sure if it's useful as gdb complained it was missing debuginfo for
  libfwtsacpica.so.1, libfwts.so.1 and libfwtsiasl.so.1

  I tried modifying the CC flags to 'gcc -g -O' but it didn'...

..or apply the attached patch and spin your own

Thanks for the quick fix Colin. Thanks also for the patch as I don't use ppa often. It worked!

# fwts uefidump
Running 1 tests, results appended to results.log
Test: Dump UEFI variables.
  Dump UEFI Variables.

Fix committed eddf602b62843cef886fb053997b5d5f6b0ca26a

Fixed released in V13.06.00.