Ubuntu
open-vm-tools package

open-vm-dkms 2012.12.26-958366-0ubuntu3: open-vm-tools kernel module failed to build

Bug #1175295 reported by Fabio Marconi
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
VMWare tools
Unknown
Unknown
open-vm-tools (Ubuntu)
Fix Released
Undecided
Nate Muench (Mink)

Bug Description

Release of Ubuntu:13.10
Package Version:
Expected Results:
Actual Results:

Hallo
This popup at the startup of the session, system works.

Thanks
Fabio

ProblemType: Package
DistroRelease: Ubuntu 13.10
Package: open-vm-dkms 2012.12.26-958366-0ubuntu3
ProcVersionSignature: Ubuntu 3.9.0-0.3-generic 3.9.0
Uname: Linux 3.9.0-0-generic x86_64
ApportVersion: 2.10-0ubuntu1
Architecture: amd64
DKMSKernelVersion: 3.9.0-0-generic
Date: Wed May 1 20:17:21 2013
InstallationDate: Installed on 2012-10-12 (201 days ago)
InstallationMedia: Ubuntu 12.04.1 LTS "Precise Pangolin" - Release amd64 (20121011)
MarkForUpload: True
PackageArchitecture: all
PackageVersion: 2012.12.26-958366-0ubuntu3
SourcePackage: open-vm-tools
Title: open-vm-dkms 2012.12.26-958366-0ubuntu3: open-vm-tools kernel module failed to build
UpgradeStatus: Upgraded to saucy on 2013-05-01 (0 days ago)

Related branches

lp:~n-muench/ubuntu/saucy/open-vm-tools/open-vm-tools.april-update (Merged)
lp:~n-muench/ubuntu/saucy/open-vm-tools/open-vm-tools.fix-1175295
Nate Muench (Mink) (community): Needs Information
Luke Yelavich (community): Needs Fixing
Diff: 95040 lines (+37843/-42257)
262 files modified
.pc/0002-dkms.patch/modules/linux/dkms.conf (+39/-0)
.pc/0002-procps.patch/configure (+0/-25491)
.pc/0002-procps.patch/configure.ac (+0/-1234)
.pc/0003-dkms-vmsync.patch/modules/linux/dkms.conf (+39/-0)
.pc/0003-dkms.patch/modules/linux/dkms.conf (+0/-39)
.pc/0004-dkms-vmsync.patch/modules/linux/dkms.conf (+0/-39)
.pc/0004-vsock-cve.patch/modules/linux/vsock/linux/af_vsock.c (+5444/-0)
.pc/0005-kernel-38-fixes.patch/modules/linux/shared/compat_mm.h (+0/-107)
.pc/0005-kernel-38-fixes.patch/modules/linux/vmci/linux/driver.c (+0/-2522)
.pc/applied-patches (+3/-4)
ChangeLog (+5/-0)
INSTALL (+4/-4)
Makefile.in (+71/-68)
NEWS (+13/-0)
aclocal.m4 (+172/-171)
autom4te.cache/output.0 (+607/-564)
autom4te.cache/output.1 (+607/-564)
autom4te.cache/output.2 (+607/-564)
autom4te.cache/requests (+45/-46)
autom4te.cache/traces.0 (+456/-417)
autom4te.cache/traces.1 (+605/-599)
autom4te.cache/traces.2 (+456/-417)
checkvm/Makefile.in (+31/-17)
config/compile (+1/-2)
config/config.guess (+2/-2)
config/config.sub (+10/-1)
config/depcomp (+1/-2)
config/install-sh (+7/-7)
config/missing (+49/-50)
configure (+603/-560)
configure.ac (+82/-67)
debian/changelog (+25/-0)
debian/open-vm-dkms.dkms (+0/-8)
debian/open-vm-tools.init (+1/-1)
debian/patches/0002-dkms.patch (+18/-0)
debian/patches/0002-procps.patch (+0/-27)
debian/patches/0003-dkms-vmsync.patch (+45/-0)
debian/patches/0003-dkms.patch (+0/-18)
debian/patches/0004-dkms-vmsync.patch (+0/-45)
debian/patches/0004-vsock-cve.patch (+18/-0)
debian/patches/0005-kernel-38-fixes.patch (+0/-55)
debian/patches/series (+3/-4)
debian/rules (+1/-0)
docs/Makefile.in (+46/-55)
docs/api/Makefile.in (+5/-4)
hgfsclient/Makefile.in (+31/-17)
hgfsmounter/Makefile.in (+20/-6)
lib/Makefile.am (+6/-0)
lib/Makefile.in (+60/-69)
lib/appUtil/Makefile.in (+39/-22)
lib/asyncsocket/Makefile.am (+24/-0)
lib/asyncsocket/Makefile.in (+603/-0)
lib/asyncsocket/asyncSocketInt.h (+328/-0)
lib/asyncsocket/asyncsocket.c (+4990/-0)
lib/auth/Makefile.in (+39/-22)
lib/backdoor/Makefile.in (+39/-22)
lib/dataMap/Makefile.am (+21/-0)
lib/dataMap/Makefile.in (+602/-0)
lib/dataMap/dataMap.c (+2460/-0)
lib/dict/Makefile.in (+39/-22)
lib/dynxdr/Makefile.in (+39/-22)
lib/err/Makefile.in (+39/-22)
lib/err/err.c (+14/-7)
lib/file/Makefile.in (+39/-22)
lib/file/file.c (+10/-1)
lib/file/fileInt.h (+5/-0)
lib/file/filePosix.c (+375/-45)
lib/file/fileTempPosix.c (+24/-29)
lib/foundryMsg/Makefile.in (+39/-22)
lib/foundryMsg/foundryMsg.c (+4/-8)
lib/glibUtils/Makefile.in (+39/-22)
lib/guestApp/Makefile.in (+39/-22)
lib/guestRpc/Makefile.in (+39/-22)
lib/hashMap/Makefile.am (+21/-0)
lib/hashMap/Makefile.in (+602/-0)
lib/hashMap/hashMap.c (+1199/-0)
lib/hgfs/Makefile.in (+39/-22)
lib/hgfsBd/Makefile.in (+39/-22)
lib/hgfsHelper/Makefile.in (+39/-22)
lib/hgfsServer/Makefile.in (+39/-22)
lib/hgfsServer/hgfsServer.c (+565/-306)
lib/hgfsServer/hgfsServerInt.h (+24/-390)
lib/hgfsServer/hgfsServerLinux.c (+9/-6)
lib/hgfsServer/hgfsServerOplock.c (+4/-3)
lib/hgfsServer/hgfsServerOplock.h (+64/-0)
lib/hgfsServer/hgfsServerOplockInt.h (+74/-0)
lib/hgfsServer/hgfsServerOplockLinux.c (+1/-0)
lib/hgfsServer/hgfsServerPacketUtil.c (+27/-80)
lib/hgfsServer/hgfsServerParameters.c (+1161/-906)
lib/hgfsServer/hgfsServerParameters.h (+353/-0)
lib/hgfsServerManagerGuest/Makefile.in (+39/-22)
lib/hgfsServerManagerGuest/hgfsChannelGuest.c (+6/-1)
lib/hgfsServerManagerGuest/hgfsChannelGuestBd.c (+5/-1)
lib/hgfsServerPolicyGuest/Makefile.in (+39/-22)
lib/impersonate/Makefile.in (+39/-22)
lib/include/appUtil.h (+3/-0)
lib/include/asyncsocket.h (+464/-0)
lib/include/backdoor_def.h (+4/-1)
lib/include/buildNumber.h (+6/-6)
lib/include/clamped.h (+251/-0)
lib/include/codeset.h (+5/-2)
lib/include/config.h (+0/-2)
lib/include/dataMap.h (+176/-0)
lib/include/file.h (+11/-1)
lib/include/guest_os.h (+10/-12)
lib/include/guest_os_tables.h (+3/-1)
lib/include/hashMap.h (+88/-0)
lib/include/hashTable.h (+22/-21)
lib/include/hgfsProto.h (+32/-11)
lib/include/hgfsServer.h (+28/-24)
lib/include/hgfsTransport.h (+0/-53)
lib/include/includeCheck.h (+1/-3)
lib/include/loglevel_user.h (+5/-1)
lib/include/msg.h (+19/-1)
lib/include/poll.h (+314/-0)
lib/include/pollImpl.h (+320/-0)
lib/include/random.h (+6/-10)
lib/include/safetime.h (+4/-4)
lib/include/sigPosixRegs.h (+17/-0)
lib/include/sslStubs.h (+56/-0)
lib/include/str.h (+2/-1)
lib/include/util.h (+4/-0)
lib/include/uuid.h (+5/-2)
lib/include/vixCommands.h (+14/-37)
lib/include/vixOpenSource.h (+1/-0)
lib/include/vm_assert.h (+35/-4)
lib/include/vm_atomic.h (+163/-19)
lib/include/vm_basic_asm.h (+28/-11)
lib/include/vm_basic_asm_x86_64.h (+25/-12)
lib/include/vm_basic_defs.h (+5/-31)
lib/include/vm_basic_types.h (+13/-2)
lib/include/vm_product.h (+4/-4)
lib/include/vm_product_versions.h (+8/-8)
lib/include/vm_tools_version.h (+15/-0)
lib/include/vmci_defs.h (+25/-24)
lib/include/vmci_sockets.h (+31/-8)
lib/include/vmware/guestrpc/tclodefs.h (+13/-0)
lib/include/x86cpuid.h (+49/-26)
lib/lock/Makefile.in (+39/-22)
lib/lock/ul.c (+21/-38)
lib/lock/ulExcl.c (+11/-6)
lib/lock/ulIntShared.h (+3/-1)
lib/lock/ulRW.c (+2/-5)
lib/lock/ulRec.c (+11/-6)
lib/message/Makefile.in (+39/-22)
lib/misc/Makefile.am (+1/-0)
lib/misc/Makefile.in (+44/-26)
lib/misc/atomic.c (+20/-4)
lib/misc/codesetBase.c (+51/-3)
lib/misc/dynbuf.c (+2/-2)
lib/misc/posixPosix.c (+25/-1088)
lib/misc/posixPwd.c (+1108/-0)
lib/misc/random.c (+30/-11)
lib/netUtil/Makefile.in (+39/-22)
lib/panic/Makefile.in (+39/-22)
lib/panicDefault/Makefile.in (+39/-22)
lib/poll/Makefile.am (+21/-0)
lib/poll/Makefile.in (+602/-0)
lib/poll/poll.c (+2188/-0)
lib/pollGtk/Makefile.am (+24/-0)
lib/pollGtk/Makefile.in (+603/-0)
lib/pollGtk/pollGtk.c (+1496/-0)
lib/printer/Makefile.in (+39/-22)
lib/procMgr/Makefile.in (+39/-22)
lib/rpcChannel/Makefile.in (+39/-22)
lib/rpcIn/Makefile.in (+39/-22)
lib/rpcIn/rpcin.c (+1032/-140)
lib/rpcOut/Makefile.in (+39/-22)
lib/rpcVmx/Makefile.in (+39/-22)
lib/slashProc/Makefile.in (+39/-22)
lib/sslStubs/Makefile.am (+21/-0)
lib/sslStubs/Makefile.in (+602/-0)
lib/sslStubs/sslStubs.c (+482/-0)
lib/string/Makefile.in (+39/-22)
lib/string/bsd_vsnprintf.c (+1/-4)
lib/stubs/Makefile.in (+39/-22)
lib/syncDriver/Makefile.in (+39/-22)
lib/system/Makefile.in (+39/-22)
lib/unicode/Makefile.in (+39/-22)
lib/user/Makefile.in (+39/-22)
lib/vmCheck/Makefile.in (+39/-22)
lib/vmSignal/Makefile.in (+39/-22)
lib/wiper/Makefile.in (+39/-22)
lib/xdg/Makefile.in (+39/-22)
libguestlib/Makefile.in (+28/-12)
libhgfs/Makefile.in (+28/-12)
libvmtools/Makefile.am (+6/-0)
libvmtools/Makefile.in (+38/-14)
modules/Makefile.in (+29/-16)
modules/linux/dkms.conf (+1/-1)
modules/linux/dkms.sh (+2/-2)
modules/linux/shared/compat_mm.h (+1/-68)
modules/linux/shared/compat_module.h (+11/-0)
modules/linux/shared/vmciKernelAPI1.h (+63/-67)
modules/linux/shared/vmciKernelAPI2.h (+5/-8)
modules/linux/shared/vmci_defs.h (+25/-24)
modules/linux/vmci/Makefile.normal (+1/-2)
modules/linux/vmci/common/vmciContext.c (+40/-15)
modules/linux/vmci/common/vmciDatagram.c (+28/-27)
modules/linux/vmci/common/vmciDoorbell.c (+19/-18)
modules/linux/vmci/common/vmciDriver.c (+25/-21)
modules/linux/vmci/common/vmciEvent.c (+15/-10)
modules/linux/vmci/common/vmciPageChannel.c (+0/-1731)
modules/linux/vmci/common/vmciQPair.c (+70/-70)
modules/linux/vmci/common/vmciQueuePair.c (+3/-5)
modules/linux/vmci/common/vmciRoute.c (+3/-3)
modules/linux/vmci/linux/driver.c (+7/-17)
modules/linux/vmci/linux/vmci_version.h (+3/-3)
modules/linux/vmhgfs/fsutil.c (+2/-1)
modules/linux/vmhgfs/inode.c (+29/-13)
modules/linux/vmhgfs/tcp.c (+0/-972)
modules/linux/vmhgfs/transport.c (+0/-18)
modules/linux/vmhgfs/transport.h (+0/-2)
modules/linux/vmhgfs/vmci.c (+12/-11)
modules/linux/vsock/linux/af_vsock.c (+80/-74)
modules/linux/vsock/linux/notify.c (+10/-10)
modules/linux/vsock/linux/notifyQState.c (+3/-3)
modules/linux/vsock/linux/util.c (+6/-11)
modules/linux/vsock/linux/vsockAddr.c (+0/-34)
modules/linux/vsock/linux/vsockAddr.h (+0/-1)
modules/linux/vsock/linux/vsockCommon.h (+22/-1)
modules/linux/vsock/linux/vsockPacket.h (+8/-3)
modules/linux/vsock/linux/vsockSocketWrapper.h (+7/-2)
modules/linux/vsock/linux/vsock_version.h (+3/-3)
modules/shared/vmmemctl/balloonInt.h (+2/-6)
modules/shared/vmxnet/eth_public.h (+5/-1)
modules/shared/vmxnet/vmnet_def.h (+50/-48)
modules/shared/vmxnet/vmxnet2_def.h (+10/-22)
rpctool/Makefile.in (+31/-17)
scripts/Makefile.in (+5/-4)
scripts/linux/network (+50/-26)
services/Makefile.in (+46/-55)
services/plugins/Makefile.in (+47/-55)
services/plugins/desktopEvents/Makefile.in (+40/-23)
services/plugins/dndcp/Makefile.in (+40/-23)
services/plugins/dndcp/copyPasteDnDX11.cpp (+8/-0)
services/plugins/dndcp/copyPasteUIX11.cpp (+3/-3)
services/plugins/dndcp/dnd/dndCommon.c (+1/-1)
services/plugins/dndcp/dnd/rpcV3Util.hpp (+0/-2)
services/plugins/dndcp/dndGuest/rpcV3Util.cpp (+6/-8)
services/plugins/guestInfo/Makefile.in (+58/-64)
services/plugins/guestInfo/getlib/Makefile.in (+39/-22)
services/plugins/hgfsServer/Makefile.in (+40/-23)
services/plugins/powerOps/Makefile.in (+40/-23)
services/plugins/resolutionSet/Makefile.in (+40/-23)
services/plugins/timeSync/Makefile.in (+40/-23)
services/plugins/vix/Makefile.in (+40/-23)
services/plugins/vix/vixTools.c (+84/-12)
services/plugins/vmbackup/Makefile.in (+39/-23)
services/plugins/vmbackup/stateMachine.c (+5/-0)
services/vmtoolsd/Makefile.in (+33/-18)
services/vmtoolsd/cmdLine.c (+25/-1)
tests/Makefile.in (+47/-55)
tests/testDebug/Makefile.in (+40/-23)
tests/testPlugin/Makefile.in (+40/-23)
tests/testVmblock/Makefile.in (+20/-6)
tests/vmrpcdbg/Makefile.in (+39/-22)
toolbox/Makefile.in (+28/-14)
vmblock-fuse/Makefile.in (+31/-17)
vmblockmounter/Makefile.in (+20/-6)
vmware-user-suid-wrapper/Makefile.in (+28/-14)
xferlogs/Makefile.in (+31/-17)
lp:~n-muench/ubuntu/saucy/open-vm-tools/open-vm-tools.fix-1175295.try2 (Merged)
lp:ubuntu/saucy-proposed/open-vm-tools

CVE References

Revision history for this message
Fabio Marconi (fabiomarconi) wrote :
Revision history for this message
Nate Muench (Mink) (n-muench) wrote :

In progress. I've linked prep branch. It'll be slow work until we get the LiveCD start coming out, and also it's still early in the development cycle, so I'm taking my time.

I still have to test the packaging, but the prep branch isn't mature enough to start auto building it, since the (planned) major changes haven't been pushed yet.

Changed in open-vm-tools (Ubuntu):
assignee: nobody → Nate Muench (Mink) (n-muench)
status: New → In Progress
Apport retracing service (apport)
tags: removed: need-duplicate-check
Revision history for this message
Nate Muench (Mink) (n-muench) wrote :

There currently an issue, package fails to build in Saucy. but a build with Raring built successfully. Will compare build logs later.

Making all in backdoor
make[3]: Entering directory `/build/buildd/open-vm-tools-2013.04.16-1098359/lib/backdoor'
--------------------------------------SNIP---------------------------------------------
In file included from /build/buildd/open-vm-tools-2013.04.16-1098359/lib/include/backdoor.h:44:0,
                 from backdoor.c:49:
/build/buildd/open-vm-tools-2013.04.16-1098359/lib/include/backdoor_types.h: In function 'BACKDOOR_STRUCT_SIZES':
/build/buildd/open-vm-tools-2013.04.16-1098359/lib/include/vm_assert.h:370:20: error: typedef 'AssertOnCompileFailed' locally defined but not used [-Werror=unused-local-typedefs]
       typedef char AssertOnCompileFailed[AssertOnCompileMisused]; \
                    ^
/build/buildd/open-vm-tools-2013.04.16-1098359/lib/include/vm_assert.h:392:7: note: in definition of macro 'MY_ASSERTS'
       assertions \
       ^
/build/buildd/open-vm-tools-2013.04.16-1098359/lib/include/backdoor_types.h:126:12: note: in expansion of macro 'ASSERT_ON_COMPILE'
            ASSERT_ON_COMPILE(sizeof(Backdoor_proto) == 6 * sizeof(uintptr_t));
            ^
/build/buildd/open-vm-tools-2013.04.16-1098359/lib/include/vm_assert.h:370:20: error: typedef 'AssertOnCompileFailed' locally defined but not used [-Werror=unused-local-typedefs]
       typedef char AssertOnCompileFailed[AssertOnCompileMisused]; \
                    ^
/build/buildd/open-vm-tools-2013.04.16-1098359/lib/include/vm_assert.h:392:7: note: in definition of macro 'MY_ASSERTS'
       assertions \
       ^
/build/buildd/open-vm-tools-2013.04.16-1098359/lib/include/backdoor_types.h:127:12: note: in expansion of macro 'ASSERT_ON_COMPILE'
            ASSERT_ON_COMPILE(sizeof(Backdoor_proto_hb) == 7 * sizeof(uintptr_t));
            ^
cc1: all warnings being treated as errors
make[3]: *** [backdoor.lo] Error 1
make[3]: Leaving directory `/build/buildd/open-vm-tools-2013.04.16-1098359/lib/backdoor'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/build/buildd/open-vm-tools-2013.04.16-1098359/lib'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/build/buildd/open-vm-tools-2013.04.16-1098359'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

Revision history for this message
Nate Muench (Mink) (n-muench) wrote :

It's failing because of GCC 4.8. I've reported it to upstream (https://sourceforge.net/tracker/?func=detail&aid=3613125&group_id=204462&atid=989708)

Revision history for this message
Nate Muench (Mink) (n-muench) wrote :

After doing some googleing, I found a solution, adding a CFLAG does the trick. Until we get a newer version. I'll put a proposal together later this week, after approval, I'll get started on revision 2 (the point of this first one was to get the package building successfully).

Revision history for this message
Nate Muench (Mink) (n-muench) wrote :

I can give an update. The first update is basically done, just got to create proposal. The only issue right now is you can't use shared folders (vmhgfs can't be loaded), which may or may not be related to incompatibilities with GCC 4.8, and being forced to add that CFLAG to allow it to build (which will be removed after upstream releases a new version, assuming compatibilities are fixed). But the vmxnet module works.

Nate Muench (Mink) (n-muench)
Changed in open-vm-tools (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package open-vm-tools - 2013.04.16-1098359-0ubuntu1

---------------
open-vm-tools (2013.04.16-1098359-0ubuntu1) saucy-proposed; urgency=low

  * Merging upstream version 2013.04.16-1098359.
    - Fixes building on Saucy kernels (LP: #1175295).

  * Stop DKMS from building vmci & vsock modules
    - Modules are now in the kernel.

  * debian/patches:
    - Removing procps.patch, not needed anymore.
    - Removed 0005-kernel-38-fixes.patch
      + No longer needed.
    - Renumbering patches.

  * debian/rules:
    - Added Wno-error=unused-local-typedefs to CLFAGS
      + Suppresses build errors with GCC 4.8.

  * Items merged from Debian:
    (From 2:9.2.2-893683-8 release)
    - Adding patch from Mathias Krause <email address hidden> to fix
      kernel stack memory leack in vsock module [CVE-2013-3237]
 -- Nate Muench <email address hidden> Wed, 29 May 2013 12:57:21 -0500

Changed in open-vm-tools (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.