Since a Saucy GTK update, psensor fails to build

Bug #1184442 reported by Jean-Philippe Orsini
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
psensor (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Due to a Saucy GTK update, psensor cannot be build.

The error is due to the deprecation of the GTK Color Selection widget, and the Psensor build fails on deprecation warnings.

ui_color.c: In function 'ui_change_color':
ui_color.c:26:2: error: unknown type name 'GtkColorSelection'
  GtkColorSelection *colorsel;
  ^
ui_color.c:28:2: error: unknown type name 'GtkColorSelectionDialog'
  GtkColorSelectionDialog *colordlg;
  ^
ui_color.c:35:3: error: implicit declaration of function 'GTK_COLOR_SELECTION_DIALOG' [-Werror=implicit-function-declaration]
   (gtk_color_selection_dialog_new(title));
   ^
ui_color.c:35:3: error: implicit declaration of function 'gtk_color_selection_dialog_new' [-Werror=implicit-function-declaration]
ui_color.c:34:11: error: assignment makes pointer from integer without a cast [-Werror]
  colordlg = GTK_COLOR_SELECTION_DIALOG
           ^
ui_color.c:38:3: error: implicit declaration of function 'GTK_COLOR_SELECTION' [-Werror=implicit-function-declaration]
   (gtk_color_selection_dialog_get_color_selection(colordlg));
   ^
ui_color.c:38:3: error: implicit declaration of function 'gtk_color_selection_dialog_get_color_selection' [-Werror=implicit-function-declaration]
ui_color.c:37:11: error: assignment makes pointer from integer without a cast [-Werror]
  colorsel = GTK_COLOR_SELECTION
           ^
ui_color.c:40:2: error: implicit declaration of function 'gtk_color_selection_set_current_color' [-Werror=implicit-function-declaration]
  gtk_color_selection_set_current_color(colorsel, &color);
  ^
ui_color.c:45:3: error: implicit declaration of function 'gtk_color_selection_get_current_color' [-Werror=implicit-function-declaration]
   gtk_color_selection_get_current_color(colorsel, &color);
   ^
cc1: all warnings being treated as errors

Revision history for this message
Jean-Philippe Orsini (jfi) wrote :

Debdiff fixing this bug by allowing usage of deprecated gtk widgets.

This issue is fixed upstream in the trunk repository by replacing the deprecated GtkColorSelectionDialog by GtkColorChooserDialog. It will be available in the future 0.8.0.3 release of Psensor.

Additionnaly, this patch also switch to 3.9.4 Standards version.

description: updated
Revision history for this message
Jean-Philippe Orsini (jfi) wrote :

Dear sponsor,
I am going to release a new version of Psensor including the real fix and push its debian package. Unfortunely, as I do not have a debian sponsor it may take a while.
As the above patch is a one line change, I guess it is better to apply it than wait the debian package to be available, but you may have a different opinion.
Thanks for your time!

Revision history for this message
Martin Pitt (pitti) wrote :

Jean-Philippe, thanks! I uploaded the fix.

If you need a Debian sponsor, please feel free to ping/mail me.

Changed in psensor (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package psensor - 0.7.0.3-1ubuntu2

---------------
psensor (0.7.0.3-1ubuntu2) saucy; urgency=low

  * added debian/patches/allow_gtk_deprecates.patch: to workaround
    compilation failure with new gtk release. (LP: #1184442)
  * debian/control: switched to 3.9.4 Standards Version.
  * Remaining changes:
    + Modifed build-dep to add NVidia and Application Indicator support
    + Only add an nvidia-settings build-dep on i386 and amd6
 -- Jean-Philippe Orsini <email address hidden> Mon, 27 May 2013 00:45:33 +0200

Changed in psensor (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.