Ubuntu
dkimpy package

DKIM verification failure for unfolded headers due to bad regex

Bug #1189555 reported by Scott Kitterman
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dkimpy (Debian)
Fix Released
Unknown
dkimpy (Ubuntu)
Fix Released
High
Scott Kitterman
Precise
Fix Released
High
Scott Kitterman
Quantal
Fix Released
High
Scott Kitterman
Raring
Fix Released
High
Scott Kitterman

Bug Description

An incorrect regex in all dkimpy 0.5 versions (and probably earlier ones, but didn't check) causes any header unfolding to break signature verification. This is incorrect based on the DKIM spec and has cause real world verification failures when procmail is used in the mail delivery process.

[Impact]

 * See above. This may cause messages to be sent to a spam folder when they shouldn't or deleted. This is effectively a data loss bug.

 * The only change is a fixed regex that solves the problem.

[Test Case]

 * Install python-dkim from the release or updates pocket (depends on which release) and download the two messages attached to the bug. Then run the dkimverify script on the two of them. The first will pass, the second won't (but should):

$ dkimverify <mail1
signature ok
$ dkimverify <mail2
signature verification failed

 * Install the updated packages from -proposed and repeat. Both messages should verify now:

$ dkimverify <mail1
signature ok
$ dkimverify <mail2
signature ok

[Regression Potential]

 * Regression potential is nil. The regex change that was proposed by the bug reporter has been reviewed by three upstream developers and no regression was shown when the upstream test suite is run.

Revision history for this message
Scott Kitterman (kitterman) wrote :
Revision history for this message
Scott Kitterman (kitterman) wrote :
Changed in dkimpy (Ubuntu Precise):
status: New → In Progress
Changed in dkimpy (Ubuntu Quantal):
status: New → In Progress
Changed in dkimpy (Ubuntu Raring):
status: New → In Progress
Changed in dkimpy (Ubuntu Precise):
importance: Undecided → High
Changed in dkimpy (Ubuntu Quantal):
importance: Undecided → High
Changed in dkimpy (Ubuntu Raring):
importance: Undecided → High
Changed in dkimpy (Ubuntu Precise):
assignee: nobody → Scott Kitterman (kitterman)
Changed in dkimpy (Ubuntu Quantal):
assignee: nobody → Scott Kitterman (kitterman)
Changed in dkimpy (Ubuntu Raring):
assignee: nobody → Scott Kitterman (kitterman)
Revision history for this message
Scott Kitterman (kitterman) wrote :

Fixed for saucy in 0.5.4-1 sync'ed from Debian.

Changed in dkimpy (Ubuntu):
status: In Progress → Fix Released
Scott Kitterman (kitterman)
summary: - Improver verification failure for unfolded headers due to bad regex
+ DKIM verification failure for unfolded headers due to bad regex
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Scott, or anyone else affected,

Accepted dkimpy into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/dkimpy/0.5.3-0ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in dkimpy (Ubuntu Quantal):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in dkimpy (Ubuntu Precise):
status: In Progress → Fix Committed
Revision history for this message
Adam Conrad (adconrad) wrote :

Hello Scott, or anyone else affected,

Accepted dkimpy into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/dkimpy/0.5.3-0ubuntu0.0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Adam Conrad (adconrad) wrote :

Hello Scott, or anyone else affected,

Accepted dkimpy into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/dkimpy/0.5.3-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in dkimpy (Ubuntu Raring):
status: In Progress → Fix Committed
Bug Watch Updater (bug-watch-updater)
Changed in dkimpy (Debian):
status: Unknown → Fix Released
Revision history for this message
Scott Kitterman (kitterman) wrote :

Succeeded verification with proposed packages on precise, quantal, and raring.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dkimpy - 0.5.3-0ubuntu0.0.2

---------------
dkimpy (0.5.3-0ubuntu0.0.2) precise-proposed; urgency=low

  * Fix Gmail signature verification failures due to improper FWS regular
    expression - Thanks to Peter Palfrader (weasel) for the patch
    (LP: #1189555)
 -- Scott Kitterman <email address hidden> Sun, 09 Jun 2013 23:31:12 -0400

Changed in dkimpy (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dkimpy - 0.5.3-0ubuntu0.2

---------------
dkimpy (0.5.3-0ubuntu0.2) quantal-proposed; urgency=low

  * Fix Gmail signature verification failures due to improper FWS regular
    expression - Thanks to Peter Palfrader (weasel) for the patch
    (LP: #1189555)
 -- Scott Kitterman <email address hidden> Sun, 09 Jun 2013 23:31:12 -0400

Changed in dkimpy (Ubuntu Quantal):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dkimpy - 0.5.3-1ubuntu1

---------------
dkimpy (0.5.3-1ubuntu1) raring-proposed; urgency=low

  * Fix Gmail signature verification failures due to improper FWS regular
    expression - Thanks to Peter Palfrader (weasel) for the patch
    (LP: #1189555)
 -- Scott Kitterman <email address hidden> Sun, 09 Jun 2013 23:31:12 -0400

Changed in dkimpy (Ubuntu Raring):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.