fwts_test needs to trap ABORT exit status too
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox |
Fix Released
|
High
|
Jeff Lane | ||
Bug Description
recent changes to fwts has enabled some tests on armhf that were not there. These tests are not arm valid tests, however, but they are added in to help us out (we don't have to create different tests for arm vs x86, or we don't need to specify per arch code in the wrapper).
One change recently was the enablement of the wakealarm test. because this doesn't exist on armhf, the test itself fails, but fwts reports it as an ABORT because the lack of wakealarm means the test isnt necessary... Here's what fwts says:
FAILED [MEDIUM] NoWakeAlarmTest1: Test 1, Could not find /sys/class/
ADVICE: non-x86 devices sometimes do not have an RTC wake alarm that is normally controlled by the
/sys/class/
be aborted.
Thus, instead of exiting with a status of MEDIUM, it exits with a status of ABORT.
So we need to trap these and ensure FWTS can fail on ABORT.
Related branches
- Daniel Manrique (community): Approve
- Jeff Lane : Needs Resubmitting
- Zygmunt Krynicki (community): Approve
-
Diff: 94 lines (+24/-4)3 files modifiedcheckbox-old/debian/changelog (+5/-0)
checkbox-old/jobs/power-management.txt.in (+1/-1)
checkbox-old/scripts/fwts_test (+18/-3)
| Jeff Lane (bladernr) wrote | #1 |
| summary: |
- fwts_test needs to trap ABORT exit status tool + fwts_test needs to trap ABORT exit status too |
| Changed in checkbox: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Jeff Lane (bladernr) |
| Changed in checkbox: | |
| status: | In Progress → Fix Committed |
| Changed in checkbox: | |
| status: | Fix Committed → Fix Released |
script now fails on aborts, if you specify '--fail-level aborted' This will allow us to continue using things like fwts_wakealarm as a dependency for other tests, even when the test is marked aborted because wakealarm doesn't exist on ARM.