Ubuntu
ubuntu-release-upgrader package

proposed should be disabled on upgrade to development release

Bug #1199157 reported by Andrew Starr-Bochicchio
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ubuntu-release-upgrader (Ubuntu)
Fix Released
Medium
Andrew Starr-Bochicchio
Raring
Fix Released
Medium
Brian Murray

Bug Description

[Impact]
People upgrading from Raring, with -proposed enabled, to Saucy will still have -proposed enabled. Because -proposed is used as a tested bed in Ubuntu+1 this can result in a terrible experience for people.

[Test Case]
0) Add raring-proposed to /etc/apt/sources.list
1) Run do-release-upgrade -d
2) Upgrade to saucy
3) Observe that /etc/apt/sources.list has saucy-proposed enabled

(Its also possible to inspect /etc/apt/sources.list after it has been rewritten, when you are presented with the final upgrade prompt, and observe that saucy-proposed is present in it.)

With the version of ubuntu-release-upgrader from raring-proposed you'll notice that /etc/apt/sources.list has a comment indicating that saucy-proposed is not for humans.

[Regression Potential]
Very little as we are just passing the --devel-release option along to the dist upgrader.

Original Description
--------------------
proposed is now used as a testbed and staging area in Ubuntu+1 and is not to be used by humans. I just installed raring in a VM, enabled proposed, and the upgraded with 'do-release-upgrade -d' When finished, proposed is enabled and packages from proposed are installed. There's no guarantee that proposed will even be installable.

It should be disabled on upgrade to development release.

See original description

Related branches

lp:~andrewsomething/ubuntu-release-upgrader/lp1199157
Brian Murray: Approve
Diff: 87 lines (+45/-1)
4 files modified
DistUpgrade/DistUpgradeController.py (+11/-1)
debian/changelog (+6/-0)
tests/data-sources-list-test/sources.list.proposed_enabled (+5/-0)
tests/test_sources_list.py (+23/-0)
lp:ubuntu/saucy-proposed/ubuntu-release-upgrader
lp:ubuntu/raring-proposed/ubuntu-release-upgrader
Andrew Starr-Bochicchio (andrewsomething)
Changed in ubuntu-release-upgrader (Ubuntu):
assignee: nobody → Andrew Starr-Bochicchio (andrewsomething)
status: New → In Progress
importance: Undecided → Medium
Adolfo Jayme Barrientos (fitojb)
Changed in ubuntu-release-upgrader (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:0.197

---------------
ubuntu-release-upgrader (1:0.197) saucy; urgency=low

  [ Andrew Starr-Bochicchio ]
  * Disable proposed on upgrade to a development release (LP: #1199157).
 -- Brian Murray <email address hidden> Tue, 09 Jul 2013 11:40:52 -0700

Changed in ubuntu-release-upgrader (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

This introduced a regression as seen in bug 1200135 because options.devel_release was not set. I've fixed that now but check-new-release-gtk and do-release-upgrade (in raring) will both need to pass along the --devel-release switch to the dist-upgrader. This bug seems best for the SRU of that.

Brian Murray (brian-murray)
description: updated
Brian Murray (brian-murray)
Changed in ubuntu-release-upgrader (Ubuntu Raring):
status: New → In Progress
assignee: nobody → Brian Murray (brian-murray)
importance: Undecided → Medium
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Andrew, or anyone else affected,

Accepted ubuntu-release-upgrader into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:0.192.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ubuntu-release-upgrader (Ubuntu Raring):
status: In Progress → Fix Committed
tags: added: verification-needed
Brian Murray (brian-murray)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote :

I tested this using ubuntu-release-upgrader-core, and friends, version 1:0.192.12 from raring-proposed. When I inspected my /etc/apt/sources.list file during the upgrade I observed that my raring-proposed entry was changed to saucy-proposed and disabled with the appropriate comment. Subsequently, I am marking this as verification-done.

description: updated
tags: added: verification-done
removed: verification-needed
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:0.192.12

---------------
ubuntu-release-upgrader (1:0.192.12) raring-proposed; urgency=low

  * pass along devel-release switch to the dist-upgrader so that proposed
    repositories can be disabled if one is upgrading to the the development
    release (LP: #1199157)
 -- Brian Murray <email address hidden> Thu, 11 Jul 2013 10:33:45 -0700

Changed in ubuntu-release-upgrader (Ubuntu Raring):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.