/usr/lib/ubuntu-release-upgrader/check-new-release-gtk:TypeError:on_button_upgrade_now_clicked:run:error:error:__init__:__init__:function

Bug #1199984 reported by errors.ubuntu.com bug bridge
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-release-upgrader (Ubuntu)
Fix Released
High
Brian Murray
Quantal
Fix Released
High
Brian Murray
Raring
Fix Released
High
Brian Murray

Bug Description

The Ubuntu Error Tracker has been receiving reports about a problem regarding ubuntu-release-upgrader. This problem was most recently seen with version 1:0.190.7, the problem page at https://errors.ubuntu.com/problem/95e23eef1d67b997e47197c477a3149fa3b97b7b contains more details.

[Test Case]
1) On a Raring system run /usr/lib/ubuntu-release-upgrader/check-new-release-gtk -d (on Quantal -d is not necessary)
2) Disable networking
3) Click "Yes, Upgrade Now"
4) Observe a crash with the traceback listed below

With the version of ubuntu-release-upgrader in -proposed you will instead see an error dialog indicating that "Fetching the upgrade failed..."

Revision history for this message
Brian Murray (brian-murray) wrote :

Here is the Traceback for the error:

Traceback (most recent call last):
  File "/usr/lib/ubuntu-release-upgrader/check-new-release-gtk", line 137, in on_button_upgrade_now_clicked
    res = fetcher.run()
  File "/usr/lib/python3/dist-packages/DistUpgrade/DistUpgradeFetcherCore.py", line 278, in run
    _("Fetching the upgrade failed. There may be a network "
  File "/usr/lib/python3/dist-packages/DistUpgrade/DistUpgradeFetcher.py", line 50, in error
    return error(self.window_main, summary, message)
  File "/usr/lib/python3/dist-packages/DistUpgrade/utils.py", line 442, in error
    buttons=Gtk.ButtonsType.CLOSE)
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 503, in __init__
    **kwds)
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 434, in __init__
    self.set_transient_for(parent)
  File "/usr/lib/python3/dist-packages/gi/types.py", line 47, in function
    return info.invoke(*args, **kwargs)
TypeError: argument parent: Expected Gtk.Window, but got __main__.CheckNewReleaseGtk

Changed in ubuntu-release-upgrader (Ubuntu):
status: New → Triaged
importance: Undecided → High
Changed in ubuntu-release-upgrader (Ubuntu Quantal):
status: New → Triaged
importance: Undecided → High
Revision history for this message
Brian Murray (brian-murray) wrote :

It seems a bit odd but this fixes it.

 $ bzr cdiff
=== modified file 'DistUpgrade/DistUpgradeFetcher.py'
--- DistUpgrade/DistUpgradeFetcher.py 2013-01-15 15:51:10 +0000
+++ DistUpgrade/DistUpgradeFetcher.py 2013-08-21 23:49:21 +0000
@@ -47,7 +47,7 @@
         self.window_main = parent

     def error(self, summary, message):
- return error(self.window_main, summary, message)
+ return error(self.window_main.window_main, summary, message)

     def runDistUpgrader(self):
         inhibit_sleep()

Changed in ubuntu-release-upgrader (Ubuntu Raring):
status: New → Triaged
importance: Undecided → High
Changed in ubuntu-release-upgrader (Ubuntu):
assignee: nobody → Brian Murray (brian-murray)
description: updated
description: updated
Changed in ubuntu-release-upgrader (Ubuntu Raring):
assignee: nobody → Brian Murray (brian-murray)
Changed in ubuntu-release-upgrader (Ubuntu Quantal):
assignee: nobody → Brian Murray (brian-murray)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:0.200

---------------
ubuntu-release-upgrader (1:0.200) saucy; urgency=low

  * DistUpgradeFetcher.py: Properly pass Gtk.window to error (LP: #1199984)
  * ubuntu-release-upgrader-gtk: depend on gir1.2-webkit-3.0 (LP: #1215526)
 -- Brian Murray <email address hidden> Thu, 22 Aug 2013 09:48:10 -0700

Changed in ubuntu-release-upgrader (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello errors.ubuntu.com, or anyone else affected,

Accepted ubuntu-release-upgrader into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:0.190.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ubuntu-release-upgrader (Ubuntu Quantal):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello errors.ubuntu.com, or anyone else affected,

Accepted ubuntu-release-upgrader into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:0.192.13 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ubuntu-release-upgrader (Ubuntu Raring):
status: Triaged → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote :

Tested the update-manager version 1:0.192.13 from raring-proposed and it works.

tags: added: verification-done-raring
tags: added: verification-done-quantal
Revision history for this message
Brian Murray (brian-murray) wrote :

I test this on Quantal and it worked.

tags: removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:0.190.8

---------------
ubuntu-release-upgrader (1:0.190.8) quantal-proposed; urgency=low

  * u-r-u-gtk: Depend on gksu so that distribution upgrades will work
    (LP: #1210649)
  * u-r-u-gtk: Depend on gir1.2-webkit-3.0 (LP: #1215526)
  * DistUpgradeFetcher.py: Properly pass Gtk.window to error
    (LP: #1199984)
 -- Brian Murray <email address hidden> Thu, 22 Aug 2013 13:38:36 -0700

Changed in ubuntu-release-upgrader (Ubuntu Quantal):
status: Fix Committed → Fix Released
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:0.192.13

---------------
ubuntu-release-upgrader (1:0.192.13) raring-proposed; urgency=low

  * u-r-u-gtk: Depend on gksu so that distribution upgrades will work
    (LP: #1210649)
  * u-r-u-gtk: Depend on gir1.2-webkit-3.0 (LP: #1215526)
  * DistUpgradeFetcher.py: Properly pass Gtk.window to error
    (LP: #1199984)
 -- Brian Murray <email address hidden> Tue, 20 Aug 2013 15:32:42 -0700

Changed in ubuntu-release-upgrader (Ubuntu Raring):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.