FFe: Update gnome-settings-daemon to 3.8.4

Thanks, I'm not part of the release team but I've some questions:

- what's the rational for updating (why do we need to update this cycle)

- how much testing did you do on compiz/unity?

The fact that some keys got dropped from the schemas and that gnome-control-center needs to be updated as well suggest that the update is non trivial and has potential to create issues, I would vote for those changes to happen next cycle if there is not a really strong reason we need it this cycle (and I didn't see one so far)

1. GNOME 3.8 has only been tested with gnome-settings-daemon 3.8 and there's no guarantee that things work correctly when we mix and match pieces.
2. Since we did the gsettings-desktop-schemas update, there are gsettings keys that won't actually do anything without the updated gnome-settings-daemon backend. Even without doing the gnome-control-center 3.8 update, it would be nice for GNOME users to be able to tweak some of the new settings in dconf-editor at least.
3. We need to update this cycle because we need to fix bug 1201679 which is a High priority regression in Unity (GNOME was unaffected).
4. There are numerous other fixes and improvements if you read through the NEWS file. The update isn't just GNOME dropping Fallback support and we've patched back in the fallback pieces that Unity currently needs.
5. Tim did a lot of work on this update with the assumption that it could make it into Saucy. We were delayed several weeks by indicator-keyboard taking longer to land than expected. I tried to help indicator-keyboard along as well as I could and complained that the longer the delay, the more difficult it would be to land gnome-settings-daemon 3.8 by Feature Freeze.

There was one final regression that Tim fixed over the weekend. Ubuntu GNOME shouldn't be penalized for taking care not to cause regressions and waiting for Unity work.

I've been running Unity all weekend to make sure that the update didn't cause any new problems. Many people have installed the GNOME3 Staging PPA; some of those people use Unity.

> 1. GNOME 3.8 has only been tested with gnome-settings-daemon 3.8 and there's no guarantee that things work correctly when we mix and match pieces.

the pieces that are the most matched are gnome-settings-daemon and gnome-control-center, which are both in sync on 3.6 at the moment. Does that mean you plan to FFe gnome-control-center as well (saying the number of changes in g-c-c 3.8 I doubt it's a good idea to do that at the end of the cycle)

> 2. Since we did the gsettings-desktop-schemas update, there are gsettings keys that won't actually do anything without the updated gnome-settings-daemon backend.

Do we have those exposed to users anywhere or is that a dconf editor issue? We might also want to just drop those keys from the schemas if you think that really confuses users

> 3. We need to update this cycle because we need to fix bug 1201679 which is a High priority regression in Unity (GNOME was unaffected).

Seems like that should be a one commit to backport if we need that fixes

> 4. There are numerous other fixes and improvements if you read through the NEWS file. The update isn't just GNOME dropping Fallback support and we've patched back in the fallback pieces that Unity currently needs.

Right, there are lot of changes in there, which makes me cautious, gnome-settings-daemon has little automated testing and it's a somewhat fragile component.

> 5. Tim did a lot of work on this update with the assumption that it could make it into Saucy. We were delayed several weeks by
> indicator-keyboard taking longer to land than expected. I tried to help indicator-keyboard along as well as I could and
> complained that the longer the delay, the more difficult it would be to land gnome-settings-daemon 3.8 by Feature Freeze.

Right, thanks Tim for the work! The work is not wasted in any case, even if that only lands next cycle. Things being less trivial than expected is not a real reason to grant a FFe though, as you pointed we still have fallout from 3.6 ibus migration we didn't sort out, it seems like what we need is extra work on stabilization rather than changing that much late in the cycle

> There was one final regression that Tim fixed over the weekend. Ubuntu GNOME shouldn't be penalized for taking care not to
> cause regressions and waiting for Unity work.

It's not a matter to be "penalized", what is the direct impact at the moment on Ubuntu GNOME (out of not having the latests upstream version)? The argument can go the other way around, Ubuntu GNOME wanted to be on the current version is not a reason to create instability from Unity/Ubuntu...

> I've been running Unity all weekend to make sure that the update didn't cause any new problems. Many people have installed
> the GNOME3 Staging PPA; some of those people use Unity.

That's good to know!

To summarize my opinion: from the past record I would be careful to update gnome-settings-daemon that late in the cycle, that's a component that drives many settings in the desktop and which is not easy to test.

Having gnome-settings-daemon/gnome-control-center out of sync is something we avoided so far, because it has extra potential to create issue, and I'm still unsure that's somet...

> Does that mean you plan to FFe gnome-control-center as well (saying the number of changes in g-c-c 3.8 I doubt it's a good idea to do that at the end of the cycle)

gnome-control-center 3.8 is about 90-95% ready and has quite a few improvements Ubuntu GNOME really wants. But there's too much work to be done to land now with zero regressions. We could really use Canonical help for the remaining work but obviously you guys have other pressing requirements this week. So no, I don't plan to file a FFe for gnome-control-center 3.8 for 13.10.

On the other hand, we've talked for a long time about possibly forking gnome-control-center so that there's both a mostly vanilla gnome-control-center and a Ubuntu tweaked version in the repositories (but it won't be possible for both to be simultaneously installed). gnome-control-center is in good enough shape for GNOME — it's just the Unity integration that needs more work — so we might still do a FFe for that proposal if we agree that the benefits outweigh the negatives.

Running gnome-shell 3.8 on gnome-settings-daemon 3.6 is likely to be very buggy and unstable. Although admittedly it hasn’t had a huge amount of testing since the assumption was that we would get g-s-d 3.8 into saucy.

For the 3.8 cycle many features were moved out of gnome-settings-daemon and into other components such as mutter and gnome-shell. Most of these however require code changes in g-s-d to use the new components. Other than this there were not really many new features added to g-s-d and it is largely just a big bug fix release.

- OSD Popups are now drawn by gnome-shell so that they match the shell UI.
- Keygrabber was moved into gnome-shell, since there were lots of issues with media_keys keybindings not working in certain parts of gnome-shell
- Background plugin was moved into mutter
- Screenshots are handled by gnome-shell.
- Power support is pretty much broken when using g-s-d 3.6

All of these were moved to overcome technical limitations making it hard or impossible to fix key bugs. In most cases by sticking with 3.6 we do not get to take advantage of these new components and we are left using the old unmaintained and buggy implementations.

In addition there are lots of bug fixes for things like power plugin, notifications etc.

As for mixing g-s-d 3.8 with g-c-c 3.6, apart from a few moved gsettings keys there are no major issues.

A lot of work went into improving a number of the upstream panels (particularly network, power and region panels), and there a number of new panels (notifications, privacy etc). However these changes are more or less contained to g-c-c and don't introduce incompatibilities for g-s-d.

Clearly Ubuntu GNOME really wants g-c-c 3.8 for these improvements. The remaining Unity issues are all mostly trivial, however have basically been blocked waiting on input from the desktop team. As far as I know no one even bothered to look at this, even when I was working on these issues very early in the Saucy cycle.

Nearly all the work I did on g-s-d was to fix Unity Integration. g-c-c was split more evenly between general ubuntu integration and unity integration. Obviously if regressions pop up, I will get them sorted.

On Sun, Sep 01, 2013 at 04:35:00PM -0000, Launchpad Bug Tracker wrote:
> You have been subscribed to a public bug by Jeremy Bicha (jbicha):
>
> https://bazaar.launchpad.net/~gnome3-team/gnome-settings-
> daemon/ubuntu/view/head:/debian/changelog
>
> https://git.gnome.org/browse/gnome-settings-daemon/tree/NEWS?h=gnome-3-8
>
> Call for testing: https://lists.ubuntu.com/archives/ubuntu-
> desktop/2013-August/004296.html
>
> The Ubuntu GNOME team has been testing gnome-settings-daemon 3.8 with
> packages available in the GNOME3 Staging PPA (for 13.04 users) since the
> Saucy cycle opened. We didn't get the upload in by Feature Freeze
> because we were waiting for indicator-keyboard to land in Saucy to make
> sure that this upload didn't cause any regressions with the input method
> support. There are no known remaining regressions with this upload.

Tim did a CFT on ubuntu-desktop a while back. Did you get much feedback
either way from this?

Just asking; I've been running on my desktop and apart from the issue
below I didn't notice anything untoward. I've not customised very much
though.

> I can no longer reproduce bug 1201679 with this build.
>
> gnome-control-center also needs updating (for moved gsettings keys and
> similar) and gnome-shell needs a patch to be dropped. I am ready to
> upload all three of these packages now.

ubuntu-settings also needs an update for idle-dim-time.

Cheers,

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

> ubuntu-settings also needs an update for idle-dim-time.

what "idle-dime-time"? was there a key change there? is there any migration/did anyone grep the archive for other clients of the old key?

On 03/09/13 19:45, Iain Lane wrote:
> On Sun, Sep 01, 2013 at 04:35:00PM -0000, Launchpad Bug Tracker wrote:
>> You have been subscribed to a public bug by Jeremy Bicha (jbicha):
>>
>> https://bazaar.launchpad.net/~gnome3-team/gnome-settings-
>> daemon/ubuntu/view/head:/debian/changelog
>>
>> https://git.gnome.org/browse/gnome-settings-daemon/tree/NEWS?h=gnome-3-8
>>
>> Call for testing: https://lists.ubuntu.com/archives/ubuntu-
>> desktop/2013-August/004296.html
>>
>> The Ubuntu GNOME team has been testing gnome-settings-daemon 3.8 with
>> packages available in the GNOME3 Staging PPA (for 13.04 users) since the
>> Saucy cycle opened. We didn't get the upload in by Feature Freeze
>> because we were waiting for indicator-keyboard to land in Saucy to make
>> sure that this upload didn't cause any regressions with the input method
>> support. There are no known remaining regressions with this upload.
> Tim did a CFT on ubuntu-desktop a while back. Did you get much feedback
> either way from this?
Apart from the one guy that was replying on list, I had a couple of reports that input switching
wasnt working (but that is fixed now).
>
> Just asking; I've been running on my desktop and apart from the issue
> below I didn't notice anything untoward. I've not customised very much
> though.
>
>> I can no longer reproduce bug 1201679 with this build.
>>
>> gnome-control-center also needs updating (for moved gsettings keys and
>> similar) and gnome-shell needs a patch to be dropped. I am ready to
>> upload all three of these packages now.
> ubuntu-settings also needs an update for idle-dim-time.
That is just a simple key rename.
>
> Cheers,
>

On Tue, Sep 03, 2013 at 09:58:45AM -0000, Sebastien Bacher wrote:
> > ubuntu-settings also needs an update for idle-dim-time.
>
> what "idle-dime-time"? was there a key change there? is there any
> migration/did anyone grep the archive for other clients of the old key?

http://162.213.35.4/search?weighted=1&q=idle-dim-time

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Thanks Laney! Is the old configuration value migrated in some way?

'idle-dim-time' has not been user configurable for a long time (atleast back to 3.4).

it was 'idle-dim-battery' that became 'idle-dim' that was exposed in g-c-c.

Do you have a list of the remaining trivial Unity issues? I'm sorry nobody has helped you out on this yet; it's not for lack of caring but you'll understand that we have been a bit focused on touch stuff this cycle, and additionally it's always hard (even for us) to get people to look at issues that /are going/ to happen in the future when they aren't a problem now.

If you have such a list I can try and ask Unity guys to take a look.

I'm minded to accept this FFe (after going over the issues you've noticed) given that you have undertaken to care for any issues that pop up.

There aren't any known issues with the gnome-settings-daemon update.

I just filed bug 1221350 with a rough list of what still needs to be done for gnome-control-center 3.8.

I'm going to try that update tomorrow, what's the recommended source (ppa or vcs with custom build)? I can comment then, on whether I hit issues with it or not

I recommend you use https://launchpad.net/~darkxst/+archive/gsd38 for gnome-control-center and build gnome-settings-daemon from https://code.launchpad.net/~gnome3-team/gnome-settings-daemon/ubuntu since Tim's PPA doesn't have the latest changes.

No need to build from source now as Tim's PPA has been updated again.

On Thu, Sep 05, 2013 at 05:41:55PM -0000, Sebastien Bacher wrote:
> I'm going to try that update tomorrow, what's the recommended source
> (ppa or vcs with custom build)? I can comment then, on whether I hit
> issues with it or not

I noticed that the sleep-display-battery gsettings key is gone with 3.8.
ubuntu-system-settings started setting it. It'll have to be adjusted. I
think the interface is now to set both
org.gnome.desktop.session.idle-delay and
org.gnome.settings-daemon.plugins.power.sleep-display-{ac,battery}.

Otherwise, ACK conditional on Seb not finding any big issues in the next
two days (let's say by 2000 UTC Tuesday 10th). If it slips much further
than that then it'll be too close to release for me to be comfortable
any more.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

On 09/09/13 19:03, Iain Lane wrote:
> On Thu, Sep 05, 2013 at 05:41:55PM -0000, Sebastien Bacher wrote:
>> I'm going to try that update tomorrow, what's the recommended source
>> (ppa or vcs with custom build)? I can comment then, on whether I hit
>> issues with it or not
> I noticed that the sleep-display-battery gsettings key is gone with 3.8.
> ubuntu-system-settings started setting it. It'll have to be adjusted. I
> think the interface is now to set both
> org.gnome.desktop.session.idle-delay and
> org.gnome.settings-daemon.plugins.power.sleep-display-{ac,battery}.
It is now just

org.gnome.desktop.session.idle-delay

These 2 sleep-display keys have been removed.

org.gnome.settings-daemon.plugins.power.sleep-display-{ac,battery}.

>
> Otherwise, ACK conditional on Seb not finding any big issues in the next
> two days (let's say by 2000 UTC Tuesday 10th). If it slips much further
> than that then it'll be too close to release for me to be comfortable
> any more.
>

Testing that update, it seems mostly fine so far, I found a bug though: on a laptop, unplugged, configured to not suspend on lid close... close the lid used to lock the screen, it doesn't anymore with the update

Jeremy, seems you already uploaded ... what about the bug previously mentioned? That's a security issue and seems like it should have been investigated before upload :/

This bug was fixed in the package gnome-settings-daemon - 3.8.5-0ubuntu1

---------------
gnome-settings-daemon (3.8.5-0ubuntu1) saucy; urgency=low

  [ Tim Lunn ]
  * Refreshed patches
  * debian/patches:
    - fix_media_keys_on_unity.patch:
      Use legacy media keys keygrabber when running Unity
    - git_revert_remove_automount_helper.patch: bring back the automount
      helper, revert upstream commit and port to dbus session tracking.
    - fix_screenshots_on_unity.patch: bring back support for screenshots
      via gnome-screenshot when using unity.
    - ubuntu-lid-close-suspend.patch:
       Reimplement support for setting lid close suspend actions
    - ubuntu-fix-desktop-file.patch: Autostart in Unity too
    - fix_input_switching_on_unity.patch: Bring back support for input
      switching under Unity
    - 63_gnome_disable_background_plugin.patch: Disable loading
      of background plugin for GNOME session (LP: #1219148)

  * Dropped obsolete patches:
    - power-check-null-devices.patch, Dropped: Applied in new version
    - 51_lock_screen_on_suspend.patch, Superseded by handling this key
      in gnome-screensaver. With that, g-screensaver mirrors what's
      done in g-shell, and avoids patching settings-daemon.
  * gnome-settings-daemon.gsettings-override:
    - Update switch input source keys for 3.8

  [ Jeremy Bicha ]
  * New upstream release (LP: #1219486)
    - Two-finger scrolling enabled by default (LP: #1217166)
    - But use edge scrolling if two-finger scrolling isn't
      available (LP: #1221367)
    - Fix Super+Space switch-input-source shortcut in Unity (LP: #1201679)
  * debian/control.in:
    - Bump minimum glib, gsettings-desktop-schemas, gnome-desktop3, gtk,
      libpulse, and libwacom
    - Build-depend on librsvg2-dev
    - This update needs changes to gnome-control-center so break older
      versions
  * Refreshed patches
  * revert_background_dropping.patch:
    - Don't drop the background plugin yet, GNOME Fallback & Unity
      still need it (when Nautilus isn't handling the desktop)
  * Dropped obsolete patches:
    - bugzilla_segfault_dpms.patch: Applied in new version
    - 47_delay_pa_connect_to_idle.patch: Applied in new version
    - power-no-fallback-notifications.patch: Applied in new version
    - 60_unity_hide_status_icon.patch
    - 61_unity_use_application_indicator.patch
    - 63_unity_start_mounter.patch
    - logind_support.patch
    - and patches backported from 3.8
  * Disabled patch that need to be rewritten or dropped:
    - 48_register_client_before_idle_callbacks.patch
  * debian/patches/touchscreen_rotation.patch:
    - Updated with latest version from bugzilla
  * debian/patches/git_revert_hardcoded_input_methods.patch:
    - Add patch from git (and also applied in Fedora 19) to not hardcode
      input methods based on the current locale

  [ Rico Tzschichholz ]
  * debian/patches:
    - 16_use_synchronous_notifications.patch: Refreshed
 -- Jeremy Bicha <email address hidden> Mon, 09 Sep 2013 10:21:09 -0400

this patch will make sure we lock the screen when the lid is closed if we are not suspending.