dtb concatenation support

Bug #1223261 reported by Paolo Pisati
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
flash-kernel (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Since release 3.11 (actually 3.10 in some cases), kernel mandates a DTB tree to be available at boot time or it fails to boot on some boards (pandaboard in this case): to support this scenario, support for DTB concatenation was added to the Saucy/generic multiplatform kernel and the last missing bits was to teach flash-kernel how and when to attach a dtb tree to the kernel before flashing it - the attached patch achieves it adding two fields to the board database.

The two new fields are:

DTB-Kernel-Version: this is minimum kernel version after which we decide to concatenate a DTB - if the kernel version is below the version mentioned here, dtb won't be attached thus we can safely install the new flash-kernel version on a older kernel/installation - 3.5 omap4 desktop won't get dtb concatenation, while people using omap4 for server and thus updating to the latest kernel (3.11 in this case) will

DTB-Id: this is the dtb file that will be concatenated - while for panda there are at least 3 different DTBs, i tested the pandaes dtb variant with a wide range of hw revisions and it worked (tested on panda es, panda rev 4 and panda rev b1) - i'll follow up with another patch that does a run-time guessing of the correct hardware in case trouble arises

Last but not least, i had to add a new Panda entry to the board database because when you boot it with a dtb-enabled kernel, the 'Hardware' string in /proc/cpuinfo changes from 'OMAP4 Panda board' to 'Generic OMAP4 (Flattened Device Tree)'.

The attached patch is derived on the dtb-concatenation work available in the Debian repository (http://anonscm.debian.org/gitweb/?p=d-i/flash-kernel.git;a=commit;h=e7fc8e9ef6de21428acba96b8cec97744a46da6b).

Feel free to improve the shell code.

Tags: patch
Revision history for this message
Paolo Pisati (p-pisati) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "flash-kernel-dtbconcat.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Paolo Pisati (p-pisati) wrote :

rev453 of flash-kernel moved from parsing /proc/cpuinfo to using /proc/device-tree/model to determine the board name, and as a consequence the board name changed from "Generic OMAP4 (Flattened Device Tree)" to "TI OMAP4 PandaBoard" - refresh the patch accordingly.

Revision history for this message
Paolo Pisati (p-pisati) wrote :

take #3 - i noticed the get_machine_field() function doesn't care if there's another "Machine:" field in the same board definition block, and thus we can use it for aliases (eliminating the need to duplicate the entire block when the only difference is just in board name definition - dtb booting in fact just changed board name while the rest was identical) - this patch is a simplified version of the previous one, with no pandabartd duplication in db/all.db

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package flash-kernel - 3.0~rc.4ubuntu40

---------------
flash-kernel (3.0~rc.4ubuntu40) saucy; urgency=low

  * Apply patch from Paolo Pisati for appended DTB support (LP: #1223261)
 -- Adam Conrad <email address hidden> Thu, 19 Sep 2013 10:27:47 -0600

Changed in flash-kernel (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.