hexeditor crashed with SIGSEGV in __libc_start_main()

StacktraceTop:search (findnext=0) at windows.c:595
hexMode (in=23) at hexkeys.c:110
main (argc=<value optimized out>, argv=<value optimized out>) at main.c:32
__libc_start_main () from /lib/libc.so.6
_start ()

I have make a patch there solve the problem. The problem was: When searching for hex values the string containing the last search string was not set if the search was unsuccessful. 'Search next' either by selection in the search dialog or pressing CONTROL_N crash the program.

--

Jakob Hilmer

Here is a debdiff I created pulling in the latest sources as well as the patch Jakob posted. This is the first time I've tried to package something for Ubuntu so any help would be greatly appreciated. I used pbuilder targeting karmic & everything looked to build fine.

I went from v0.9.7-13 and patched the source to go to v0.9.7-14 and then applied the windows.c patch made by Jakob. So the debdiff contains a diff from v0.9.7-13 to v0.9.7-15. Is this correct?

I uploaded the new package to REVU and it can be viewed & commented on here http://revu.ubuntuwire.com/p/ncurses-hexedit

Hi,

I can't confirm the crash. Here's what I did:

1. Run hexeditor on a small file
2. ^W and choose "search for Hex bytes"
3. Enter a value not in the file and press enter, get "String not found", hit enter to clear that dialog.
4. Hit ^N, and nothing happens.

Can someone tell me what the correct steps are?

Thanks,

James

I was able to use your steps except substitute these for #4.

4. Hit ^W and choose "Find Next"
It should seg fault but all the colors of the app will still be covering the terminal. Let me know if that works.

Steve

Bug (segfault) Confirmed in Karmic on i386 using
ncurses-hexedit 0.9.7-14 and Stephen's updated
step 4.

Stephen: Now there is a 0.9.7-14 pacakge in Karmic, it
would be good if you could create a debdiff from that,
which will *only* contain your change for this bug,
not other unrelated changes going from 0.9.7-13 to 0.9.7-14.

BTW, REVU is not really needed/wanted for changes to
existing packages, it is intended for new packages of
software that until now did not have packages in Ubuntu.

A debdiff against the current package is what is needed for
bug fixes like this one.

Thanks,

Jonathan

That sounds fine. I'll work on making the debdiff. Thanks for
the info about REVU and what to do in this situation. That helps
a lot. Should I assign this bug to myself?

Steve

Here is the debdiff from the latest karmic sources. The only
part that looked a little odd to me was the config.log file that
was generated and included in the debdiff. I'm not sure if that
should be included or not. Let me know if this debdiff will
work. Thanks.

Uploaded, thanks for your work here. Please forward the patch to Debian so that we can sync in future. See [0] for more information.

[0] https://wiki.ubuntu.com/Debian/Bugs

Oh, had to change the release to 'karmic'. We can't upload to Jaunty now.

This bug was fixed in the package ncurses-hexedit - 0.9.7-14ubuntu1

---------------
ncurses-hexedit (0.9.7-14ubuntu1) karmic; urgency=low

  * src/windows.c: Fixes a crash which was caused by searching for
    values that were not in the file being viewed.
    Thanks to Jakob Hilmer for the patch. (LP: #122349)

ncurses-hexedit (0.9.7-14) unstable; urgency=low

  * New Maintainer. (Closes: #419075)
  * Added patch from Eduardo Pérez Ureta <email address hidden>
    to correct programing error in search.c (Closes: #484056).
  * update docs/hexeditor.1 and remove docs/hexedit.1 (Closes: #510952)
  * Conforms to Standards version 3.8.0

 -- Stephen Burke <email address hidden> Sat, 04 Jul 2009 12:19:11 -0500

No problem on helping out. I sumitted the bug & patch to debian and added the URL for the debian bug at the top of this report. Glad to see it get into karmic.

Thanks
Steve