Regression: some previous keyboard bindings & all newly created custom bindings fail if gnome-screensaver isn't installed

Bug #1237564 reported by Doug McMahon
28
This bug affects 8 people
Affects Status Importance Assigned to Milestone
gnome-settings-daemon (Ubuntu)
Fix Released
Low
Iain Lane

Bug Description

[ Description ]

gnome-settings-daemon 3.8.5-0ubuntu7 used the presence of org.gnome.ScreenSaver on the session bus to decide whether to activate the media keys plugin (used for volume up/down, skipping tracks, brightness and so on).

This package is only a Recommends of ubuntu-desktop. It's an undeclared dependency which isn't actually necessary.

[ Proposed fix ]

Check for org.gnome.Panel (for gnome-panel environments) and com.canonical.Unity (for Unity environments). Unity also provides org.gnome.Shell so check $DESKTOP_SESSION in that handler to only run in a real gnome-shell session.

[ Test case ]

Remove the gnome-screensaver package. In a gnome-panel based or a Unity session, launch gnome-settings-daemon. Make sure your media keys work with the update.

[ Regression potential ]

This changes activation of a plugin. There's a chance it could be wrong.

If it doesn't work, make sure the plugin is enabled:

  $ gsettings get org.gnome.settings-daemon.plugins.media-keys active

and then run

  $ gnome-settings-daemon --debug --replace | tee /tmp/g-s-d.log

wait 5 seconds, try pressing some media keys, then attach /tmp/g-s-d.log

[ Original report ]

With the latest g-s-d any custom key-bindings fail as do some 'default* ones (system
Test cases -
remove gnome-screensaver

open keyboard panel > shortcuts> system
change Log out to a new binding
log out/in thru indicator-session
Try the new binding, nothing happens

open keyboard panel > shortcuts> custom
create a new binding for some command
log out/in
use binding, nothing happens

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: gnome-settings-daemon 3.8.5-0ubuntu7
ProcVersionSignature: Ubuntu 3.11.0-11.17-generic 3.11.3
Uname: Linux 3.11.0-11-generic x86_64
ApportVersion: 2.12.5-0ubuntu1
Architecture: amd64
Date: Wed Oct 9 14:03:35 2013
InstallationDate: Installed on 2013-10-03 (6 days ago)
InstallationMedia: Ubuntu 13.10 "Saucy Salamander" - Beta amd64 (20131002)
MarkForUpload: True
SourcePackage: gnome-settings-daemon
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Doug McMahon (mc3man) wrote :
summary: - Regression: some previous keyboard bindings & all newly created
+ Regression: some previous keyboard bindings & all newly created custom
bindings fail
Revision history for this message
Doug McMahon (mc3man) wrote : Re: Regression: some previous keyboard bindings & all newly created custom bindings fail

Seems to be the result of -
[ Ikuya Awashiro ]
  * debian/patches/series:
    - removed git_revert_hardcoded_input_methods.patch.
     - Hard coded input methods required for some language. (lp: #1230265)

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report, I can't confirm that though. The ctrl-alt-l keybinding doesn't work, but downgrading gnome-settings-daemon to 3.8.5-0ubuntu6 doesn't make it work either. How did you test those versions exactly?

Changed in gnome-settings-daemon (Ubuntu):
importance: Undecided → Low
status: New → Incomplete
Revision history for this message
Doug McMahon (mc3man) wrote :

Hmm, you're correct, ctrl+alt+l doesn't work with prev. version either or any lock screen binding.. though currently lock screen doesn't work here at all anyway.

So try this -
open keyboard panel > shortcuts > custom
Set a custom shortcut(s), log out/in & try it
Ex. here -
command of gedit, binding of ctrl+alt+f
log out/in & try

Or as mentioned in keyboard panel go shortcuts > system & try to set a binding for log out

It seems that when downgrading or using g-s-d with commit reverted (patch re-applied), that one needs to reset any *current* custom binding for them to work (can use same binding
It also seems that after setting a binding a log out/in may be required with 3.8.5-0ubuntu6

So to test custom bindings I set 4 as in screen, all work with 3.8.5-0ubuntu6 (after resetting & a log out/in), none work with 3.8.5-0ubuntu7, ever

description: updated
Revision history for this message
Doug McMahon (mc3man) wrote :

smaller screenshot

Revision history for this message
Doug McMahon (mc3man) wrote :

Well I put up a fresh install from a couple of day ols image, updated & everything works fine inc ctrl+alt+l to lock the screen
If I can figure the difference between the 2 installs then I'll mark as new, otherwisevwill invalidate

Revision history for this message
Doug McMahon (mc3man) wrote :

It seems the issue with custom key binding & the 2 system key bindings is that with the new g-s-d 'gnome-screensaver' has to be installed. (ctrl+alt+l makes sense, the rest doesn't

Considering it's not a dep of ubuntu-desktop then maybe this is a bug, maybe not..?

Changed in gnome-settings-daemon (Ubuntu):
status: Incomplete → New
summary: Regression: some previous keyboard bindings & all newly created custom
- bindings fail
+ bindings fail if gnome-screensaver isn't installed
Doug McMahon (mc3man)
description: updated
Revision history for this message
Iain Lane (laney) wrote : Re: [Bug 1237564] Re: Regression: some previous keyboard bindings & all newly created custom bindings fail if gnome-screensaver isn't installed

On Tue, Oct 15, 2013 at 06:59:22AM -0000, Doug McMahon wrote:
> ** Description changed:
>
> With the latest g-s-d any custom key-bindings fail as do some 'default* ones (system
> Test cases -
> + remove gnome-screensaver
> +

That's right - in the latest gnome-settings-daemon we use the
running/not running status of gnome-screensaver to decide whether to
launch the media-keys plugin.

I'm trying to see if we can avoid this, but in the meantime (and for
Saucy release, since we're so close), you should keep gnome-screensaver
installed to get media keys working.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Iain Lane (laney) wrote :

Please try the gnome-settings-daemon from ppa:laney/experimental

Revision history for this message
Doug McMahon (mc3man) wrote :

On 10/15/2013 07:24 AM, Iain Lane wrote:
> Please try the gnome-settings-daemon from ppa:laney/experimental
>
That works fine for the off chance that gnome-screensaver is removed

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-settings-daemon (Ubuntu):
status: New → Confirmed
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

I can confirm the problem, I was testing out light-locker, which I had to remove the gnome-screensaver and my media keys no longer worked.

I can also confrim Laney's ppa fixes the issue for me.

Revision history for this message
Iain Lane (laney) wrote :

Uploaded to saucy-proposed. It'll probably miss the release but should get in as a stable update, hopefully.

description: updated
Changed in gnome-settings-daemon (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Iain Lane (laney)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 3.8.5-0ubuntu8

---------------
gnome-settings-daemon (3.8.5-0ubuntu8) saucy; urgency=low

  * debian/patches/fix_media_keys_on_unity.patch: Don't rely on
    org.gnome.ScreenSaver as this might not be available (it's only a
    recommends of ubuntu-desktop). Use the names owned by (critical components
    of) the DEs themselves instead. (LP: #1237564)
 -- Iain Lane <email address hidden> Wed, 16 Oct 2013 09:39:12 +0100

Changed in gnome-settings-daemon (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Crazywater (crazytofire) wrote :

Could it be that this change broke the media keys in other environments? For example, I am running gnome-settings-daemon in i3 and media keys are not working anymore.

This would be a regression of the patch introduced in 3.8.5-0ubuntu7, https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1235625

Revision history for this message
Iain Lane (laney) wrote :

Yes, that's likely. I'll take patches to activate this plugin in other environments if they're provided. Follow the logic that we've used for gnome-panel.

Revision history for this message
Spyou (nicolas-alpi) wrote :

Any chance someone could help me having the media / shortcuts key working again on Openbox in 13.10?

Revision history for this message
Iain Lane (laney) wrote :

I reworked the patch again. gnome-settings-daemon in trusty shouldn't rely on anything else to enable this, and I'll try to upload to Saucy once the update currently in progress clears out.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.