[MIR] build dependencies for python-django-compressor

For python-django-discover-runner... Is it really needed? In its code, it has the following:

if not django.VERSION[:2] < (1, 6):
    raise ImproperlyConfigured("You are using Django >= 1.6 which comes "
                               "with an own version of the discover test "
                               "runner. Please remove 'discover_runner' "
                               "from the INSTALLED_APPS and TEST_RUNNER "
                               "settings and use the official runner instead.")

And the version of python-django in trusty is 1.6. So it sounds like the python-django-discover-runner build-dep should be dropped.

Likewise, the dep on python-beautifulsoup should be switched to python-bs4. So I'll open a task for python-django-compressor on this bug to drop the python-django-discover-runner dep and switch the beautiful soup dep.

As for html5lib, it seems fine packaging wise, and uses python-lxml to do the actual input parsing, so no new security issues there. But it has tests intentionally disabled. I looked at enabling them real quick, and in the runtests.py file, looks like we should add a check for if the module has a function called buildTestSuite. If not, we should just run suite.addTest(unittest.defaultTestLoader.loadTestsFromModule()) ourselves.

But after that change, I was still running into some issues. Can someone that wants this new version of django-compressor look and see if we can at least enable some of the tests or fix the problems in the suite?

Michael

I've dropped the dependency on discover-runner; however the impact of the switch from beautifulsoup -> bs4 extends into lxml as well so need a more co-ordinated approach.

Urgh - in actual fact the test suite for python-django-compressor being executed and ignored for failures; this was not done in the previous Ubuntu version.

...

Debian experimental has a newer version of html5lib - looking to sync that (it has tests enabled).

Availability: Currently in universe
Rationale: Dependency for python-compressor.
Security: No security history.
Quality Assurance: Package works out of the box with no prompting. There is no major bugs in Ubuntu and the is no major bugs in Debian.
Standards Compliance: FHS and Debian Policy compliant.
Maintenance: Simple python package that the Ubuntu Server Team will take care of.
Dependencies: All are in main

OK, latest version of html5lib nicely runs tests. Thanks!

python-django-compressor still needs to the conversion to beautifulsoup4

(base)adconrad@cthulhu:~$ change-override -c main -t html5lib
Override component to main
html5lib 0.999-2 in trusty: universe/python -> main
Override [y|N]? y
1 publication overridden.
(base)adconrad@cthulhu:~$ change-override -c main python-html5lib
Override component to main
python-html5lib 0.999-2 in trusty amd64: universe/python/optional/100% -> main
python-html5lib 0.999-2 in trusty arm64: universe/python/optional/100% -> main
python-html5lib 0.999-2 in trusty armhf: universe/python/optional/100% -> main
python-html5lib 0.999-2 in trusty i386: universe/python/optional/100% -> main
python-html5lib 0.999-2 in trusty powerpc: universe/python/optional/100% -> main
python-html5lib 0.999-2 in trusty ppc64el: universe/python/optional/100% -> main
Override [y|N]? y
6 publications overridden.

This bug was fixed in the package python-django-compressor - 1.3-1ubuntu3

---------------
python-django-compressor (1.3-1ubuntu3) trusty; urgency=medium

  * d/control: Drop python-beautifulsoup from BD's (LP: #1252627), its
    only required to run tests and is a optional parser at runtime.
  * d/rules: Correct path for django-admin.py so tests actually run,
    even if the result is ignored.
 -- James Page <email address hidden> Fri, 07 Mar 2014 13:09:39 +0000