fwts: should be able to specify the ACPI RSDP if it cannot be autodetected or scan the kernel log

Bug #1260400 reported by Colin Ian King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Firmware Test Suite
Fix Released
High
Colin Ian King

Bug Description

It would be a useful feature to be able to specify the ACPI RSDP if it cannot be automatically detected. So far, testing on an ACPI enabled device where the RSDP cannot be found, fwts can't run any ACPI specific tests.

It would be therefore useful to:

1. Scan the kernel log for any kernel references to the RSDP address

2. Be able to specify the RSDP using an -R or --rsdp option

Since this is based on parsed data that is open to abuse, we should also:

1. Sanity check the RSDP is on a 16 byte boundary
2. Contains a valid header

Revision history for this message
Colin Ian King (colin-king) wrote :

Tested on x86 32 + 64 as well as ARM 64 dev kit.

Changed in fwts:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Colin King (colin-king)
Revision history for this message
Colin Ian King (colin-king) wrote :
Alex Hung (alexhung)
Changed in fwts:
status: In Progress → Fix Committed
Revision history for this message
Colin Ian King (colin-king) wrote :

Commit 94ea2aa606a8115325e5c5781a958c4eb9ce856b

Ivan Hu (ivan.hu)
Changed in fwts:
milestone: none → 14.01.00
Alex Hung (alexhung)
Changed in fwts:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.