Ubuntu
ristretto package

Sorting by date or name not working properly in thumbnail bar

Bug #1270894 reported by Karim Rekik
30
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Ristretto
Fix Released
Medium
ristretto (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Sorting by date or name works properly for main window but not in thumbnail bar.

Ristretto 0.6.3
Xubuntu 14.04 daily (on January 20, 2014)
VirtualBox

To reproduce:
1) Open an image from a folder containing multiple images
2) Go to edit , sort by date

Expected action: thumbnails are rearranged according to date
What happens: focus jump to another place but order of thumbnails is unchanged. In main windows going to next image works as expected (date order). Selected a thumbnail displays a different image in main window.

See original description
Revision history for this message
In , b3nmore (b3nmore) wrote :

When changing the sorting order from file name to date (or vice versa), the thumbnails are no longer in sync with the displayed images: the position of the thumbnail (in the sense of a link to the images) represents the correct order but the thumbnail image itself, shows a complete unrelated picture.
After restarting ristretto the thumbnails are displayed correctly again.
I see this issue with ristretto 0.6.3.

Revision history for this message
Ubuntu QA Website (ubuntuqa) wrote :

This bug has been reported on the Ubuntu Package testing tracker.

A list of all reports related to this bug can be found here:
http://packages.qa.ubuntu.com/qatracker/reports/bugs/1270894

tags: added: package-qa-testing
Pasi Lallinaho (knome)
Changed in ristretto (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
Pasi Lallinaho (knome)
description: updated
Revision history for this message
Steve Dodier-Lazaro (sidi) wrote :

This bug is rather hard to fix. It seems that when the image list is re-sorted, it seems it forgets to inform the tree model that actually draws the icons.

I've tried to fix it but it seems I got the size of the tree model wrong, and I also suspect some bugs in the reordering handler of the custom tree model. Pasi, is the original dev still around by any chance?

Bug Watch Updater (bug-watch-updater)
Changed in ristretto:
importance: Unknown → Medium
status: Unknown → Confirmed
Revision history for this message
Steve Dodier-Lazaro (sidi) wrote :

I've written some code that exposes a reordered signal to Ristretto when the list is reordered. I've fixed some segfault-causing issue in the reordering handler. I still have some issues: the reordering goes wild!

In particular:
- the order when the app is launched is exactly the contrary to the order when
- it seems to me the order goes wild at some point... I'm suspecting the way I write the ordering in the image list!

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Partial patch (not enough to fix bug)" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount)
tags: removed: patch
Manjunath (manjubadiger722)
Changed in ristretto (Ubuntu):
assignee: nobody → Manjunath (manjubadiger722)
Revision history for this message
Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount) wrote :

Manjunath, do you intend to work on the unfinished patch and therefore fix the bug?

Manjunath (manjubadiger722)
Changed in ristretto (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Manjunath (manjubadiger722) wrote :

thanks for the information thaddaus I will be informing on the status of the bug

Revision history for this message
Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount) wrote :

Manjunath, any news or progress? If you manage to fix this bug, please share your patch and forward it to the linked upstream report also. Thanks.

Changed in ristretto (Ubuntu):
status: In Progress → Confirmed
assignee: Manjunath (manjubadiger722) → nobody
Revision history for this message
In , Gitbot (gitbot) wrote :

Igor referenced this bugreport in commit 812cc0ffb0a686167f4b005e42e22c4156ffe889

Update thumbnail bar on changing the sorting order

https://git.xfce.org/apps/ristretto/commit?id=812cc0ffb0a686167f4b005e42e22c4156ffe889

Bug Watch Updater (bug-watch-updater)
Changed in ristretto:
status: Confirmed → Fix Released
Revision history for this message
Sean Davis (bluesabre) wrote :

Resolved in ristretto 0.8.5. This or a newer version can be found in Ubuntu since at least 20.04.

Changed in ristretto (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.