Ubuntu
apport package

changing MarkForUpload to _MarkForUpload causes crashes never to be uploaded to errors.ubuntu.com

Bug #1272505 reported by Brian Murray
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Fix Released
Critical
Martin Pitt
Trusty
Fix Released
Critical
Martin Pitt

Bug Description

bzr revision number 2272 (apport package version 2.13-0ubuntu1) included the following change:

+ * apport/ui.py: Rename "MarkForUpload" whoopsie hack field to
+ "_MarkForUpload" and remove delta from launchpad.py. Fields starting with
+ '_' are now considered private.

This has the unfortunate side effect of causing .upload files never to be created by apport as the end of collect_info contains the following:

        # drop internal/uninteresting keys, that start with "_"
        for k in list(self.report):
            if k.startswith('_'):
                del self.report[k]

and the check for '_MarkForUpload' occurs after collect_info (lines 323-325 of apport/ui.py).

Brian Murray (brian-murray)
Changed in apport (Ubuntu Trusty):
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → Martin Pitt (pitti)
Brian Murray (brian-murray)
summary: - chaning MarkForUpload to _MarkForUpload causes crashes never to be
+ changing MarkForUpload to _MarkForUpload causes crashes never to be
uploaded to errors.ubuntu.com
Martin Pitt (pitti)
Changed in apport (Ubuntu Trusty):
status: Triaged → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Fixed in trunk r2760.

Changed in apport (Ubuntu Trusty):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.13.2-0ubuntu2

---------------
apport (2.13.2-0ubuntu2) trusty; urgency=medium

  * Merge from trunk:
    - Fix backend_apt_dpkg.test_get_file_package_uninstalled test that got
       broken in the previous release.

apport (2.13.2-0ubuntu1) trusty; urgency=medium

  * New upstream bug fix release:
    - Fix crash if systemd cgroup is unreadable in /sys, such as in
      containers. (LP: #1270783)
    - apt/dpkg: Also consider Contents.gz from updates/security/proposed
      pockets, so that e. g. apport-retrace works for crash reports with files
      that are new in those. Thanks to Brian Murray for the initial patch.
      (LP: #1271258)
    - Only drop internal/private keys (starting with '_') from uploading to
      the crash DB and from the UI report views, but not already when updating
      the report. (LP: #1272505)
    - data/apport: Fix stdout/stderr initialization of the error log, don't
      close the original fd after dup2'ing as it is usually already fd 1. This
      makes Apport work with Python 3.4. (LP: #1272355)
    - Adjust report tests to work with Python 3.4 (LP: #1272355)
 -- Martin Pitt <email address hidden> Mon, 27 Jan 2014 15:21:06 +0100

Changed in apport (Ubuntu Trusty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.