/usr/sbin/lightdm:11:__GI__IO_fread:fread:kwallet_hash:pam_sm_authenticate:_pam_dispatch_aux

Bug #1314120 reported by errors.ubuntu.com bug bridge
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pam-kwallet (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
Fix Released
High
Harald Sitter
Utopic
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

When not being able to open the wallet salt file pam-kwallet would crash because null fds were not being handled correctly. Salt creation is now correctly apported when an fopen fails.

[Test Case]

* Create a user A
* Login
* Run kwalletmanager
* Delete any existing wallets
* Create a new wallet and give it a password different from the user password

* Upgrade pam-kwallet
* Reboot

* Log in as user A
* Login is supposed to work
* Run kwalletmanager
* Confirm the wallet is still there
* Confirm the wallet password is the one you set it to (either open the wallet via kwalletmanager or an application might prompt you to unlock the wallet)

* Create a user B
* Do not log in
* Reboot

* Log in as user B
* Login is supposed to work
* Run kwalletmanager
* Confirm that a wallet was automatically created
* Confirm that the wallet is unlocked without you having to enter your password again anywhere
* Close the wallet via kwalletmanager
* Open the wallet via kwalletmanager
* Confirm that the required password is the same password as the login password

* Log out from user B
* Do not reboot
* Login as user B
* Run kwalletmanager
* Confirm the wallet is again opened automatically

* Logout from user B
* Do not reboot
* Login as user A
* Run kwalletmanager
* Confirm the wallet is still not automatically unlocked
* Confirm the password is still the password you manually defined

[Regression Potential]

Login could be broken.

[Other Info]

N/A

----

The Ubuntu Error Tracker has been receiving reports about a problem regarding lightdm. This problem was most recently seen with version 1.10.0-0ubuntu3, the problem page at https://errors.ubuntu.com/problem/28ad0356a00142a5ec12fb842f15e18f3fae1a63 contains more details.

affects: lightdm (Ubuntu) → pam-kwallet (Ubuntu)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pam-kwallet - 0.0~git20140429-0ubuntu1

---------------
pam-kwallet (0.0~git20140429-0ubuntu1) utopic; urgency=medium

  * New git snapshot resolving some possible crashers and adding more logging
    UBUNTU-ERROR: 30e961156f64c241b58a65ecbb009688e3aeb2ec
    LP: #1314118
    UBUNTU-ERROR: ae1ef304fcd7d26e215563c4c95fcb25a74a6559
    LP: #1314119
    UBUNTU-ERROR: 28ad0356a00142a5ec12fb842f15e18f3fae1a63
    LP: #1314120
  * Dropping upstream_Allocate-one-more-byte-for-slash.patch, applied in this
    snapshot
 -- Harald Sitter <email address hidden> Tue, 29 Apr 2014 11:32:18 +0200

Changed in pam-kwallet (Ubuntu Utopic):
status: New → Fix Released
Changed in pam-kwallet (Ubuntu Trusty):
status: New → Triaged
importance: Undecided → High
assignee: nobody → Harald Sitter (apachelogger)
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello errors.ubuntu.com, or anyone else affected,

Accepted pam-kwallet into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/pam-kwallet/0.0~git20140410-0ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in pam-kwallet (Ubuntu Trusty):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Rohan Garg (rohangarg) wrote :

I can confirm that the test case in the bug report passes

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pam-kwallet - 0.0~git20140410-0ubuntu2.1

---------------
pam-kwallet (0.0~git20140410-0ubuntu2.1) trusty; urgency=medium

  * Import upstream patch set to improve reliability and debugability:
    + upstream_Removed-not-needed-strdup.patch
      Remove an unnecessary strdup.
      UBUNTU-ERROR: 30e961156f64c241b58a65ecbb009688e3aeb2ec
      LP: #1314118
    + upstream_If-we-fail-creating-a-directory-log-it-into-syslog.patch
      Adds logging on directory creation failure
    + upstream_If-we-can-t-open-the-file-where-salt-will-be-saved-f.patch
      If the salt file cannot be opened, fail properly instead of running
      into nullptr fd crashes
      UBUNTU-ERROR: ae1ef304fcd7d26e215563c4c95fcb25a74a6559
      LP: #1314119
    + upstream_If-kwallet_hash-fails-return-with-PAM_IGNORE.patch
      When hash creation fails, fail properly instead of allowing for crashes
      later on.
    + upstream_Add-more-checks-against-null-fd.patch
      Adding nullptr checks after selected fopen() and mallocs
      UBUNTU-ERROR: 28ad0356a00142a5ec12fb842f15e18f3fae1a63
      LP: #1314120
    + upstream_Replace-fprintf-with-syslog-and-add-some-extra-ones.patch
      Prefering syslog over fprintf and adding more logging on failure
 -- Harald Sitter <email address hidden> Tue, 29 Apr 2014 11:12:58 +0200

Changed in pam-kwallet (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for pam-kwallet has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.