Gtkterm spews warnings on emulated serial ports

Bug #132393 reported by Adrian Cox
8
Affects Status Importance Assigned to Milestone
GTKTerm
Unknown
Unknown
gtkterm (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: gtkterm

Some emulated serial ports (such as USB ACM modems, and user-space ports implemented using ptys) return EINVAL to the TIOCMGET ioctl. Gtkterm produces a warning every few seconds when connected to one of these ports. I've been using this patch in-house to suppress the message, and I'd like it to move upstream.

--- gtkterm-0.99.5.orig/src/serie.c
+++ gtkterm-0.99.5/src/serie.c
@@ -389,7 +389,9 @@
     {
       if(ioctl(serial_port_fd, TIOCMGET, &stat_read) == -1)
        {
- i18n_perror(_("Control signals read"));
+ /* Ignore EINVAL, as some serial ports genuinely lack these lines */
+ if (errno != EINVAL)
+ i18n_perror(_("Control signals read"));
          return -2;
        }

Related branches

Daniel T Chen (crimsun)
Changed in gtkterm:
importance: Undecided → Wishlist
Revision history for this message
James Westby (james-w) wrote :

Hi,

Joseph has provided a debdiff to fix this issue:

  http://launchpadlibrarian.net/19828800/debdiff

Thanks,

James

Revision history for this message
James Westby (james-w) wrote :

Hi,

Upstream doesn't look that active, but I think we should
wait a little while to see if they respond to the patch.

Sending the patch to Debian for the Debian maintainer's
consideration would also be good.

Thanks,

James

Revision history for this message
Daniel Holbach (dholbach) wrote : Unsubscribing Sponsors.

I'm unsubscribing the Sponsors' Team for now. Please re-subscribe when ready.

Revision history for this message
David Stansby (dstansby-deactivatedaccount) wrote :

Seems like that latest upstream activity for this package was around 2005, and the last release in ubuntu from upstream was early 2007. Would it be best to get the patch applied in debian, then sync it over, or just apply the patch here?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtkterm - 0.99.5-1ubuntu3

---------------
gtkterm (0.99.5-1ubuntu3) karmic; urgency=low

  * Don't print lots of warnings if the serial port doesn't have all the lines,
    e.g. if emulated. (LP: #132393)

 -- Joseph Smidt <email address hidden> Thu, 20 Nov 2008 22:30:49 -0800

Changed in gtkterm (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.