MAAS fires 5 tasks to write_dhcp_config when only one nodegroup change was made
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Raphaël Badin | ||
1.5 |
Fix Released
|
Critical
|
Raphaël Badin | ||
maas (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
It was observed in http://
This coupled to the fact that celery is not executing the tasks FIFO (see bug 1324943) seem to have a caused a race condition where the dhcp config done through the CLI is overwritten by a previous tasks.
[Impact]
* Remove possible race condition that might cause changes to dhcpd.conf to be lost when stopping dhcpd
[Testcase]
* Install maas and run included test test_stop_
[Regression Potential]
* Minimal -- simply write blank config instead of invalid configs and only once
Related branches
- Gavin Panella (community): Approve
-
Diff: 131 lines (+36/-17)4 files modifiedsrc/maasserver/dhcp.py (+10/-1)
src/maasserver/tests/test_dhcp.py (+13/-14)
src/provisioningserver/tasks.py (+9/-1)
src/provisioningserver/tests/test_tasks.py (+4/-1)
- Raphaël Badin (community): Approve
-
Diff: 131 lines (+36/-17)4 files modifiedsrc/maasserver/dhcp.py (+10/-1)
src/maasserver/tests/test_dhcp.py (+13/-14)
src/provisioningserver/tasks.py (+9/-1)
src/provisioningserver/tests/test_tasks.py (+4/-1)
Changed in maas: | |
milestone: | none → 1.6.0 |
Changed in maas: | |
milestone: | 1.6.0 → none |
Changed in maas: | |
assignee: | nobody → Raphaël Badin (rvb) |
status: | Triaged → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
Changed in maas (Ubuntu): | |
status: | New → Fix Released |
Changed in maas (Ubuntu Trusty): | |
status: | Fix Released → In Progress |
Part of the problem here is that MAAS generates a DHCP config even when there is no interface configured. Worse: when there is no interface configured, the config it generates it invalid.