juju-core does not depend on distro-info

Bug #1325025 reported by Robie Basak
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core (Ubuntu)
Fix Released
High
Robie Basak
Trusty
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

Juju in a particular release is expected to deploy future releases unless something fundamental has changed about them. Without having distro-info installed, a user would need to wait for an SRU to juju-core's hardcoded defaults, which we don't want to have to do.

[Development Fix]

Depend on distro-info. Juju automatically sees this and uses its information over its hardcoded defaults (which are necessary on other platforms that do not have distro-info available).

[Stable Fix]

Same as development fix.

[Test Case]

There isn't really one currently that can effectively be executed manually, since it involve waiting for a new release. However, there are now dep8 tests which pretend that a future release exists and that Juju works on them. These should be verified to pass. The catch is that for a Trusty SRU, Utopic exists, of course, and Juju 1.18.4 already knows about it. On balance, I think that if the dep8 "future" tests succeed, then this is sufficient to have confidence that Utopic+1 will also work.

[Regression Potential]

A Juju user who previously did not have distro-info installed will switch Juju's source of knowledge of distribution releases. This could cause a change in behavior.

[Original Description]

juju uses distro-info-data to understand what Ubuntu releases exist, falling back to its own knowledge if it is not available. When we open a new development release, the version of juju-core that is copied forward does not know about the release, causing juju-core such as in bug 1314686.

As we work to eliminate these bugs, so that juju-core does not have release names hardcoded, we should also make sure that distro-info-data is always available to juju, so that as we open new releases, juju-core will automatically learn about and be able to use them without having to change juju-core itself.

So we should add a dependency of distro-info (or -data) to juju-core.

Robie Basak (racb)
Changed in juju-core (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Robie Basak (racb)
Revision history for this message
Robie Basak (racb) wrote :

Stuck in utopic-proposed due to bug 1329295.

Changed in juju-core (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package juju-core - 1.18.4-0ubuntu1

---------------
juju-core (1.18.4-0ubuntu1) utopic; urgency=medium

  * New upstream release, including essential fixes for supporting Utopic and
    all future releases:
    - Support Utopic and future releases by using distro-info-data over
      hardcoded defaults (LP: #1314686).
    - Correctly use juju-mongodb on Trusty and all future releases, rather than
      hardcoding Trusty as special (LP: #1321025).
  * Depend on distro-info so that Juju can use its data in preference to
    hard-coded defaults (LP: #1325025).
  * d/tests/*:
    - Remove hardcoding of precise.
    - Use --upload-tools to reduce external dependencies on local and manual provider testing.
    - Add stderr logging.
    - New test for manual provider against localhost.
    - Mark tests breaks-testbed and isolation-machine so that they do not step on each other.
    - Add "future release" testing for both local and manual providers.
 -- Robie Basak <email address hidden> Fri, 06 Jun 2014 15:53:28 +0000

Changed in juju-core (Ubuntu):
status: Fix Committed → Fix Released
Robie Basak (racb)
description: updated
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Robie, or anyone else affected,

Accepted juju-core into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/juju-core/1.18.4+dfsg-0ubuntu0.14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in juju-core (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Robie Basak (racb) wrote :

"future" tests pass, and I see the dependency in place.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package juju-core - 1.18.4+dfsg-0ubuntu0.14.04.1

---------------
juju-core (1.18.4+dfsg-0ubuntu0.14.04.1) trusty; urgency=medium

  * New upstream bugfix release (LP: #1329302).
  * Repack with binary removed from source tarball. See
    debian/README.source for details.
  * Copy new and enhanced dep8 tests (d/tests/*) from Utopic packaging.
  * Add dependency on distro-info, so that Juju uses it for knowledge to deploy
    future releases instead of relying on its own hardcoded fallback
    (LP: #1325025).
 -- Robie Basak <email address hidden> Wed, 02 Jul 2014 16:45:07 +0000

Changed in juju-core (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for juju-core has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.