New push-helper hook is not supported
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Click Reviewers tools (obsolete) |
Fix Released
|
High
|
Jamie Strandboge | ||
qtcreator-plugin-ubuntu |
Invalid
|
Undecided
|
Unassigned |
Bug Description
When creating a click package with push notifications support, it needs to add a helper with its own hook and both the SDK and the click review tool get confused.
The manifest is something like this:
{
"name": "com.ubuntu.
"description": "description of hello",
"framework": "ubuntu-
"architecture": "all",
"title": "hello",
"hooks": {
"hello": {
},
}
},
"version": "0.2",
"maintainer": "Roberto Alsina <email address hidden>"
}
The click review tool will complain about missing desktop hooks for the push helper:
[15:59:18] <beuno> = hooks =
[15:59:18] <beuno> ERROR: could not find desktop hook for 'helloHelper'
[15:59:37] <beuno> "error": {
[15:59:38] <beuno> "lint_control_
[15:59:38] <beuno> "text": "found binaries for architecture 'all': lib/i386-
[15:59:40] <beuno> },
[15:59:43] <beuno> "lint_hooks": {
[15:59:45] <beuno> "text": "more than one app key specified in hooks"
[15:59:48] <beuno> }
[15:59:50] <beuno> },
[15:59:51] <beuno> ERROR: Could not load 'helloHelper-
And the SDK will complain about "The manifest file needs to specify if this is a app or a scope"
These are the new files mentioned in the manifest:
ralsina@
{
"exec": "helloHelper"
}
ralsina@
{
"policy_
],
"policy_
}
Related branches
- John Lenton (community): Approve
- Martin Albisetti (community): Approve
-
Diff: 790 lines (+539/-17)13 files modifiedbin/click-check-push-helper (+31/-0)
bin/click-run-checks (+4/-0)
bin/click-show-files (+13/-0)
clickreviews/cr_common.py (+2/-1)
clickreviews/cr_desktop.py (+5/-1)
clickreviews/cr_lint.py (+15/-5)
clickreviews/cr_push_helper.py (+132/-0)
clickreviews/cr_security.py (+44/-4)
clickreviews/cr_tests.py (+43/-1)
clickreviews/tests/test_cr_lint.py (+26/-4)
clickreviews/tests/test_cr_push_helper.py (+138/-0)
clickreviews/tests/test_cr_security.py (+84/-0)
debian/changelog (+2/-1)
description: | updated |
Changed in click-reviewers-tools: | |
status: | New → In Progress |
assignee: | nobody → Jamie Strandboge (jdstrand) |
importance: | Undecided → High |
Changed in click-reviewers-tools: | |
status: | Fix Committed → Fix Released |
Changed in qtcreator-plugin-ubuntu: | |
status: | New → Invalid |
The click in question