traceback in tests with improper cr_... file
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Click Reviewers tools (obsolete) |
Fix Released
|
Medium
|
Daniel Holbach |
Bug Description
Long ago I started on a cr_tests_real.py file, but it has been superseded. However, it is still in my filesystem and not committed to bzr. With it in place and recent commits to click-reviewers
test_number_
[('ClickReviewD
[('ClickReviewF
[('ClickReviewL
[('ClickReviewA
[('ClickReviewP
[('ClickReviewS
[('ClickReviewS
[]
ERROR
...
=======
ERROR: test_number_
-------
Traceback (most recent call last):
File "/home/
review = modules.
File "/home/
init_object = getattr(module, main_class[0][0])
IndexError: list index out of range
-------
Ran 229 tests in 0.724s
FAILED (errors=1)
Now, I could just remove the file, but I think modules.py should probably be more resilient-- especially when considering people trying to develop new checks, etc so as not to cause any confusion. Problematic file attached.
Related branches
- Jamie Strandboge (community): Approve
-
Diff: 80 lines (+19/-9)4 files modifiedbin/click-review (+6/-4)
clickreviews/modules.py (+7/-3)
clickreviews/tests/test_modules.py (+3/-1)
debian/changelog (+3/-1)
Changed in click-reviewers-tools: | |
assignee: | nobody → Daniel Holbach (dholbach) |
importance: | Undecided → Medium |
status: | New → In Progress |
Changed in click-reviewers-tools: | |
status: | In Progress → Fix Committed |
Changed in click-reviewers-tools: | |
status: | Fix Committed → Fix Released |