[needs-packaging] OFED Mellanox firmware burning application package mstflint is missing

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

------- Comment From <email address hidden> 2014-09-12 12:38 EDT-------
mstflint bug in Debian was accepted and it is already compiled for Debian. It should appear in Ubuntu soon.

------- Comment From <email address hidden> 2014-11-13 13:31 EDT-------
Just to be complete on Debian:
Package mstflint
wheezy (stable) (net): Mellanox firmware burning application
1.4-OFED-1.4.2-1: amd64 i386 ia64 powerpc

so the target ppc64el is not yet available

On Ubuntu:
The Vivid Vervet (active development)
Set upstream link
3.7.0+1.18.gcdb9f80-3 release (universe) 2014-10-25
The Utopic Unicorn (current stable release)
Set upstream link
3.7.0-1 release (universe) 2014-07-04
The Trusty Tahr (supported)
1.4-OFED-1.4.2-1 release (universe) 2013-10-18
The Precise Pangolin (supported)
1.4-OFED-1.4.2-1 release (universe) 2011-10-13
with
Builds

[FULLYBUILT] amd64
[FULLYBUILT] i386
[FULLYBUILT] powerpc

So the issue is just to have the platform being supported.

------- Comment From <email address hidden> 2014-12-09 14:56 EDT-------
According to Carol Soto on 12/08/2014, package the mstflint it ok.
So just enabling the ppc64le arch allow compilation and work.
Attaching the packages in case people need them

------- Comment (attachment only) From <email address hidden> 2014-12-09 14:59 EDT-------

------- Comment (attachment only) From <email address hidden> 2014-12-09 15:02 EDT-------

This package has built successfully in Debian, but the same version is failing to build in Ubuntu with the following error:

g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I../../include/mtcr_ul -I../../mflash -I../../ext_libs/json -I../../ext_libs/minixz -I../../common -I/zlib -I ../../tools_layouts -I../../common -I../../mft_utils -D_FORTIFY_SOURCE=2 -Wall -W -g -MP -MD -pipe -DNO_MFA_SUPPORT -g -O3 -fstack-protector-strong -Wformat -Werror=format-security -DHAVE_TERMIOS_H -Werror -DMST_UL -c -o fw_ops.o fw_ops.cpp
fw_ops.cpp: In member function 'bool FwOperations::ModifyImageFile(const char*, u_int32_t, void*, int)':
fw_ops.cpp:632:27: error: 'file_data' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     memcpy(&file_data[addr], data, cnt);
                           ^
fw_ops.cpp:650:35: error: 'file_size' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     if (fwrite(data, 1, length, fh) != length) {
                                   ^
fw_ops.cpp:626:9: note: 'file_size' was declared here
     int file_size;
         ^
cc1plus: all warnings being treated as errors
Makefile:300: recipe for target 'fw_ops.o' failed

https://launchpadlibrarian.net/193726658/buildlog_ubuntu-vivid-ppc64el.mstflint_3.7.0%2B1.18.gcdb9f80-3_FAILEDTOBUILD.txt.gz
https://launchpad.net/ubuntu/+source/mstflint/3.7.0+1.18.gcdb9f80-3/+build/6497168

This requires further investigation.

This build failure only occurs when building with -O3 - which is a default flag in Ubuntu for ppc64el, but evidently not in Debian.

Attached is a patch that fixes the build.

I'm not sure where to submit this patch upstream. The current package version clearly points to pulls from upstream git, but I don't find references to this upstream git in the source package or on the download site. Breno, do you know where this lives?

Patch also as debdiff.

------- Comment From <email address hidden> 2015-03-02 22:06 EDT-------
(In reply to comment #18)
Attached is a
> patch that fixes the build.

I'm not sure where to submit this patch
> upstream. The current package version clearly points to pulls from upstream
> git, but I don't find references to this upstream git in the source package
> or on the download site. Breno, do you know where this lives?

-------
> Comment From vorlon 2015-03-03 04:08:15 UTC-------
Patch also as debdiff.

The download site is usually from here: https://www.openfabrics.org/downloads/mstflint/
but not sure how patches work for this. If you can not find how to submit the patch, let me know I can try to see if I can find the Mellanox person that submit the tar files to this site. Thanks.

------- Comment From <email address hidden> 2015-03-11 21:43 EDT-------
Hi Steve.
By verifying this page http://downloads.openfabrics.org/downloads/MAINTAINERS
it's possible to see some information regarding that package.
Perhaps contacting the maintainer would give you a more accurate lead on where
to send the patch.

mstflint: Mohammad Sawalha <email address hidden>
http://www.openfabrics.org/downloads/mstflint/
git://git.openfabrics.org/~orenk/mstflint.git master

Regards.

------- Comment From <email address hidden> 2015-03-11 21:47 EDT-------
The info I added was provided by Carol Soto by the way. Thanks.

> git://git.openfabrics.org/~orenk/mstflint.git master

For the record this git repository only includes history through January 2014 (upstream version 3.5.0).

An up-to-date git branch appears to be git://git.openfabrics.org/~mohammads/mstflint.git

This bug was fixed in the package mstflint - 3.7.0+1.18.gcdb9f80-3ubuntu1

---------------
mstflint (3.7.0+1.18.gcdb9f80-3ubuntu1) vivid; urgency=medium

  * debian/patches/uninitialized-variables-O3.patch: Fix uninitialized
    variables when building with -O3. Closes LP: #1367842.
 -- Steve Langasek <email address hidden> Tue, 31 Mar 2015 19:19:41 -0700