Ubuntu
gnote package

gnote should't use GtkHeaderBar when not run under Gnome

Bug #1389720 reported by Marc Deslauriers
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnote (Ubuntu)
Fix Released
Undecided
Marc Deslauriers
Utopic
Fix Released
Undecided
Marc Deslauriers
Vivid
Fix Released
Undecided
Marc Deslauriers

Bug Description

SRU Request:
[Impact]
When run under Unity, gnote is using GtkHeaderBar which results in having a different look and behaviour than other applications, including having the close button on the right of the window title. This is confusing for users.

This has been fixed in vivid by using a similar approach to what is being done for Evince and other packages.

[Test Case]
1- Open gnote in Unity, see if it runs with normal window decorations
2- See if menus all look right
3- Open gnote in a Gnome session, see if it uses the client-side window decorations

[Regression Potential]
The fix is minimal, it simply doesn't set the GtkHeaderBar and uses the widget in the main window instead. Any regression should be visible immediately.

See original description
Marc Deslauriers (mdeslaur)
Changed in gnote (Ubuntu Utopic):
assignee: nobody → Marc Deslauriers (mdeslaur)
Changed in gnote (Ubuntu Vivid):
assignee: nobody → Marc Deslauriers (mdeslaur)
Changed in gnote (Ubuntu Utopic):
status: New → In Progress
Changed in gnote (Ubuntu Vivid):
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnote - 3.14.0-1ubuntu1

---------------
gnote (3.14.0-1ubuntu1) vivid; urgency=medium

  * debian/patches/unity_normal_titlebar.patch: Don't use GtkHeaderBar
    decoration when not running under GNOME in src/recentchanges.cpp.
    (LP: #1389720)
 -- Marc Deslauriers <email address hidden> Wed, 05 Nov 2014 09:35:32 -0500

Changed in gnote (Ubuntu Vivid):
status: In Progress → Fix Released
Marc Deslauriers (mdeslaur)
description: updated
Revision history for this message
John Johansen (jjohansen) wrote :

I can confirm the fix works for me and doesn't appear to have introduced any regressions

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Marc, or anyone else affected,

Accepted gnote into utopic-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gnote/3.12.0-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnote (Ubuntu Utopic):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

I've tested gnote 3.12.0-1ubuntu0.1 in utopic-proposed, and it works as expected.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnote - 3.12.0-1ubuntu0.1

---------------
gnote (3.12.0-1ubuntu0.1) utopic; urgency=medium

  * debian/patches/unity_normal_titlebar.patch: Don't use GtkHeaderBar
    decoration when not running under GNOME in src/recentchanges.cpp.
    (LP: #1389720)
 -- Marc Deslauriers <email address hidden> Wed, 05 Nov 2014 09:50:26 -0500

Changed in gnote (Ubuntu Utopic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnote has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.