Click review complains about internationalized ini files for scopes
Bug #1392133 reported by
Chris Wayne
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical Click Reviewers tools (obsolete) |
Fix Released
|
High
|
Jamie Strandboge | ||
Bug Description
Ini files in scopes are internationalized the same way as desktop files, i.e. inline, and click-review will give warnings of things like "Unknown attribute Description[es]. It also seems to crash on some non-ascii characters. For example, it outright fails this .ini file:
http://
Related branches
Revision history for this message
| Jamie Strandboge (jdstrand) wrote | #1 |
| Changed in click-reviewers-tools: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Jamie Strandboge (jdstrand) |
| Changed in click-reviewers-tools: | |
| status: | Triaged → Fix Committed |
| Changed in click-reviewers-tools: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Michał Karnicki (karni) wrote | #2 |
Revision history for this message
| Daniel Holbach (dholbach) wrote | #3 |
Revision history for this message
| Daniel Holbach (dholbach) wrote | #4 |
To post a comment you must log in.
We need to change the scope fields checks to use a regex instead of equality match.