evince aborts printing when window is closed during creation of print job

I have created a patch for this bug.

Evince was preparing the document for printing in a background job. This job was canceled when Evince was closed.
The patch solves this by
1) not canceling the print job when the document window is closed
2) hiding instead of deleting the document window, when there are still print jobs running.
(this is needed, because some printing code depends on the window)

Furthermore I found that printing setting may be associated with the wrong print job if the user prints the document multiple times with different settings within a short period of time (i.e. when the first print job is not finished yet). This is also fixed in this patch.

Additionally I changed the print job title from "evince_print" to the document name.

This is my first patch to an open source project, so tell me about my mistakes.

Thank you for your bug and your work. The patch changes the upstream code and would be better placed on bugzilla.gnome.org which the software hackers are using. Do you want to send your patch there for comment or do you prefer to have somebody from Ubuntu doing that?

I will send the patch myself.

Thank you!

Thanks, could you add a bug watch to the upstream bug once you have opened on gnome?

already done ;)

What is the status of this bug? It happened to me the last few days when printing very big PDF files that needed some time to process.

I'm wondering as well what the status is of this bug since i'm still experiencing it as well. And i even dont have very large documents (10 page artikels) or high cpu loads

the bug has been fixed upstream now

This bug was fixed in the package evince - 2.25.4-0ubuntu1

---------------
evince (2.25.4-0ubuntu1) jaunty; urgency=low

  * New upstream version:
    New Features and UI Improvements:
    - Show progress information when loading/saving remote files
      (lp: #273611)
    - Remember page setup options (lp: #224882)
    - Show a confirmation dialog when there are pending print jobs
      while closing the main window (lp: #139907)
    - Show progress information when printing (lp: #178437)
    - Add document URI to properties page
    Bug fixes:
    - Bump glib requirement to fix build with older versions
    - Fix mime type handling
    - Fix saving images to remote locations
    - Do not try to jump to the location of the find result for every match, but
      only for the first one. It makes searching really faster.
    - Fix zip mime-type in comics backend
    - Fix several memory leaks
  * debian/control.in:
    - updated build requirement

 -- Sebastien Bacher <email address hidden> Tue, 06 Jan 2009 09:56:51 +0100