cgmanager crashes on some errors

Bug #1407787 reported by Serge Hallyn
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cgmanager (Ubuntu)
Fix Released
High
Unassigned
Trusty
Fix Released
High
Unassigned
Utopic
Fix Released
High
Unassigned

Bug Description

Impact: Cgmanager can be made to crash by triggering one of a few asserts, or by an bad nih_dbus_error_raise call. Push the patches to fix this.

Test case: sudo cgm chmodfile freezer "" / 0

Regression potential: the fixes only stop calling nih_free on null values, and switch a nih_dbus_error to a nih_error. There should be no possibility for regression in these.

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

This is fixed in 0.34. For T and U I will cherrypick two patches, once 0.34 hits debian and vivid.

description: updated
description: updated
Changed in cgmanager (Ubuntu Trusty):
importance: Undecided → High
Changed in cgmanager (Ubuntu):
importance: Critical → High
Changed in cgmanager (Ubuntu Utopic):
importance: Undecided → High
information type: Private Security → Public
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Serge, or anyone else affected,

Accepted cgmanager into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/cgmanager/0.24-0ubuntu7.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in cgmanager (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed
Changed in cgmanager (Ubuntu Utopic):
status: New → Fix Committed
Revision history for this message
Chris J Arges (arges) wrote :

Hello Serge, or anyone else affected,

Accepted cgmanager into utopic-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/cgmanager/0.32-4ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in cgmanager (Ubuntu):
status: In Progress → Fix Released
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cgmanager - 0.24-0ubuntu7.2

---------------
cgmanager (0.24-0ubuntu7.2) trusty-proposed; urgency=medium

  * 0009-chown-stop-cgmanager-crash-on-chown-of-bad-file.patch - prevent
    cgmanager crashing on unhandled dbus error (LP: #1407787)
 -- Serge Hallyn <email address hidden> Mon, 05 Jan 2015 14:48:05 -0600

Changed in cgmanager (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for cgmanager has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cgmanager - 0.32-4ubuntu1.2

---------------
cgmanager (0.32-4ubuntu1.2) utopic-proposed; urgency=medium

  * 0008-chown-stop-cgmanager-crash-on-chown-of-bad-file.patch and
    0009-prevent-some-cgmanager-asserts.patch: prevent cgmanager
    crashing on unhandled asserts or dbus error (LP: #1407787)
 -- Serge Hallyn <email address hidden> Mon, 05 Jan 2015 14:53:11 -0600

Changed in cgmanager (Ubuntu Utopic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.