Ubuntu
liboobs package

correctly return error and emit warning

Bug #1411584 reported by Vlad Orlov
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
liboobs (Debian)
Fix Released
Unknown
liboobs (Ubuntu)
Fix Released
Undecided
The ubuntu geek's
Trusty
Fix Released
Medium
Brian Murray
Utopic
Fix Released
Medium
Brian Murray

Bug Description

[Impact]

When a user tries to change his full name via users-admin or mate-users-admin, and some error happens in the backends (either liboobs or system-tools-backends), the error message isn't shown in the GUI. Moreover, the new full name will appear in the GUI, as if it has been successfully changed (when it's not so).

The issues are already fixed in Debian and Ubuntu 15.04, but the package remains unpatched in 14.04 and 14.10.

The attached patches make users-admin (and mate-users-admin) show the error message dialog when the mentioned error happens, and also show the unchanged full name in this case.

[Test Case]

You'll need the unpatched version of system-tools-backends (2.10.2-1ubuntu1) installed.
Run users-admin or mate-users-admin from the terminal. Click on the button for changing your full name, change the name to something else and click "OK".
You'll see a warning message in the terminal:

Liboobs-WARNING **: There was an unknown error communicating with the backends: Launch helper exited with unknown return code 255

No error message dialog will appear though.
Also the full name in the GUI will be changed to the name you entered. This is not correct because some error happened in the backends, and the name hasn't been actually changed. You can see that for yourself by simply restarting users-admin or mate-users-admin - it will show the old name then.

[Regression Potential]

I consider the regression risk to be low here. The patches have been already tested by me and liboobs maintainer in Debian (see the corresponding Debian bug report).

See original description
Revision history for this message
Vlad Orlov (monsta) wrote :
Revision history for this message
Vlad Orlov (monsta) wrote :
description: updated
Bug Watch Updater (bug-watch-updater)
Changed in liboobs (Debian):
status: Unknown → Fix Released
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Patch 1 - correctly return error code on unknown dbus errors." seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Brian Murray (brian-murray) wrote :

Could you add this information to the bug report so that we can proceed with fixing this in Utopic and Trusty? Thanks!

https://wiki.ubuntu.com/StableReleaseUpdates/#SRU_Bug_Template

summary: - patches - correctly return error and emit warning
+ correctly return error and emit warning
Changed in liboobs (Ubuntu):
status: New → Fix Released
Changed in liboobs (Ubuntu Trusty):
status: New → Triaged
Changed in liboobs (Ubuntu Utopic):
status: New → Triaged
Changed in liboobs (Ubuntu Trusty):
importance: Undecided → Medium
Changed in liboobs (Ubuntu Utopic):
importance: Undecided → Medium
Tychodickerson (tychodickerson)
Changed in liboobs (Ubuntu):
assignee: nobody → The ubuntu geek's (the-ubuntu-geek)
Revision history for this message
Vlad Orlov (monsta) wrote :

Brian, I've changed the description to match SRU Bug Template.

description: updated
description: updated
Brian Murray (brian-murray)
Changed in liboobs (Ubuntu Trusty):
assignee: nobody → Brian Murray (brian-murray)
Changed in liboobs (Ubuntu Utopic):
assignee: nobody → Brian Murray (brian-murray)
Changed in liboobs (Ubuntu Trusty):
status: Triaged → In Progress
Changed in liboobs (Ubuntu Utopic):
status: Triaged → In Progress
Revision history for this message
Brian Murray (brian-murray) wrote :

Thanks, I've uploaded new versions of liboobs with your patches to the Trusty and Utopic queues for review by the Ubuntu SRU team.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Monsta, or anyone else affected,

Accepted liboobs into utopic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/liboobs/3.0.0-1ubuntu0.14.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in liboobs (Ubuntu Utopic):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in liboobs (Ubuntu Trusty):
status: In Progress → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Monsta, or anyone else affected,

Accepted liboobs into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/liboobs/3.0.0-1ubuntu0.14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Vlad Orlov (monsta) wrote :

Brian, I've tested the packages in both Trusty and Utopic, looks good to me.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package liboobs - 3.0.0-1ubuntu0.14.10.1

---------------
liboobs (3.0.0-1ubuntu0.14.10.1) utopic; urgency=medium

  [ Vlad Orlov ]
  * 01-return-error-code.patch: new patch. Correctly return error code on
    unknown dbus errors. (LP: #1411584)
  * 02-proper-warning.patch: new patch. Emit the "unknown error" warning only
    when dbus error is really unknown. (LP: #1411584)
 -- Brian Murray <email address hidden> Fri, 23 Jan 2015 09:11:56 -0800

Changed in liboobs (Ubuntu Utopic):
status: Fix Committed → Fix Released
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of the Stable Release Update for liboobs has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package liboobs - 3.0.0-1ubuntu0.14.04.1

---------------
liboobs (3.0.0-1ubuntu0.14.04.1) trusty; urgency=medium

  [ Vlad Orlov ]
  * 01-return-error-code.patch: new patch. Correctly return error code on
    unknown dbus errors. (LP: #1411584)
  * 02-proper-warning.patch: new patch. Emit the "unknown error" warning only
    when dbus error is really unknown. (LP: #1411584)
 -- Brian Murray <email address hidden> Fri, 23 Jan 2015 09:11:56 -0800

Changed in liboobs (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Vlad Orlov (monsta) wrote :

Thank you!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.