Ubuntu
update-notifier package

update-notifier uses udisks1

Bug #1411987 reported by Dimitri John Ledkov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
update-notifier (Ubuntu)
Fix Released
Undecided
Martin Pitt

Bug Description

In the upstart job it uses udisks to query the location of the mounted cd.

http://bazaar.launchpad.net/~ubuntu-core-dev/update-notifier/ubuntu/view/head:/debian/update-notifier-cds.conf

Thus ever since udisks1 was dropped from the image this feature has not been working.
No idea if we need to bring it back.

Related branches

lp:update-notifier/ubuntu
Dennis Kaarsemaker: Pending requested
Diff: 0 lines
Dimitri John Ledkov (xnox)
Changed in update-notifier (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Martin Pitt (pitti) wrote :

FTR, here's how to simulate this in QEMU:

- start with an empty drive: -drive media=cdrom -monitor stdio
- "insert CD": change ide0-cd0 /home/martin/Downloads/ubuntu/vivid-desktop-amd64.iso
- "remove CD": eject ide0-cd0

Unfortunately upstart doesn't seem to have any logging (in .cache/upstart) for the job, but I'll figure that out.

Changed in update-notifier (Ubuntu):
status: New → Triaged
Revision history for this message
Martin Pitt (pitti) wrote :

I tried upstart-monitor in both default and "-d system-socket" mode, and it never displays anything. Ejecting/reinserting a CD ROM does not trigger /usr/share/upstart/sessions/update-notifier-cds.conf either. I *do* see the events in "sudo upstart-monitor" which suggests that the system -> session bridge either misses those events, or there's a permission issue somewhere?

So I can't actually test this, I'm afraid. I'm happy to "blindly" fix the upstart job to fix the mount point location, but it won't help to actually make this work.

Revision history for this message
Dimitri John Ledkov (xnox) wrote : Re: [Bug 1411987] Re: update-notifier uses udisks1

On 20 January 2015 at 09:20, Martin Pitt <email address hidden> wrote:
> I tried upstart-monitor in both default and "-d system-socket" mode, and
> it never displays anything. Ejecting/reinserting a CD ROM does not
> trigger /usr/share/upstart/sessions/update-notifier-cds.conf either. I
> *do* see the events in "sudo upstart-monitor" which suggests that the
> system -> session bridge either misses those events, or there's a
> permission issue somewhere?
>
> So I can't actually test this, I'm afraid. I'm happy to "blindly" fix
> the upstart job to fix the mount point location, but it won't help to
> actually make this work.
>

A few things i have found out:

ubuntu6 upstart does not have the correct udev bridge job start on
conditions, fixed in bzr needs a new upload
(start upstart-udev-bridge)

upstart-monitor works over dbus (session or system buses) but not via
private sockets (subscription to signals fails)

--
Regards,

Dimitri.

Martin Pitt (pitti)
Changed in update-notifier (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Ah, thanks Dimitri!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-notifier - 3.160

---------------
update-notifier (3.160) vivid; urgency=medium

  * ./debian/update-notifier-cds.conf: Stop asking udisks 1 for the
    mountpoint, just awk /proc/mounts for the mount point. (LP: #1411987)
 -- Martin Pitt <email address hidden> Tue, 20 Jan 2015 10:34:47 +0100

Changed in update-notifier (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.