OpenPower needs backport of PowerNV OPAL i2c driver

Bug #1419151 reported by Benjamin Herrenschmidt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
Invalid
Medium
Unassigned
Utopic
Fix Released
Medium
Chris J Arges

Bug Description

[Impact]
This exposes the i2c busses of the machine which are controlled via the OPAL firmware. This is among
other things, necessary for manufacturing configuration of VPDs etc..., but will also enable Linux access
to some i2c devices such as the TPM.

We wish to have this in utopic and if possible trusty.

[Fix]
The Open Power machines need the driver that was merged in 3.19 backported. The commit upstream
is 470834508f87877f680738a10a305280582c7aed "i2c: Driver to expose PowerNV platform i2c busses"
$ git describe --contains 470834508f87877f680738a10a305280582c7aed
v3.19-rc1~22^2~7

[Test Case]
modprobe i2c-opal

Revision history for this message
Brad Figg (brad-figg) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 1419151

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Chris J Arges (arges)
Changed in linux (Ubuntu):
status: Incomplete → Opinion
status: Opinion → Confirmed
assignee: nobody → Chris J Arges (arges)
Changed in linux (Ubuntu Trusty):
assignee: nobody → Chris J Arges (arges)
Changed in linux (Ubuntu Utopic):
assignee: nobody → Chris J Arges (arges)
Changed in linux (Ubuntu Trusty):
importance: Undecided → Medium
Changed in linux (Ubuntu Utopic):
importance: Undecided → Medium
Changed in linux (Ubuntu Trusty):
status: New → Confirmed
Changed in linux (Ubuntu Utopic):
status: New → Confirmed
Revision history for this message
Chris J Arges (arges) wrote :

Benh,
Will CONFIG_I2C_OPAL=m be sufficient for this driver?
In addition, is this driver needed during installation?
Thanks,
--chris

description: updated
Revision history for this message
Chris J Arges (arges) wrote :

For the backports, are any other features needed like:
608b286d1ddf38a7ceb624d2b689af095816d91c ?

We can always merge these latter, but might make cherry-picking a bit easier if done now. : )

Revision history for this message
Benjamin Herrenschmidt (benh-kernel) wrote : Re: [Bug 1419151] Re: OpenPower needs backport of PowerNV OPAL i2c driver

On Fri, 2015-02-06 at 22:09 +0000, Chris J Arges wrote:
> Benh,
> Will CONFIG_I2C_OPAL=m be sufficient for this driver?
> In addition, is this driver needed during installation?

Yes and no.

IE. Yes, it can be a module, and no, it's not needed in the installer at
this point as far as I can tell. It might be handy to have it in the
live CD though for manufacturing etc...

Cheers,
Ben.

> Thanks,
> --chris
>
> ** Also affects: linux (Ubuntu Utopic)
> Importance: Undecided
> Status: New
>
> ** Also affects: linux (Ubuntu Trusty)
> Importance: Undecided
> Status: New
>
> ** Changed in: linux (Ubuntu)
> Status: Incomplete => Opinion
>
> ** Changed in: linux (Ubuntu)
> Status: Opinion => Confirmed
>
> ** Changed in: linux (Ubuntu)
> Assignee: (unassigned) => Chris J Arges (arges)
>
> ** Changed in: linux (Ubuntu Trusty)
> Assignee: (unassigned) => Chris J Arges (arges)
>
> ** Changed in: linux (Ubuntu Utopic)
> Assignee: (unassigned) => Chris J Arges (arges)
>
> ** Changed in: linux (Ubuntu Trusty)
> Importance: Undecided => Medium
>
> ** Changed in: linux (Ubuntu Utopic)
> Importance: Undecided => Medium
>
> ** Changed in: linux (Ubuntu Trusty)
> Status: New => Confirmed
>
> ** Changed in: linux (Ubuntu Utopic)
> Status: New => Confirmed
>
> ** Description changed:
>
> - The Open Power machines need the driver that was merged in 3.19 backported. The commit upstream
> - is 470834508f87877f680738a10a305280582c7aed "i2c: Driver to expose PowerNV platform i2c busses"
> -
> + [Impact]
> This exposes the i2c busses of the machine which are controlled via the OPAL firmware. This is among
> other things, necessary for manufacturing configuration of VPDs etc..., but will also enable Linux access
> to some i2c devices such as the TPM.
>
> We wish to have this in utopic and if possible trusty.
> +
> + [Fix]
> + The Open Power machines need the driver that was merged in 3.19 backported. The commit upstream
> + is 470834508f87877f680738a10a305280582c7aed "i2c: Driver to expose PowerNV platform i2c busses"
> + $ git describe --contains 470834508f87877f680738a10a305280582c7aed
> + v3.19-rc1~22^2~7
> +
> + [Test Case]
> + modprobe i2c-opal
>

Revision history for this message
Benjamin Herrenschmidt (benh-kernel) wrote :

On Fri, 2015-02-06 at 22:18 +0000, Chris J Arges wrote:
> For the backports, are any other features needed like:
> 608b286d1ddf38a7ceb624d2b689af095816d91c ?
>
> We can always merge these latter, but might make cherry-picking a bit
> easier if done now. : )

There's a number of things that would be handy to have for OpenPower
support and the above is one of them :) I can make you a list, we would
want the AST driver as well for BMC graphics but there are dependencies
I think on a bunch of other DRM changes so it might be easier if I
cooked you a backport myself.

I'll look into that early next week.

But don't hold the i2c stuff on that, there are people waiting on it
so we can tell OpenPower vendors that they can just use a standard
ubuntu image for manufacturing and use the i2c interface to program the
VPDs without having to build/install custom kernel packages.

Cheers,
Ben.

Revision history for this message
Chris J Arges (arges) wrote :

Patches sent to mailing list for 3.13/3.16.

Revision history for this message
Benjamin Herrenschmidt (benh-kernel) wrote :

On Mon, 2015-02-09 at 23:26 +0000, Chris J Arges wrote:
> Patches sent to mailing list for 3.13/3.16.

Any pointer to that list ? I'm putting together some backport trees
here, I'd like to include those exact patches you sent in there. I'll
backport a few more things then I'll push them out to github after
testing and open launchpad feature requests.

Cheers,
Ben.

Revision history for this message
Chris J Arges (arges) wrote :

Here is the 3.16 backport:
https://lists.ubuntu.com/archives/kernel-team/2015-February/054242.html

Here is the 3.13 backport:
https://lists.ubuntu.com/archives/kernel-team/2015-February/054245.html

Let me know if you'd like a git pull request or patches attached here.
Thanks,
--chris

Revision history for this message
Brad Figg (brad-figg) wrote :

The default kernel installed for the LTS will soon be the Utopic HWE kernel. Therefore, we will not be taking this set of patches into Trusty and any future feature additions such as these should target Utopic.

Changed in linux (Ubuntu Trusty):
status: Confirmed → Invalid
Chris J Arges (arges)
Changed in linux (Ubuntu Trusty):
assignee: Chris J Arges (arges) → nobody
Brad Figg (brad-figg)
Changed in linux (Ubuntu Utopic):
status: Confirmed → Fix Committed
Revision history for this message
Brad Figg (brad-figg) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-utopic' to 'verification-done-utopic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-utopic
Revision history for this message
Chris J Arges (arges) wrote :

Since Vivid is now based on 3.19 marking that series as Fix Released. However verification for Utopic is still needed.
Thanks!

Changed in linux (Ubuntu):
status: Confirmed → Fix Released
assignee: Chris J Arges (arges) → nobody
Revision history for this message
Benjamin Herrenschmidt (benh-kernel) wrote :

On Mon, 2015-03-16 at 14:01 +0000, Chris J Arges wrote:
> Since Vivid is now based on 3.19 marking that series as Fix Released. However verification for Utopic is still needed.
> Thanks!

Ok, you also need the fix for Bug 1431196 (backport of
19d36c2152aaf093c97431b5b4d13d29305a63a3) otherwise calls
from the module to OPAL will crash in LE.

Cheers,
Ben.

> ** Changed in: linux (Ubuntu)
> Status: Confirmed => Fix Released
>
> ** Changed in: linux (Ubuntu)
> Assignee: Chris J Arges (arges) => (unassigned)
>

Revision history for this message
Brad Figg (brad-figg) wrote :

Requested by IBM and only affects Power8 related systems.

tags: added: verification-done-utopic
removed: verification-needed-utopic
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (15.0 KiB)

This bug was fixed in the package linux - 3.16.0-33.44

---------------
linux (3.16.0-33.44) utopic; urgency=low

  [ Luis Henriques ]

  * Release Tracking Bug
    - LP: #1431304
  * Merged back all changes that were in Ubuntu-3.16.0-32.42

linux (3.16.0-32.42) utopic; urgency=low

  [ Seth Forshee ]

  * Release Tracking Bug
    - LP: #1427808

  [ Chris J Arges ]

  * [Config] ppc64el CONFIG_I2C_OPAL=m
    - LP: #1419151

  [ Upstream Kernel Changes ]

  * i2c: Driver to expose PowerNV platform i2c busses
    - LP: #1419151
  * Bluetooth: ath3k: workaround the compatibility issue with xHCI
    controller
    - LP: #1400215
  * ALSA: hda - enable mute led quirk for one more hp machine.
    - LP: #1410704
  * ipvs: uninitialized data with IP_VS_IPV6
    - LP: #1427767
  * netfilter: nfnetlink: validate nfnetlink header from batch
    - LP: #1427767
  * clocksource: exynos_mct: Fix bitmask regression for exynos4_mct_write
    - LP: #1427767
  * time: settimeofday: Validate the values of tv from user
    - LP: #1427767
  * Input: i8042 - reset keyboard to fix Elantech touchpad detection
    - LP: #1427767
  * drm/radeon: fix VM flush on cayman/aruba (v3)
    - LP: #1427767
  * drm/radeon: fix VM flush on SI (v3)
    - LP: #1427767
  * drm/radeon: fix VM flush on CIK (v3)
    - LP: #1427767
  * drm/radeon: add a dpm quirk list
    - LP: #1427767
  * Input: elantech - support new ICs types for version 4
    - LP: #1427767
  * Input: I8042 - add Acer Aspire 7738 to the nomux list
    - LP: #1427767
  * drm/i915: Ban Haswell from using RCS flips
    - LP: #1427767
  * drm/i915: Fix mutex->owner inspection race under DEBUG_MUTEXES
    - LP: #1427767
  * drm/radeon: add si dpm quirk list
    - LP: #1427767
  * pinctrl: Fix two deadlocks
    - LP: #1427767
  * gpio: fix memory and reference leaks in gpiochip_add error path
    - LP: #1427767
  * gpio: fix memory leak and sleep-while-atomic
    - LP: #1427767
  * gpio: fix sleep-while-atomic in gpiochip_remove
    - LP: #1427767
  * can: dev: fix crtlmode_supported check
    - LP: #1427767
  * can: kvaser_usb: Don't free packets when tight on URBs
    - LP: #1427767
  * can: kvaser_usb: Reset all URB tx contexts upon channel close
    - LP: #1427767
  * can: kvaser_usb: Don't send a RESET_CHIP for non-existing channels
    - LP: #1427767
  * drm/radeon: use rv515_ring_start on r5xx
    - LP: #1427767
  * gpio: sysfs: fix gpio-chip device-attribute leak
    - LP: #1427767
  * gpio: sysfs: fix gpio device-attribute leak
    - LP: #1427767
  * gpiolib: of: Correct error handling in of_get_named_gpiod_flags
    - LP: #1427767
  * PCI: Add flag for devices where we can't use bus reset
    - LP: #1427767
  * PCI: Mark Atheros AR93xx to avoid bus reset
    - LP: #1427767
  * PCI: Pass bridge device, not bus, when updating bridge windows
    - LP: #1427767
  * PCI: Add pci_bus_clip_resource() to clip to fit upstream window
    - LP: #1427767
  * PCI: Add pci_claim_bridge_resource() to clip window if necessary
    - LP: #1427767
  * x86/PCI: Clip bridge windows to fit in upstream windows
    - LP: #1427767
  * workqueue: fix subtle pool management issue which can stall whole
    worker_pool
    - LP: #1427767
...

Changed in linux (Ubuntu Utopic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.