Menus in gnome-session-flashback following improper schema?

Bug #1433246 reported by Erick Brunzell
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gnome-panel (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The menus in flashback appear bloated and can't be properly edited. Even the menus and buttons have icons settings aren't applied as they should be. Also the Power Off and Restart menu buttons don't work so I suspect that we're using the wrong schema?

This may be somewhat of a regression to bug #1380850 and bug #1267787 but I don't recall either of them also effecting the Power Off and Restart menu buttons.

This testing was done on a fresh install of Ubuntu 20150317.1 amd64.

ProblemType: Bug
DistroRelease: Ubuntu 15.04
Package: gnome-panel 1:3.14.0-1~ubuntu2
ProcVersionSignature: Ubuntu 3.19.0-9.9-generic 3.19.1
Uname: Linux 3.19.0-9-generic x86_64
ApportVersion: 2.16.2-0ubuntu3
Architecture: amd64
CurrentDesktop: GNOME-Flashback:Unity
Date: Tue Mar 17 12:49:44 2015
GsettingsChanges:

InstallationDate: Installed on 2015-03-17 (0 days ago)
InstallationMedia: Ubuntu 15.04 "Vivid Vervet" - Alpha amd64 (20150317.1)
SourcePackage: gnome-panel
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Erick Brunzell (lbsolost) wrote :
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Erick,
1) Main Menu applet loads wrong .menu file, that bug is fixed upstream. Does Menu Bar applet work like it should? Just to make sure that this bug is realy only about loading wrong file.

2) You need to start gnome-flashback, then Power Off should work. But gnome-flashback should be started before you try to power off or restart.

Dmitry,
1) Main Menu applet problem is fixed upstream:
https://git.gnome.org/browse/gnome-panel/commit/?id=5209462c4b47706a1b9317d1eca81235a2b5d8a1

2) Looks like you will need to autostart gnome-flashback. Looks like there is many people that does not use standart/default configuration.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

1) What do you mean by "menus can't be properly edited"? Does alacarte work for you?

2) Re restart and shutdown buttons -- this can be the case if you use the buttons from gnome-panel (not indicator-session). Is there any reason for not using indicators?

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Alberts, OK, I will backport the patch and autostart gnome-flashback.

Will the end-session-dialog module be enough? (Btw it would be nice if it allowed specifying list of modules on commandline in addition to gsettings).

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Yes, it should be enough.

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Upstream have removed 'menus-have-icons' setting from schemas since 3.9.5 version. I guess ubuntu is reverting it.

gsettings-desktop-schemas commit:
https://git.gnome.org/browse/gsettings-desktop-schemas/commit/?id=7d48c4ed64bb5f42f1a8a781f06f534903e78d70

GTK+ commits:
1) https://git.gnome.org/browse/gtk+/commit/?id=e8147d15f74e62047c84eb95e393449722198d89
2) https://git.gnome.org/browse/gtk+/commit/?id=627a03683f5f41efbfc86cc0f10e1b7c11e9bb25

Reverting this commit:
https://git.gnome.org/browse/gnome-panel/commit/?id=9c0ce17439f1ed896cb5aad7e7fac0b9900b07b9
should be enough to get back images in menus in gnome-panel.

But that key will be removed sooner or later so my plan is to make menu applets configurable where user can choose if he wants images in menus or not. Other way to fix is simply to patch gnome-panel and set it to always show images in menus.

Revision history for this message
Erick Brunzell (lbsolost) wrote :

"Other way to fix is simply to patch gnome-panel and set it to always show images in menus."

I think that would be preferable. To me it always just looks odd that those few objects in the tree view have no icons whereas all the other objects do. Of course that was a change made in GNOME 2 some months or years prior to the release of GNOME 3.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-panel - 1:3.14.0-2ubuntu1

---------------
gnome-panel (1:3.14.0-2ubuntu1) vivid; urgency=medium

  * No-change merge with Debian experimental.
  * debian/patches/applications_menu.patch:
    Backport upstream change to use correct file name for main menu.
    This fixes the gnome-panel part of LP: #1433246.
  * debian/patches/revert_menu_images_removal.patch:
    Temporarily revert upstream change to remove use of gtk-menu-images
    setting, as we still have this key in our gsettings-desktop-schemas.
 -- Dmitry Shachnev <email address hidden> Wed, 18 Mar 2015 13:31:01 +0300

Changed in gnome-panel (Ubuntu):
status: New → Fix Released
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Alberts Muktupāvels wrote:
> 2) Looks like you will need to autostart gnome-flashback. Looks like
> there is many people that does not use standart/default configuration.

Alberts, do we need to start any components other than end-session-dialog, or should I disable them all in gsettings?

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Nevermind the last question, I see you already said that end-session-dialog is enough.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.