Ubuntu
gtk+3.0 package

GTK does not build because gtk_menu_tracker_item_get_menu_item does not always return a value

Bug #1439923 reported by Steve Dodier-Lazaro
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gtk+3.0 (Ubuntu)
Fix Released
Undecided
Iain Lane

Bug Description

Tested version: 3.14.11-0ubuntu1
Bug most likely introduced in: 3.10.6-0ubuntu1

gtk_menu_tracker_item_get_menu_item and gtk_menu_tracker_item_get_action_namespace both have return types, but use g_return_if_fail instead of g_return_val_if_fail.

Attached is a diff of the change I made to make my Clang build the package, although you might want to verify whether returning NULL is correct (I have no idea what GtkMenuTrackerItem is).

Tags: patch
Revision history for this message
Steve Dodier-Lazaro (sidi) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "fix_return_value.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Iain Lane (laney) wrote :

Cheers - do you think you could send this upstream? https://bugzilla.gnome.org

Revision history for this message
Steve Dodier-Lazaro (sidi) wrote :

I've just checked upstream GTK, and these two methods only exist in Ubuntu. They come from the patch named debian/patches/ubuntu_gtk_custom_menu_items.patch

Cheers,

Revision history for this message
Iain Lane (laney) wrote :

Ah okay, thanks, we'll look then!

Changed in gtk+3.0 (Ubuntu):
assignee: nobody → Iain Lane (laney)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk+3.0 - 3.14.11-0ubuntu2

---------------
gtk+3.0 (3.14.11-0ubuntu2) vivid; urgency=medium

  * Patch from Steve Dodier-Lazaro (thanks!) to always return a value from
    gtk_menu_tracker_item_get_{menu_item,action_namespace}. (LP: #1439923)
 -- Iain Lane <email address hidden> Wed, 08 Apr 2015 17:28:36 +0100

Changed in gtk+3.0 (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.