Please update Ninja from Debian

Thanks for reporting this issue.

>It has not migrated to Ubuntu proper for some reason, probably because uploads newer than 1.3.4 are NMUs.

It's because the Ubuntu package contains some Ubuntu-specific patches. Normally packages are synced straight from Debian, but if they have been patched, someone will need to manually merge them in Ubuntu (see https://wiki.ubuntu.com/UbuntuDevelopment/Merging for more information). You can tell by the version number "1.3.4-1.1ubuntu1" which contains the ubuntu-suffix at the end that it has some Ubuntu-specific patches.

Looks like only a small patch on the Ubuntu-side though, so I might try merging this.

I've now created a branch where I've merged in the latest changes from Debian with the Ubuntu ones.

Attached is the output of `bzr diff -r tag:1.5.1-0.1` from my suggested branch, since I noticed I couldn't attach files in the merge proposal. I have to admit I don't understand why several files are marked as renamed when the names haven't actually changed. Please let med know if this is unexpected and due to my merge somehow.

The attachment "ubuntu-delta.diff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

Could somebody please do a test build of Oxide before this gets uploaded?

(unsubscribing the sponsors from the bug, the merge request is already in the review queue, no need to have the bug as well)

I looked to upload this just now. I followed the request in comment #4 to build oxide with it. The oxide build fails with an unrelated error.

FAILED: /usr/bin/x86_64-linux-gnu-g++ -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -pthread -Wl,-z,noexecstack -fPIC -fuse-ld=gold -Wl,--disable-new-dtags -Wl,--stats -m64 -Wl,--detect-odr-violations -Wl,--icf=all -Wl,-O1 -Wl,--as-needed -Wl,--gc-sections -o protoc -Wl,--start-group obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/protoc.code_generator.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/protoc.command_line_interface.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/protoc.plugin.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/protoc.plugin.pb.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/protoc.subprocess.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/protoc.zip_writer.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/cpp/protoc.cpp_enum.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/cpp/protoc.cpp_enum_field.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/cpp/protoc.cpp_extension.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/cpp/protoc.cpp_field.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/cpp/protoc.cpp_file.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/cpp/protoc.cpp_generator.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/cpp/protoc.cpp_helpers.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/cpp/protoc.cpp_message.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/cpp/protoc.cpp_message_field.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/cpp/protoc.cpp_primitive_field.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/cpp/protoc.cpp_service.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/cpp/protoc.cpp_string_field.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/java/protoc.java_enum.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/java/protoc.java_enum_field.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/java/protoc.java_extension.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/java/protoc.java_field.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/java/protoc.java_file.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/java/protoc.java_generator.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/java/protoc.java_helpers.o obj/third_party/chromium/src/third_party/protobuf/src/google/protobuf/compiler/java/protoc.java_message.o obj/third_party/chromium/src/third_party/protobuf/src/google/pro...

Looks like bug 1496743 mentioned in the previous comment has been fixed. However, in the meantime it looks like oxide now fails to build against qt5.5, so an attempted rebuild would presumably fail similarly. See bug 1500767 for details.

Hey! The Qt 5.5 is not yet in Ubuntu, I just filed the bug to state that Qt 5.5 also can't land (to wily+1) until Oxide builds against it among else. So just ignore that part for the time being.

Is this now ok to land? It has been stuck in the queue for quite a long time and the only remaining issue is not Ninja's fault (the current version of Ninja would fail the rebuild in a similar way).

Timo: Oh. I thought it had already landed and that a rebuild of oxide would now fail. Sorry about that.

Status changed to 'Confirmed' because the bug affects multiple users.

<dholbach> chrisccoulson, Laney, seb128, Mirv: you all commented on https://bugs.launchpad.net/ubuntu/+source/ninja-build/+bug/1473680 - do you have any objections to a newer version of ninja-build going in?
<ubottu> Launchpad bug 1473680 in ninja-build (Ubuntu) "Please update Ninja from Debian" [Undecided,Confirmed]
<seb128> dholbach, none from me
<Mirv> dholbach: no objections
<chrisccoulson> dholbach, none from me

Since this did not get into wily, could we get it into xenial now that the gates are open again?

Uploaded the merge, thanks! @Jussi: Can we please get this delta into Debian? It's entirely appropriate and desirable to run tests during package build for Debian too, there's no reason why this should be an Ubuntu delta.

Hello Jussi,

Jussi Pakkanen [2015-10-26 20:41 -0000]:
> Since this did not get into wily, could we get it into xenial now that
> the gates are open again?

I uploaded the merge. Can we please get this delta into Debian? It's
entirely appropriate and desirable to run tests during package build
for Debian too, there's no reason why this should be an Ubuntu delta.

Thanks,

Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

Thanks for the upload. The main reason why the delta is not in Debian is that the maintainer seems to be MIA.

This bug was fixed in the package ninja-build - 1.5.1-0.1ubuntu1

---------------
ninja-build (1.5.1-0.1ubuntu1) xenial; urgency=medium

  * Merge from Debian unstable. (Fixes LP: #1473680)
    Remaining changes:
    - Run the tests at build time

ninja-build (1.5.1-0.1) experimental; urgency=medium

  [Mickaël Guerin]
  * Non-maintainer upload.
  * New upstream release. Closes: #767813
  * Fixed lintian warnings. Closes: #750585, #750583

  [Jussi Pakkanen]
  * Took Mickaël's packaging changes and got them reviewed
    in mentors and fixed the issues raised.

ninja-build (1.3.4-1.2) unstable; urgency=medium

  * Non-maintainer upload.
  * Add gnukfreebsd.patch to fix platform detection on gnukfreebsd 9 and later.
    Thanks to Steven Chamberlain for the patch. (Closes: #717364)

 -- Hans Joachim Desserud <email address hidden> Sun, 12 Jul 2015 15:04:44 +0200

\o/ Thanks for uploading.

>The main reason why the delta is not in Debian is that the maintainer seems to be MIA.

The patch has been (attempted) forwarded in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797586 and I've also mentioned it in my wishlist/request for an upgrade to latest upstream version (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795748).