snapcraft is not using the python logger
Bug #1476452 reported by
Leo Arias
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Snapcraft |
Fix Released
|
Low
|
Leo Arias | ||
Bug Description
Snapcraft is just printing messages to stdout. Python has a nice logging module that's easy to use and gives a lot of nice features:
https:/
So, I propose to remove the snapcraft.
logger = logging.
Then replace all the calls to log with:
logger.
Related branches
lp:~elopio/snapcraft/fix1476452-python_log
- Michael Terry (community): Approve
- Michael Vogt (community): Approve
-
Diff: 669 lines (+176/-69)14 files modifiedintegration-tests/units/jobs.pxu (+4/-4)
snapcraft/__init__.py (+14/-5)
snapcraft/cmds.py (+9/-5)
snapcraft/common.py (+0/-5)
snapcraft/main.py (+8/-0)
snapcraft/plugin.py (+8/-4)
snapcraft/plugins/ant_project.py (+7/-2)
snapcraft/plugins/copy.py (+5/-1)
snapcraft/plugins/ubuntu.py (+10/-4)
snapcraft/tests/test_cmds.py (+45/-8)
snapcraft/tests/test_copy_plugin.py (+15/-8)
snapcraft/tests/test_plugin.py (+17/-4)
snapcraft/tests/test_yaml.py (+23/-14)
snapcraft/yaml.py (+11/-5)
| Changed in snapcraft: | |
| status: | New → In Progress |
| assignee: | nobody → Leo Arias (elopio) |
| Changed in snapcraft: | |
| status: | In Progress → Fix Committed |
| Changed in snapcraft: | |
| milestone: | none → 0.2 |
| Changed in snapcraft: | |
| importance: | Undecided → Low |
| Changed in snapcraft: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
