xchat-gnome crashed with SIGFPE in gtk_xtext_check_ent_visibility()

Bug #1495828 reported by Daniel Holbach
44
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xchat-gnome (Ubuntu)
Fix Released
Medium
Unassigned
Wily
Fix Released
Undecided
Unassigned

Bug Description

* Impact
xchat-gnome sometime segfaults on start

* Test case
no easy way to trigger the issue so just make sure that xchat-gnome starts without issue

* Regression potential
the change only returns when widgets are not ready yet, shouldn't create any issue

-------------

No idea what happened.

ProblemType: Crash
DistroRelease: Ubuntu 15.10
Package: xchat-gnome 1:0.30.0~git20141005.816798-0ubuntu6
ProcVersionSignature: Ubuntu 4.2.0-7.7-generic 4.2.0
Uname: Linux 4.2.0-7-generic x86_64
ApportVersion: 2.18.1-0ubuntu1
Architecture: amd64
CrashCounter: 1
CurrentDesktop: Unity
Date: Tue Sep 15 09:09:35 2015
ExecutablePath: /usr/bin/xchat-gnome
InstallationDate: Installed on 2015-04-30 (137 days ago)
InstallationMedia: Ubuntu 15.04 "Vivid Vervet" - Release amd64 (20150422)
ProcCmdline: xchat-gnome
Signal: 8
SourcePackage: xchat-gnome
StacktraceTop:
 ?? ()
 gtk_xtext_check_marker_visibility ()
 ?? ()
 ?? () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
 g_closure_invoke () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
SystemImageInfo: Error: command ['system-image-cli', '-i'] failed with exit code 2:
Title: xchat-gnome crashed with SIGFPE in gtk_xtext_check_marker_visibility()
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm audio autopilot cdrom dip libvirtd lpadmin plugdev sambashare sudo

Revision history for this message
Daniel Holbach (dholbach) wrote :
Revision history for this message
Apport retracing service (apport) wrote :

StacktraceTop:
 gtk_xtext_check_ent_visibility (xtext=xtext@entry=0x202f560, find_ent=0x0, add=add@entry=1) at xtext.c:3365
 gtk_xtext_check_marker_visibility (xtext=0x202f560) at xtext.c:3382
 conversation_panel_check_marker_visibility (panel=<optimized out>) at conversation-panel.c:1185
 on_main_window_focus_in (widget=widget@entry=0x20044b0, event=<optimized out>, data=data@entry=0x0) at main-window.c:780
 _gtk_marshal_BOOLEAN__BOXED (closure=0x2cf94c0, return_value=0x7ffe38cfaa90, n_param_values=<optimized out>, param_values=0x7ffe38cfaaf0, invocation_hint=<optimized out>, marshal_data=<optimized out>) at /build/gtk+3.0-lfM3Xq/gtk+3.0-3.16.6/./gtk/gtkmarshalers.c:85

Revision history for this message
Apport retracing service (apport) wrote : Stacktrace.txt
Revision history for this message
Apport retracing service (apport) wrote : StacktraceSource.txt
Revision history for this message
Apport retracing service (apport) wrote : ThreadStacktrace.txt
Changed in xchat-gnome (Ubuntu):
importance: Undecided → Medium
summary: - xchat-gnome crashed with SIGFPE in gtk_xtext_check_marker_visibility()
+ xchat-gnome crashed with SIGFPE in gtk_xtext_check_ent_visibility()
tags: removed: need-amd64-retrace
information type: Private → Public
Revision history for this message
Xavier Claessens (zdra) wrote :

Randomly crash at startup with that same backtrace since Ubuntu 15.10. The problem is the xtext widget is not yet realized so xtext->fontsize is 0 and a div-by-0 happens.

I didn't understand why the xtext widget is not yet realized when its parent GtkWindow is already realized and gets the focus-in event. Also, why did it ever worked before?

In any case, attached patch works perfectly for me.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "xchat-crash.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Xavier, I uploaded to 15.10 and xenial. Would be nice if you could forward the patch upstream in case somebody is picking the project up/wants to review it

Changed in xchat-gnome (Ubuntu):
status: New → Fix Committed
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xchat-gnome - 1:0.30.0~git20141005.816798-0ubuntu8

---------------
xchat-gnome (1:0.30.0~git20141005.816798-0ubuntu8) xenial; urgency=medium

  * debian/patches/xtext_widget_segfault.patch:
    - don't try to get value from a widget not realized yet, fixes a
      segfault on start, thanks Xavier Claessens (lp: #1495828)

 -- Sebastien Bacher <email address hidden> Tue, 08 Mar 2016 16:08:19 +0100

Changed in xchat-gnome (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Daniel, or anyone else affected,

Accepted xchat-gnome into wily-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xchat-gnome/1:0.30.0~git20141005.816798-0ubuntu6.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in xchat-gnome (Ubuntu Wily):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Package in wily-proposed works great for me.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

I released this as part of today's security update. Marking as fix released.

Changed in xchat-gnome (Ubuntu Wily):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.