FWTS syntaxcheck failure on Remark #2011 ASL_MSG_COMPILER_RESERVED

Bug #1529717 reported by wufan
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Firmware Test Suite
Fix Released
Medium
Colin Ian King

Bug Description

Reporting IASL remark #2011 as failure is quite confusing. If there are real problems of using compiler reserved symbols, these problems should be caught when comping ACPI source. It would be better to just log the remark as info.

--------------------------------------------------------------------------------
12510|
12511| Method (_DSM, 4, Serialized) // _DSM: Device-Specific Method
12512| {
12513| Name (_T_2, Zero) // _T_x: Emitted by ASL Compiler
     | ^
     | Remark 2011: Use of compiler reserved name (_T_2)
================================================================================

ADVICE: (for Remark #2011, ASL_MSG_COMPILER_RESERVED): This normally occurs when
disassembled code is being compiled and it contains compiler-emitted names of
the form '_T_x'. This is just a remark generated by the compiler and can
normally be ignored.

Revision history for this message
wufan (wufan) wrote :

From accad713ae86d7dc0b500a14ab1505d680d26197 Mon Sep 17 00:00:00 2001
From: Fan Wu <email address hidden>
Date: Wed, 8 Jul 2015 15:24:02 -0600
Subject: [PATCH] FWTS:syntaxcheck change the ASL_MSG_COMPILER_RESERVED failure
 to info

---
 src/acpi/syntaxcheck/syntaxcheck.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/acpi/syntaxcheck/syntaxcheck.c b/src/acpi/syntaxcheck/syntaxcheck.c
index c189e87..8be4330 100644
--- a/src/acpi/syntaxcheck/syntaxcheck.c
+++ b/src/acpi/syntaxcheck/syntaxcheck.c
@@ -545,7 +545,11 @@ static int syntaxcheck_table(fwts_framework *fw, int which)
                                                        fwts_failed(fw, LOG_LEVEL_HIGH, label, "Assembler error in line %d", num);
                                                        break;
                                                case ASL_REMARK:
- fwts_failed(fw, LOG_LEVEL_LOW, label, "Assembler remark in line %d", num);
+ if ( syntaxcheck_error_code_to_error_number(error_code) == ASL_MSG_COMPILER_RESERVED) {
+ fwts_log_info(fw, "Assembler remark(info) in line %d", num);
+ } else {
+ fwts_failed(fw, LOG_LEVEL_LOW, label, "Assembler remark in line %d", num);
+ }
                                                        break;
                                                case ASL_OPTIMIZATION:
                                                        skip = true;
--
1.8.2.1

Changed in fwts:
status: New → In Progress
importance: Undecided → Critical
importance: Critical → Medium
assignee: nobody → Colin Ian King (colin-king)
Revision history for this message
Colin Ian King (colin-king) wrote :

Thanks for the patch Fan Wu, I took the liberty to turn expand the commit message in a form that can be reviewed on the fwts-devel mailing list, and hopefully applied to the git repository some time soon:

https://lists.ubuntu.com/archives/fwts-devel/2016-January/007222.html

(Just for future reference, format patches using git format-patch and send them to <email address hidden>). Once again, thank you for your contribution to FWTS.

Revision history for this message
Colin Ian King (colin-king) wrote :
Changed in fwts:
status: In Progress → Fix Committed
Changed in fwts:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.