Engrampa refuses to add files to a zip archive if compression-level is set to "maximum"

Bug #1580860 reported by SUNSHINE corp.
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
engrampa (Ubuntu)
Fix Released
Medium
Martin Wimpress 
Xenial
Fix Released
Medium
Vlad Orlov
Zesty
Fix Released
Medium
Vlad Orlov

Bug Description

[Impact]

An old bug in Engrampa prevents users from creating zip archives when the compression level is set to maximum in the settings.

The fix for this issue is provided in the debdiffs attached to the report.

The fix is already in Artful, and would be nice to backport it to Zesty and Xenial as well. That bug caused problems for years, especially if you don't remember that you once set the compression level to maximum. The error message doesn't really help.

[Test Case]

First, set the compression level to maximum, using either dconf-editor or gsettings tool:

$ gsettings set org.mate.engrampa.general compression-level 'maximum'

Then try to compress any file(s) into zip archive. The operation will fail with error message dialog, and the archive won't be created.

[Regression Potential]

None. The fix doesn't affect any other features of Engrampa (other archive types, other compression levels, extracting, and so on).

[Original Description]

Engrampa 1.12.0-2 (64-bit) on Ubuntu MATE 16.04 LTS

If compression-level is set to "maximum" through dconf, engrampa cannot create zip archives while it still can handle every other archive type.

Revision history for this message
Vlad Orlov (monsta) wrote :

Fixed upstream, not released yet though. Can be fixed in Xenial and any following Ubuntu releases using this patch.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in engrampa (Ubuntu):
status: New → Confirmed
Vlad Orlov (monsta)
tags: added: artful xenial yakkety zesty
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Fix maximum compression level for zip archives" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Changed in engrampa (Ubuntu):
status: Confirmed → Fix Committed
importance: Undecided → Medium
assignee: nobody → Martin Wimpress (flexiondotorg)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package engrampa - 1.18.2-2ubuntu0

---------------
engrampa (1.18.2-2ubuntu0) artful; urgency=medium

  * debian/patches: Add 0000_fix-maximum-compression-zip.patch. Create
    zip files in maximum compression level (LP: #1580860)

 -- Martin Wimpress <email address hidden> Sat, 23 Sep 2017 19:59:50 +0100

Changed in engrampa (Ubuntu):
status: Fix Committed → Fix Released
Vlad Orlov (monsta)
tags: added: ubuntu-mate-zesty-sru
removed: artful yakkety
Revision history for this message
Vlad Orlov (monsta) wrote :
Vlad Orlov (monsta)
tags: added: ubuntu-mate-xenial-sru
Revision history for this message
Vlad Orlov (monsta) wrote :
Revision history for this message
Vlad Orlov (monsta) wrote :

[Impact]

An old bug in Engrampa prevents users from creating
zip archives when the compression level is set to
maximum in the settings.

The fix for this issue is provided in the debdiffs
attached to the report.

The fix is already in Artful, and would be nice to
backport it to Zesty and Xenial as well. That bug
caused problems for years, especially if you don't
remember that you once set the compression level
to maximum. The error message doesn't really help.

[Test Case]

First, set the compression level to maximum, using
either dconf-editor or gsettings tool:

$ gsettings set org.mate.engrampa.general compression-level 'maximum'

Then try to compress any file(s) into zip archive.
The operation will fail with error message dialog,
and the archive won't be created.

[Regression Potential]

None. The fix doesn't affect any other features of
Engrampa (other archive types, other compression
levels, extracting, and so on).

Simon Quigley (tsimonq2)
description: updated
Changed in engrampa (Ubuntu Xenial):
status: New → In Progress
Changed in engrampa (Ubuntu Zesty):
status: New → In Progress
Changed in engrampa (Ubuntu Xenial):
importance: Undecided → Medium
Changed in engrampa (Ubuntu Zesty):
importance: Undecided → Medium
Changed in engrampa (Ubuntu Xenial):
assignee: nobody → Vlad Orlov (monsta)
Changed in engrampa (Ubuntu Zesty):
assignee: nobody → Vlad Orlov (monsta)
Revision history for this message
Simon Quigley (tsimonq2) wrote :

Uploaded.

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello SUNSHINE, or anyone else affected,

Accepted engrampa into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/engrampa/1.18.1-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in engrampa (Ubuntu Zesty):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-zesty
Changed in engrampa (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed-xenial
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello SUNSHINE, or anyone else affected,

Accepted engrampa into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/engrampa/1.12.0-2ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Vlad Orlov (monsta) wrote :

Testing in Xenial:

- checked compression-level setting, it's already on 'maximum'
- replaced my locally built engrampa and engrampa-common packages with version 1.12.0-2ubuntu0.1 from xenial-proposed
- compressed a couple of files into .zip archive

Testing in Zesty:

- checked compression-level setting, it's already on 'maximum'
- upgraded local build of engrampa and engrampa-common to 1.18.1-0ubuntu1.1 from zesty-proposed
- compressed a couple of files into .zip archive

In both cases, the .zip archive is created successfully, which means the fix works.

tags: added: verification-done verification-done-xenial verification-done-zesty
removed: verification-needed verification-needed-xenial verification-needed-zesty
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package engrampa - 1.18.1-0ubuntu1.1

---------------
engrampa (1.18.1-0ubuntu1.1) zesty; urgency=medium

  * fix-maximum-compression-zip.patch: new patch. Fixes
    creating zip archives when compression level is set
    to maximum (LP: #1580860)

 -- Vlad Orlov <email address hidden> Sun, 24 Sep 2017 13:57:34 +0300

Changed in engrampa (Ubuntu Zesty):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for engrampa has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package engrampa - 1.12.0-2ubuntu0.1

---------------
engrampa (1.12.0-2ubuntu0.1) xenial; urgency=medium

  * fix-maximum-compression-zip.patch: new patch. Fixes creating
    zip archives with maximum compression level (LP: #1580860)

 -- Vlad Orlov <email address hidden> Mon, 30 Oct 2017 16:43:32 +0300

Changed in engrampa (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.