Terminator

bizarre extra matching of TLD on mailto: URLs

Bug #161116 reported by Chris Jones
4
Affects Status Importance Assigned to Milestone
GNOME Terminal
Fix Released
Medium
Terminator
Fix Released
Medium
Thomas Hurst
Terminator 0.9 "rocking"
gnome-terminal (Ubuntu)
Fix Released
Low
Ubuntu Desktop Bugs

Bug Description

If a mailto: URL occurs in a terminal (e.g. mailto:<email address hidden> ) VTE will match the whole address correctly, but will also match the ".com" as an email address.
It will not do this if there is no leading "mailto:" or if the email address has a hostname (e.g. "mailto:<email address hidden>").

Possibly it is because of the regular expression engine in use, and the use of braces in the regular expression for matching email addresses.

Chris Jones (cmsj)
Changed in terminator:
assignee: nobody → cmsj
importance: Undecided → Medium
milestone: none → 1.0-beta
status: New → Triaged
Revision history for this message
Chris Jones (cmsj) wrote :

This persists even without the experimental URI domain matching code.

Revision history for this message
Chris Jones (cmsj) wrote :

This is known upstream:
http://bugzilla.gnome.org/show_bug.cgi?id=452637

fwiw, I strongly suspect that this relates to the regexp used to match email addresses, but I can't at all figure out why, so perhaps it is a bug in the VTE code that checks the displayed text for regexp matches.

Pedro Villavicencio (pedro)
Changed in gnome-terminal:
assignee: nobody → desktop-bugs
importance: Undecided → Low
status: New → Triaged
Bug Watch Updater (bug-watch-updater)
Changed in gnome-terminal:
status: Unknown → New
Revision history for this message
Thomas Hurst (tom.hurst) wrote :

It's the last group in the regexp. Eliminating it appears to resolve the problem, but might increase the rate of false positive matches. I've committed the change to trunk.

Unfortunately setting the group to non-capturing using (?:) isn't an option; it's not supported on my vte anyway.

Revision history for this message
Thomas Hurst (tom.hurst) wrote :

The modified regexp seems to work even better than I expected; I would have thought it would catch trailing .'s. Needs testing.

I also made the regexp case-insensitive.

Changed in terminator:
assignee: cmsj → tom.hurst
milestone: 1.0-beta → 0.9
status: Triaged → Fix Committed
Bug Watch Updater (bug-watch-updater)
Changed in gnome-terminal:
status: New → Fix Released
Revision history for this message
Pedro Villavicencio (pedro) wrote :

fixed upstream already.

Changed in gnome-terminal:
status: Triaged → Fix Committed
Revision history for this message
Thomas Hurst (tom.hurst) wrote :

Gnome Terminal is now using two different batches of regexps; the original ones for <0.16.15 and pcre-looking ones for newer vte's. Neither match our change. This should be reevaluated for 1.0.

Revision history for this message
Chris Jones (cmsj) wrote :

0.9 has now been released and should fix this.

Changed in terminator:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-terminal - 2.23.6-0ubuntu1

---------------
gnome-terminal (2.23.6-0ubuntu1) intrepid; urgency=low

  * New upstream release
    - Add option --maximized (LP: #201930)
    - Match caseinsensitively (LP: #228751) (LP: #161116) (LP: #172460)
  * debian/control.in:
    - Lets bump vte 0.16.15 to get gt using GRegex to fix
      case sensitive bugs
  * debian/patches/99_autoreconf.patch:
    - Refreshed for the new release

 -- Pedro Fragoso <email address hidden> Thu, 07 Aug 2008 16:18:31 +0100

Changed in gnome-terminal:
status: Fix Committed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in gnome-terminal:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.