partitions without offset should be kept in yaml order

Bug #1631423 reported by Steve Langasek
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu Image
Fix Released
High
Barry Warsaw

Bug Description

The docs currently say:

offset
    (optional) The offset in bytes from the beginning of the image. If not specified, placement of the structure within the disk image is implementation-dependent.

We want to tighten this to not be implementation-dependent, but instead to place all partitions with no specified offset on the disk in the order in which they're specified in the gadget.yaml.

Barry Warsaw (barry)
Changed in ubuntu-image:
milestone: none → 0.11
assignee: nobody → Barry Warsaw (barry)
importance: Undecided → High
status: New → In Progress
Revision history for this message
Barry Warsaw (barry) wrote :

Some quick notes.

The official gadget.yaml documentation is now here: https://github.com/snapcore/snapd/wiki/Gadget-snap

offset is now *not* implementation dependent. The spec says:

        # The offset from the beginning of the image. Defaults to right after
        # prior structure item. (optional)
        offset: <bytes> | <bytes/2^20>M | <bytes/2^30>G

That doesn't change the need for this fix, just that we're making the code reflect the specification.

Revision history for this message
Barry Warsaw (barry) wrote :
Barry Warsaw (barry)
Changed in ubuntu-image:
status: In Progress → Fix Committed
Barry Warsaw (barry)
Changed in ubuntu-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.